Paul Licameli
60bcd7aea2
Fix warnings for unused variables and functions
2016-02-26 14:56:26 -05:00
Paul Licameli
990080ae7d
Replace virtual with override wherever possible; eliminate needless virtual...
...
... for functions in final classes.
override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.
There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
89f28546a3
Commented suspicious non-override virtual functions of Effect
2016-02-26 12:35:29 -05:00
Paul Licameli
a8652c5e74
uses
2016-02-25 20:18:31 -05:00
Paul Licameli
7824e94030
Harmlessly qualify classes as final (or explicitly comment not)...
...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls. Mostly useful as documentation of design intent.
Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
c98b090182
Rename SyncLockTracksIterator::First to StartWith to be consistent
2016-02-24 12:59:28 -05:00
Paul Licameli
99f161c36c
Sweep unnecessary wxString copies: effects
2016-02-22 22:31:47 -05:00
Paul Licameli
1c07741d57
Sizers are owned by wxWindow objects when added, so use safenew, or...
...
... use unique_ptr in the interim between building them and adding.
This checks eliminates some naked news, which were not paired with deletes.
2016-02-18 18:58:38 -05:00
Paul Licameli
4d78e353c3
Revert "sizers"
...
This reverts commit 84c0a0b6663a1210be502a76ab9c48dd330b3919.
2016-02-18 14:50:52 -05:00
Paul Licameli
84c0a0b666
sizers
2016-02-18 02:54:50 -05:00
Paul Licameli
dbaa811577
Stack-allocate where possible! ...
...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
df6a7c5464
More uses of safenew for classes we derive from wxWindow classes...
...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli
3f237daddc
Use macro safenew for many allocations of wxWindow subclasses
2016-02-14 20:20:19 -05:00
Paul Licameli
6052b5f9be
Throw by value, catch by reference: don't use pointers...
...
... that's what the better books on C++ recommend.
2016-02-14 19:36:17 -05:00
Paul Licameli
7c4c45a0d5
"new"->"NEW" in comments, easier to find remaining naked operator new
2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343
"delete"->"DELETE" in comments, easier to find remaining naked operator delete
2016-02-14 18:50:45 -05:00
Paul Licameli
daa7617e88
auto_ptr (deprecated) -> unique_ptr (preferred in C++11)
2016-02-13 12:00:28 -05:00
Paul Licameli
507cee7ee5
One less indirection accessing Region
2016-02-02 11:49:53 -05:00
Paul Licameli
3c2e88a6dc
Fix compiler warning
2016-01-29 10:14:52 -05:00
Steve Daulton
5c2fc5ff7d
Fix bug 1317
2016-01-27 13:38:21 +00:00
Steve Daulton
954bb0fd1c
Fix for bug 955 from Clayton Otey
2016-01-26 18:19:19 +00:00
Steve Daulton
f7fba31319
Fix bug 1312
2016-01-25 18:01:14 +00:00
Steve Daulton
360fc58dea
Fix bug 1311
2016-01-25 17:57:04 +00:00
Paul Licameli
cdc8142940
Fix the new Truncate Silence
2016-01-23 09:08:27 -05:00
Paul Licameli
513d1c548f
Enh52: Truncate Silence has an option to process tracks independently...
...
When the new checkbox is on, truncate each selected wave track independently.
Refuse to do it if any two selected audio tracks are sync locked to each other.
But label tracks sync-locked with a selected wave track will truncate as
expected.
2016-01-23 00:46:10 -05:00
James Crook
d538806dc1
Merge pull request #91 from somasis/musl-fix
...
Fix building on musl libc
2016-01-22 18:09:24 +00:00
Paul Licameli
97e8fe3864
include <algorithm> to fix Windows build
2016-01-21 10:41:03 -05:00
Steve Daulton
4a5e188a00
Fix for bug 1241
...
Percent change is now saved accurately so that the user gets
stretching according to the control used.
2016-01-21 04:03:32 +00:00
Steve Daulton
1d6d08c47d
Don't push effects that can't be undone onto the Undo Stack
2016-01-21 02:07:28 +00:00
Steve Daulton
57d1f5583d
Fix for bug 661
...
Introduce *DECIMAL-SEPARATOR* global for Nyquist.
Improvements to numeric validation error messages.
Fix *TRACK* START-TIME and END-TIME properties for tracks with different
length channels.
Update Adjustable Fade, Regular Interval Labels and Vocal Removal
to use numeric text inputs.
This does NOT fix bug 1020.
2016-01-21 01:29:56 +00:00
Steve Daulton
46055cde25
Fix effect preview issues
...
Fixes bug 1274 and unblocks bug 995.
2016-01-20 18:19:11 +00:00
Steve Daulton
6663f406d3
Bug 1275 - No preview in Spectral edit effects
...
Introduces a new type 'spectral' t Nyquist plug-ins
2015-12-26 19:26:39 +00:00
Leland Lucius
76436fc3fd
Don't display message if the EQ curves file is missing.
...
I can't think of a reason for having the message. Either the curves
are there or they are not.
2015-12-21 23:38:05 -06:00
David Bailes
13f13490e6
Fix for Bug 1267 - Accessibility: some panels used for graphics are included in tab traversal
...
Bug due to update and wxWidgets bug 1267.
Fix is to add the override of AcceptsFocusFromKeyboard().
2015-11-26 15:21:48 +00:00
Kylie McClain
409ebb9a03
Fix building on musl libc
2015-11-21 17:04:43 -05:00
James Crook
4dbcd73ca5
Noise Reduction smoothing now default 3 Max 12
...
After the freeze, but only just, and as RM I made the call that this matters enough to be worth doing.
2015-09-07 21:03:31 +01:00
Paul Licameli
374f7700d7
Change default for Frequency Smoothing in Noise Reduction
2015-09-01 17:15:31 -04:00
Paul Licameli
9c483e2e86
Add (redundant) #include "Experimental.h" in all .cpp files using the symbols
2015-08-31 17:56:10 -04:00
Paul Licameli
d18553a3f0
Put Experimental.h (redundantly) in headers that rely on it
2015-08-31 17:53:12 -04:00
Paul Licameli
ca9928d533
Add missing critical inclusions of Experimental.h to other headers
2015-08-31 17:21:50 -04:00
Steve Daulton
351a2a8528
Update Nyquist *TRACK* property list
2015-08-28 16:12:23 +01:00
Leland Lucius
c552254848
Fix for bug #1163
2015-08-27 18:01:39 -05:00
Leland Lucius
2a234d86f8
"Should" fix the remaining issue in bug #1081
2015-08-27 10:16:28 -05:00
Leland Lucius
e15236efdc
Fix the assertion mentioned in bug #1081
2015-08-27 09:38:09 -05:00
Leland Lucius
00015d4598
Fix for bug #1084
...
Can you believe I had to change a "0" to a "1"???
2015-08-27 01:55:55 -05:00
Leland Lucius
6a9dae20f5
Appearance on OSX is now back to normal or better
...
Some additional wx3 cleanup as well.
2015-08-23 20:25:01 -05:00
Steve Daulton
8828ab50b7
Remove obsolete 'rate' keyword to prevent crash
...
and added numeric-text controls.
2015-08-23 18:37:18 +01:00
Paul Licameli
1b8f44d053
ViewInfo does not redundantly (or inconsistently!) store the screen width
2015-08-21 22:39:18 -04:00
Leland Lucius
5a9025b558
Hopefully this'll fix the assertions
2015-08-16 15:04:24 -05:00
Leland Lucius
b31aad8323
Fix for bug #1117
...
Previous fix didn't produce the same results as 2.0.6, this one
should.
2015-08-16 00:15:55 -05:00
