... I checked, and there are no other missed inclusions of Experimental.h
before tests of EXPERIMENTAL_* macros, except the special handling of version
numbers in Audacity.h.
... This quiets warnings from:
lib-src/FileDialog/mac/FileDialogPrivate.mm
lib-src/portaudio-v19/src/hostapi/coreaudio/pa_mac_core.c
lib-src/portaudio-v19/src/hostapi/coreaudio/pa_mac_core_utilities.c
lib-src/portmixer/src/px_mac_coreaudio.c
It's not good to ignore these deprecations forever, but this reduces the noise
from a complete rebuild, making other warnings more conspicious by their
fewness.
... all of them harmless and inconsequential at runtime, but see commit
comments about the error checks in libnyquist that were revealed by the
compiler warnings as never doing anything useful.
... there is a difference in the type, not the value, of the constant defined
by the two versions of the macro. See clock_types.h in the Mac SDK:
define NSEC_PER_MSEC 1000000ull /* nanoseconds per millisecond */
Problem: With host set to WASAPI: if the playback position is less that about ten seconds before the end of any of the tracks and the user presses one of the left/arrow keys to seek, then a bug alert appears, and it's seems like it's impossible to recover from this.
libsoxr 0.1.3, first used in Audacity 2.3.0, crashes with constant rate resampling if you try to reuse the resampler after it has flushed.
Fix: work around which is the same as used for bug 1887 - recreate resamplers, rather than reusing them.
... and move one more gPrefs lookup into it.
Don't expect TrackPanel to invoke it always, because sometimes TrackArtist
is standalone, as in Printing.cpp
... keep the name, but change the value to be what it really says:
the proper width of the track control panel, agreeing with the hit-test
area, NOT including the left margin
And change places where the constant was used, adding the margin back again.
Fixes -v / --verbose.
Fixes file paths (Windows and Linux).
Relative file paths would (before this fix) be wrong unless the command
was launched from the same directory as Audacity's working directory
(Windows and Linux only)
