James Crook
45069794f3
Reduce indentation in AudioIO
...
Flipped some conditions and used if else-if to reduce the indentation in code.
This makes the code more readable. No change in functionality.
Also created UpdateTimePositions() and made some bool functions void.
new variable mMaxFramesOutput used to communicate positional change.
2018-10-16 13:01:22 +01:00
James Crook
51b3076786
Fix include path
2018-10-16 13:01:22 +01:00
Steve Daulton
cb55164c43
Add Project Rate to SetProjectCommand
2018-10-15 23:51:41 +01:00
Paul Licameli
6ca721b03a
Fix a string again...
...
... This string appears when you enter a positive, invalid value for peak
amplitude in the Normalize effect. It didn't look right with periods (a space
was left before the first period). Let's use parentheses instead.
2018-10-15 12:59:02 -04:00
Paul Licameli
ef97ce88ca
Correct more double spaces
2018-10-15 12:54:44 -04:00
James Crook
d2578b9eaa
Remove some duplicated code in AudioIO
2018-10-14 22:45:41 +01:00
Darrell Walisser
651957f8c2
fix bug compiling on Linux/gcc-4.9 with wxwidgets 3.0.2
2018-10-14 11:57:58 +01:00
Darrell Walisser
5dfff70f5b
Fix OpenMP build
2018-10-14 11:34:37 +01:00
scootergrisen
b4f7946e9b
Remove some double space
2018-10-14 10:42:01 +01:00
Imre Kristoffer Eilertsen
218eb67316
Fixed 4 spelling errors
2018-10-14 06:33:18 +02:00
Imre Kristoffer Eilertsen
6f546de929
Updated the Norwegian translation quite heavily
2018-10-14 03:55:07 +02:00
James Crook
cdf9d63760
Bug 1979 - Activate Paul's fix for Windows too.
...
I tested the basics, and no block files were lost.
2018-10-13 22:02:09 +01:00
James Crook
ffa67d2b1e
Split AudioIO into two classes
...
AudioIO.cpp has nearly 6000 lines and needs to be broken up into separate aspects.
The main point of the new split is to better separate the time critical callback code (that runs in the portaudio thread) from the code that interacts with the disk (that runs in the Audio Thread).
2018-10-13 21:38:35 +01:00
James Crook
26086a4142
Split MenuCommandHandler into three classes.
...
Menus.cpp is over 10,000 lines. The main point of the split is to make possible a new .cpp file for MenuCreator, which is responsible for the creation of the menu bar, and which contains the near 2,000 line function MenuCreator::CreateMenusAndCommands()
The menu handlers are also (better) separated from the menu management.
2018-10-13 21:38:34 +01:00
Paul Licameli
529e1e2afb
Bug1979 partial: Faster first-time save, if possible, on Mac and Linux
2018-10-13 13:56:05 -04:00
Paul Licameli
cbe0ea84c1
Define FileNames::HardLinkeFile, but nonfunctional on Windows
2018-10-13 13:18:17 -04:00
Paul Licameli
04b5054ad1
Reorganize commit/rollback of SetProject, prior to fixing bug1979
2018-10-13 12:55:55 -04:00
Paul Licameli
e87e15f489
Proper deferring of DirManager's commit steps when saving-as
2018-10-13 12:55:29 -04:00
Paul Licameli
ec506ab52b
Define DirManager::ProjectSetter so that commit steps can be deferred
2018-10-13 12:55:29 -04:00
Paul Licameli
0db0c6e0d5
Reorganize some commit logic in DirManager::SetProject
2018-10-13 12:55:29 -04:00
James Crook
555345392e
Fix Pa_IsFormatSupported query flood (from Max Maisel)
...
We ask 17 times for different rates, and for some drivers that is too much of a flood.
Workaround is to use a small delay between requests.
Only happens at start up, so is acceptable to just always do it.
2018-10-12 15:59:27 +01:00
James Crook
3ddb536a8e
Fix eu_ES.po revision date.
...
XCode project gave a warning about the broken revision date.
2018-10-12 12:17:11 +01:00
James Crook
60b2dc720e
Fix incorrect wxASSERT
...
Also update comments to explain.
2018-10-12 10:08:31 +01:00
Paul Licameli
297f3b4d84
Fix another mistake in iteration over channels in src/commands
2018-10-11 21:40:38 -04:00
James Crook
494ab4eafe
Make AudioIO::Callback() code shorter
...
Use subroutines, wxClip and cut out some dead code.
2018-10-11 19:58:21 +01:00
James Crook
939b967497
Refactor AudioIO::Callback()
...
This code had got ridiculously long (for a fast callback function) and needed to be broken up into smaller clearer named functions.
2018-10-11 18:08:42 +01:00
Steve Daulton
286bf5d5be
Additional comments in rms.ny for plug-in authors
...
Also reformatted translations as a more readable list.
2018-10-11 13:58:40 +01:00
Steve Daulton
37ec7da3c3
Throw error if Nyquist *LOCALE* is malformed
...
Partial translations are allowed.
2018-10-11 13:58:40 +01:00
James Crook
e20a98588c
Replace pointless looping by 'if'
...
The for loop was only to test if *some* track was selected, and its body only needs to be executed once.
Note that an empty IteratorRange is false and one with something in it is true.
2018-10-11 12:04:43 +01:00
James Crook
15a3ea7763
Bug 2010 - Scriptables: SelectTracks and Select incorrect for stereo tracks
2018-10-11 11:29:53 +01:00
James Crook
7e5a716e65
Fix C4458 Warnings
...
C4458 is 'Declaration hides class member'
2018-10-10 19:46:25 +01:00
James Crook
657159d542
Fix C4189 and C4100 Warnings
...
C4189 is 'Local variable initialised but not used'
C4100 is 'Unreferenced parameter'
Fixed some other warnings, e.g. about empty if, too.
2018-10-10 19:46:24 +01:00
Steve Daulton
66c861315f
Exclude rms.ny from update_po_files.sh script
...
Script run to update po files
2018-10-10 17:56:21 +01:00
James Crook
5fd95dd131
Fix C4456 Warnings.
...
"C4456 declaration hides previous local declaration."
These arise from repeated declarations of the same name.
2018-10-10 17:28:50 +01:00
Max Maisel
43402438f8
Link with -latomic if using clang on Linux.
2018-10-10 15:35:17 +01:00
Jorge
ac8273342f
Add 2.3.0 release information in appdata
2018-10-10 15:27:32 +01:00
Jorge García
242fa748ab
Add component type in appdata
...
This field is required in order to flathub.org to properly update app
info
2018-10-10 15:27:31 +01:00
Steve Daulton
a7d34b1743
Correct Russian translation in rms.ny
...
Reverts incorrect change in 665e2d0
2018-10-10 11:21:13 +01:00
Steve Daulton
297bf442a4
Fix typo in 665e2d0
2018-10-09 01:13:48 +01:00
Steve Daulton
665e2d0e9c
Correction to translation of rms.ny
...
Update Russian translation in rms.ny and make variables local to
underscore function.
2018-10-09 01:04:05 +01:00
Steve Daulton
5d34d022a5
Add rms.ny to Audacity bundle
...
Tidy translation code in init.lsp
Include rms.ny in Makefile.am
Add rms.ny to Linux package
Update Makefiles with: autoreconf --force --no-recursive
Add rms.ny to mac build
Add rms.ny to Windows build
2018-10-08 18:55:46 +01:00
Paul Licameli
14fe11f4d4
Bug2008: There was error in stereo Contrast calculation, at aee4005
2018-10-07 10:29:58 -04:00
Paul Licameli
3f928a25b0
Bug2004: Opening Mixer Board with a Note track crashed...
...
... Just one null check was needed, but I also add another, and use a
wxWeakRef pointer, for more safety.
2018-10-06 11:20:30 -04:00
Paul Licameli
e6e4f44c81
Bug1997: Split Stereo Track and Split Stereo to Mono were doing nothing
2018-10-05 22:09:10 -04:00
Paul Licameli
b5a7b67cb7
Fix some crashes in time-shift
2018-10-04 12:02:51 -04:00
Paul Licameli
92cceaf599
Fix usage of InconsistencyException
2018-10-04 11:44:46 -04:00
Paul Licameli
90e2da7f14
Fix uses of TrackList::GroupChannels in Mix and effect preview
2018-10-04 11:34:14 -04:00
Paul Licameli
df1103822e
Don't crash in Nyquist tools with mOutputTracks undefined
2018-10-04 10:56:03 -04:00
Paul Licameli
75918918c4
Correct template parameters to std::iterator base of TrackIter...
...
... so that std::reverse_iterator<TrackIter<T>> works right, not making a
subtle error of return of reference to a temporary in its operator * with some
compilers.
2018-10-03 22:47:21 -04:00
Paul Licameli
50f2b0e860
Bug1995: Fix drawing of stereo tracks, bug introduced at 0c0c2c0
2018-10-03 17:19:15 -04:00