Paul Licameli
49dd6002d3
Simplify HighlightFocusedTrack
2018-11-02 16:51:08 -04:00
Paul Licameli
e31669f555
comment out unused function
2018-11-02 16:51:07 -04:00
Paul Licameli
c1b729822c
Remove unused arguments of some drawing functions
2018-11-02 16:51:07 -04:00
Paul Licameli
3e1d4a962d
Fix drawing of lower right corners of vertical rulers
2018-11-02 16:51:07 -04:00
James Crook
466e9c179e
Create ComponentInterface
...
It combines the old IdentInterface with the ParamsInterface, providing an identifier and parameters (if needed).
The main purpose of the change is to make the class hierarchy (as viewed via doxygen) much easier to follow.
2018-11-02 17:04:43 +00:00
Paul Licameli
c63dcbd3ca
Oops, forgot the vertical rulers in the subdivision of TrackPanel !
2018-11-02 10:30:56 -04:00
Paul Licameli
39fc20c5ee
TrackPanelCellIterator is no longer needed
2018-11-01 18:25:02 -04:00
Paul Licameli
005abb06d6
Replace uses of TrackPanel::Cells() with CellularPanel::VisitCells()
2018-11-01 18:25:02 -04:00
Paul Licameli
01551913f0
nonvirtual reimplementation of CellularPanel::FindRect using nodes
2018-11-01 18:25:02 -04:00
Paul Licameli
cfa7afcb24
nonvirtual reimplementation of CellularPanel::FindCell using nodes
2018-11-01 18:25:02 -04:00
Paul Licameli
128ba93ae7
Implement TrackPanel::Root()
2018-11-01 18:25:01 -04:00
Paul Licameli
08f88ebf2e
Implement AdornedRulerPanel::Root()
2018-11-01 17:45:51 -04:00
Paul Licameli
588c050bbb
Define visitation procedure skeleton for subdivision of CellularPanel
2018-11-01 17:43:04 -04:00
Paul Licameli
4fe97acbc9
Define CellularPanel::Root
2018-11-01 17:37:22 -04:00
Paul Licameli
30d55f476e
Define abstract classes TrackPanelNode and TrackPanelGroup
2018-11-01 17:33:15 -04:00
David Bailes
7549b9f996
Correct mSeekShort to mSeekLong in a few places
...
Correct typos which were causing incorrect size of cursor movements
2018-10-31 13:43:42 +00:00
Paul Licameli
5b01f57919
Update comments about TrackPanel and TrackArtist...
...
... Remove mention of obsolete plans for TrackPanel refactor, superseded by a
different refactor now accomplished.
Remove detailed mention of names of functions and data members that implement
drawing.
Move most of Roger's comments about drawing into Overlay.h which is now the
more relevant place.
Commented more correctly what TrackPanelListener is.
2018-10-31 08:06:18 -04:00
Steve Daulton
6e75ff27c8
Bug 2022 Mixer Board does not automatically update
...
OnTrackSetChanged sets mUpToDate to false, which assumes that
MixerBoard::OnPaint(evt) will be called, but on Linux, the event
appears to be eaten by MixerTrackCluster::OnPaint and TrackClusters
were not updated.
2018-10-31 09:51:34 +00:00
Paul Licameli
912b24f211
Revert "Small widening of the click-to-deselect area below the tracks..."
...
This reverts commit c101cf3b32ab5023308f2331b5c49df51a492736.
2018-10-30 21:56:22 -04:00
Paul Licameli
e9d1dfb2dd
more const arguments in TrackArtist
2018-10-30 13:42:49 -04:00
Paul Licameli
c101cf3b32
Small widening of the click-to-deselect area below the tracks...
...
... this should make the division of the TrackPanel area defined in
TrackPanelCellIterator::UpdateRect exhaustive.
2018-10-30 13:03:47 -04:00
Steve Daulton
4f964c359b
bug 2017 'offset' was used uninitialised
2018-10-30 15:58:47 +00:00
Paul Licameli
26abe0255d
Precautions also in TrackIterRange::StaringWith() as in EndingAfter()
2018-10-30 11:37:08 -04:00
Paul Licameli
74a360f682
Bug2020: Fix sync-lock groupings
2018-10-30 10:54:37 -04:00
Paul Licameli
793949aa29
more comments about TrackIterRange operators
2018-10-30 09:32:29 -04:00
James Crook
cc2c3dc2fc
Bug 2016 - Multiple problems with Change Pitch
2018-10-30 12:21:24 +00:00
Paul Licameli
3be57fce49
Bug2015: crash repeatedly append-recording with sync-lock on
2018-10-29 20:35:45 -04:00
Paul Licameli
9c9bc70e9b
Fix sorting of effects below the separator...
...
... commit 52672ed was a mistake.
2018-10-29 16:21:37 -04:00
Steve Daulton
46a3f91d59
Add some useful path definitions for Nyquist
2018-10-29 20:01:21 +00:00
James Crook
c79d65cdeb
Bug 2019 - Scriptables: Set Envelope allows envelope points at zero which can cause NaNs
2018-10-29 19:59:29 +00:00
James Crook
6a4663e19c
Use wxGetUTCTimeMillis in preference to wxGetLocalTimeMillis
...
For internal time-difference test, it is significantly faster, and does not suffer from daylight-saving time shifts.
2018-10-29 19:59:28 +00:00
Paul Licameli
0fbea5f9ea
Fix failure of Nyquist to translate some multiline strings...
...
... Don't trim leading whitespace from source file lines before passing them
to eval.
So when a string in Lisp code is (_ "like
this")
(the Lisp reader allows embedded newlines in quoted strings),
then the string extracted to the .pot file by xgettext contains the spaces, and
the string literal seen by our Lisp interpreter will also retain the spaces and
match the msgid in the catalog exactly.
2018-10-29 13:49:14 -04:00
Paul Licameli
5dc4185ce2
Leave arguments anonymous, remove unused variables in menu code...
...
... history window updates itself in response to events. The intention was to
eliminate all mention of it in edit menu code.
2018-10-29 13:37:24 -04:00
Paul Licameli
87592cc89b
Remove unused (and unintended) overload of Items
2018-10-29 13:32:44 -04:00
James Crook
76166135d4
Fix many MSVC compiler warnings.
2018-10-29 13:19:33 +00:00
Paul Licameli
50f8579475
Move AudacityProject::DoTrackMute and DoTrackSolo...
...
... also fixed the bug that muting and soloing from the mixer board did not
update accessibility.
2018-10-28 16:50:01 -04:00
Paul Licameli
51c3541716
Move AudacityProject::RemoveTrack
2018-10-28 16:45:38 -04:00
Paul Licameli
83f504e30f
Move AudacityProject::SetTrackPan and SetTrackGain
2018-10-28 16:43:20 -04:00
Paul Licameli
edd23e2634
Move AudacityProject::GetZoomOf*
2018-10-28 16:43:17 -04:00
Paul Licameli
b2ea8ab6e9
Move AudacityProject::EditByLabel and EditClipboardByLabel
2018-10-28 16:30:39 -04:00
Paul Licameli
95cca91eb1
Move AudacityProject::Clear
2018-10-28 16:26:03 -04:00
Paul Licameli
0969d00b1b
Comment out an unused UpdatePrefs function
2018-10-28 12:59:58 -04:00
Paul Licameli
b4fc4b9ceb
Proper initialization of menu handlers from preferences
2018-10-28 12:58:39 -04:00
Paul Licameli
cda9715ce6
Fix TrackList event propagation
2018-10-27 21:26:07 -04:00
Paul Licameli
012ea76132
Moved mixer board update code out of class AudacityProject...
...
... And we don't need GetMixerBoard() any more
2018-10-27 18:01:09 -04:00
Paul Licameli
723cecbeac
Mixerboard uses events to detect start and stop of playback
2018-10-27 18:01:08 -04:00
Paul Licameli
1fc4c5724e
MixerBoard no longer needs update at undo push...
...
... it does that sooner, and ony when needed, when relevant track data really
change, by listening to the TrackList.
2018-10-27 18:01:08 -04:00
Paul Licameli
ccc2bbe3ef
MixerBoard listens for events for track sliders, mute, solo, name
2018-10-27 18:01:08 -04:00
Paul Licameli
5ab2faceea
MixerBoard listens to TrackList for insert, delete, permute...
...
... Which is also sufficient to detect undo/redo/rollback
And detects more often than undo state changes, so that if you drag a track
in TrackPanel, the same permutation is seen at once in MixerBoard, even before
button-up
2018-10-27 18:00:52 -04:00
Paul Licameli
7150d43083
MixerBoard listens to TrackList for selection changes
2018-10-27 16:27:53 -04:00
