1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-11 14:41:06 +02:00

1292 Commits

Author SHA1 Message Date
Steve Daulton
4ec1393c27 Error if Nyquist Prompt requires track election 2018-08-21 16:28:59 +01:00
Steve Daulton
94b3bf3c22 Remove superfluous log message 2018-08-21 14:09:56 +01:00
Steve Daulton
b9ec43433e Bug 1934 residual
Allow generate type plug-ins spawned from Nyquist Prompt to create
a new track if none selected.

This commit also fixes preview in generators when there is no selection.
2018-08-21 14:02:48 +01:00
Steve Daulton
5be7f7db0b White space changes
The Objective C++ syntax '[[' used in a couple of places (Mac only),
breaks the parser in kdevelop. As suggested by Paul, a space between the
brackets fixes the problem.
Also removed some trailing spaces.
2018-08-15 11:29:12 +01:00
Steve Daulton
8eef6dc3ef Fix bug 1938
Nyquist / Adagio variable 'S' should have the value 0.25 in all but
legacy process and analyze effects.
2018-08-13 16:45:21 +01:00
Steve Daulton
0d9cd4b024 Fix bug 1937
';type tool' effects cannot return audio from Nyquist.
2018-08-13 14:28:33 +01:00
James Crook
3480f5aa3a Bug 1934 - Generate audio from Nyquist prompt crash
We now default to Effect (EffectTypeProcess), if no type was specified.
2018-08-13 12:29:31 +01:00
James Crook
2d28b2e7e1 Bug 1907 - Mac: Some buttons in effects dialogs have non-transparent background
It's not clear why this worked before.
- Mac was not clearing any backgrounds for the button bitmaps.
- There were no pressed buttons defined (on any platform).
2018-08-10 18:39:34 +01:00
James Crook
7f96f85676 Add some Right-To-Left language workarounds.
MixerBoard, LyricsWindow, Screenshot and most effects are now LTR in RTL locales.
Also added a pref so this can be overridden.  As RTL affects window creation, the language choice and this preference may only fully take effect after a restart of Audacity.
2018-08-10 18:39:33 +01:00
James Crook
233b1677dd Bug 1914 - Enh: Clean install needed to update effect/generate/analyze/tools menu for changed plug ins
This code now does the clean out of pluginregistry.cfg.
Nicer for the user would be to preserve the list of hand-added plug-ins.  But a clean restart is easier.
2018-08-03 19:08:40 +01:00
James Crook
4318cb6780 Bug 1886 - Sluggish behaviour caused by the large time taken to draw the Track Control Panel
All backing bitmaps (not just the one in track panel) now are set to 24 bits.
Big thanks to David Bailes for tracking down the root cause of slow BitBlts, and the comments at https://trac.wxwidgets.org/ticket/14403 which led to the fix.

In testing the bitmaps, I also fixed the sizer errors reported for Export.cpp that wxWidgets now reports as ASSERTS when running in debug builds.
2018-08-03 18:29:49 +01:00
James Crook
1192914460 Fix duplication of Nyquist Prompt.
Now just one Nyquist Prompt, and it's in the tools menu.
2018-08-03 16:11:44 +01:00
James Crook
ecd09a19de Preserve selection on exit from Nyquist prompt.
This is required, because AUD-DO could change the selection.
2018-08-02 16:51:23 +01:00
Paul Licameli
06eee27b9a Rewrite commit 1bc0f0f without further changes to lib-src...
... Reuse the external function registration added earlier in 2.3.0
development, for support of internationalization in Nyquist.

This way, we avoid making cyclic static linkage dependencies between the
library and the application.
2018-08-01 23:11:30 -04:00
James Crook
c21855bbca Change ";type tool" to not iterate through tracks or selection.
Also adds the options
;type tool
;type tool process
;type tool generator
;type tool analyze

These tools will appear in the Tools menu, but behave as their second argument (if any)
2018-08-01 20:32:30 +01:00
James Crook
b975956812 Add re-entrancy checks to Nyquist
These changes below are paving the way for aud-do:

Nyquist Effect now detects self reentrancy and skips reentry if so.
Nyquist Effect now detects if another effect has run during effect processing, and does not send Nyquist
output if so.

Neither of these preparatory changes have an effect in absence of AUD-DO (or other function
that allows Nyquist effect to call out to Audacity functions).
2018-08-01 20:31:03 +01:00
James Crook
4d24c0249b Use dB, not LUFS by default.
Parameter name to camel-case, not spaced.
Also a wording change on the choice prompt.
2018-07-28 11:17:04 +01:00
Max Maisel
9cbb67acba Fix too low loudness normalization levels.
LUFS are defined as the power of the signal, not as the root mean square.
Accidential use of the RMS caused incorrect normalization to only half
of the LUFS value.
2018-07-27 16:50:27 +02:00
James Crook
487769d2b6 Change more prompts when switching between LUFS and dB in Normalize.
As well as changing more prompts, the choice between prompts is now made in UpdateUI, rather than also doing so in PopulateOrExchange.
2018-07-26 19:05:31 +01:00
James Crook
bcb60d1f6e Fix initial display of dB/LUFS in Normalize Effect.
Previously it could show dB with the LUFS value, on first use.
Also made the VI string LUFS/dB sensitive.
2018-07-26 17:54:08 +01:00
Max Maisel
e68ea1a272 Added missing bias value in Normalize LUFS calculation. 2018-07-26 17:11:10 +02:00
Max Maisel
0ed9b9d34b Separated peak and LUFS normalization presets. 2018-07-26 17:09:44 +02:00
Max Maisel
58929e4c6c Fixed stereo track LUFS calculation according to EBU R128. 2018-07-26 17:09:44 +02:00
Max Maisel
b1598fd214 Fix peak normalize regression introduced by refactoring (bug #1908). 2018-07-26 17:09:44 +02:00
Max Maisel
514c3f897f Improved source reference for EBU R128 sampling rate adaption. 2018-07-26 17:07:01 +02:00
Max Maisel
ed41183536 Implement EBU R128 loudness normalization.
Please note that normalizing to large LUFS values may introduce clipping
of large peaks. However, the recommended target value in EBU R128 of
-23 LUFS should be totally safe but only uses a small amount of the
possible quantization range. For tracks with normal dynamic range,
normalizing to about -10 LUFS should be possible without clipping.
2018-07-24 17:38:17 +02:00
Max Maisel
d16b4526ce Refactor Normalize extent calculation in preparation of EBU R128 loudness normalization. 2018-07-24 17:29:51 +02:00
Max Maisel
6655f6e38a Fix normalize progress bar in case of stereo tracks.
Before this commit, progress jumped from 0.25 to 0.5,
then from 0.75 to 0.25 and finally from 0.5 to 0.75 when
normalizing a dependent stereo track.
2018-07-24 17:20:52 +02:00
Max Maisel
d707f68189 Expose "msg" parameter in Effect::TotalProgress(). 2018-07-24 17:10:52 +02:00
Max Maisel
473e561f5b Add missing headers in Biquad.h/cpp. 2018-07-24 17:09:52 +02:00
Max Maisel
9fcb83882a Refactor Biquad in preparation of EBU R128 loudness normalization. 2018-07-24 17:08:47 +02:00
Paul Licameli
83e01fb43b Remove 8 warnings about re-#define-d names, related to SoundTouch 2018-07-23 14:27:44 -04:00
Paul Licameli
e432883dec Fix deprecation warnings with wxFont, wxPen, wxBrush ctors...
... Replace some enum constants with the equivalent values from the more
special-purpose enums, as the wx header files recommend, so overloading
selects the ctors with non-int arguments.

In a full rebuild of the debug project on Mac, this reduces the count of
warnings from 264 to 274.
2018-07-23 13:21:15 -04:00
James Crook
848b66f4fa Make title of Nyquist Prompt dialog change appropriately.
Previously it was being overwritten each Init() by the string suitable for the Nyquist Effects Prompt.
2018-07-14 17:38:57 +01:00
James Crook
2739020342 Bug 1902 - "Nyquist Prompt" confusingly shown only as "Nyquist" when "Grouped by Type" is active
Now shown as "Nyquist Effects Prompt" (in Effects menu) and "Nyquist Tools Prompt" (in Tools Menu).
These prompts will have slightly different behaviour, e.g. only tools allow aud-do.
2018-07-14 16:51:49 +01:00
Paul Licameli
29ec921c8b Revert parts of e1b6091 involving effects, for .cfg file compatibility 2018-07-05 09:57:17 -04:00
Steve Daulton
a06e561cb7 Support version strings in Nyquist plug-ins
For shipped plug-ins, the version number is the same as the Audacity
release version when the plug-in was last modified.
2018-07-02 22:41:59 +01:00
James Crook
20178b15e1 Fix some 'declaration hides' warnings.
We were for example getting many of these:
\audacity\src\widgets\numerictextctrl.h(171): warning C4458: declaration of 'value' hides class member

MSVC2013 didn't warn about these, but MSVC2017 does.
2018-06-27 12:36:13 +01:00
Steve Daulton
95ef41413c Better fix for bug 1891
Also reverts previous fix attempts.
2018-06-21 23:54:38 +01:00
Steve Daulton
f145574dd6 Fix for 1891 is specific to Mac / Linux
This is only really a temporary fix - we should be using the
standard "Manage" button, but imo Equalization require a
thorough overhaul.
2018-06-21 15:55:20 +01:00
Steve Daulton
6cff61535b Fix bug 1891 (EQ crash)
This fixes only the crash bug. This effect needs substantial attention.
2018-06-19 11:58:45 +01:00
Steve Daulton
5cdf642133 Fix Travis build 2018-06-18 22:14:38 +01:00
Steve Daulton
5e219a031d Fix Factory Preset for Nyquist file browser
Expand platform independent keyword paths before
writing to pluginsettings.cfg.
2018-06-18 21:32:22 +01:00
Steve Daulton
c8c93319ec File browser widget for Nyquist plug-ins 2018-06-14 21:27:48 +01:00
Paul Licameli
35a97e09e7 Group arguments to StartStream, and a bit less of #ifdef for MIDI play...
... And pull choice of tracks and options out of DoRecord
2018-05-29 00:22:12 -04:00
Paul Licameli
b3bf321893 Rewrite threshold control of Truncate Silence as text box, not a choice 2018-05-23 23:56:30 -04:00
Paul Licameli
c20aefc10f Save, later rethrow exceptions caught in callbacks from C libraries 2018-05-10 01:20:36 -04:00
Paul Licameli
a9e7a7e5d5 movable_ptr(_with_deleter) -> std::unique_ptr 2018-05-10 00:56:37 -04:00
Paul Licameli
b8a8712ba0 make_movable -> std::make_unique 2018-05-10 00:56:36 -04:00
Paul Licameli
7a0475e39f Remove most uses of AUDACITY_OLD_STD 2018-05-10 00:56:36 -04:00