I've changed the wording to give just enough information to be able to use the new interface. Mainly to close this P1 bug, and so not block proceeding to release.
This can happen when a .dll, .so, etc. is found in the Plug-ins
folder. The VST and LADSPA providers will report the same path
since they don't really know at scan time if the .dll/.so is
something they can really handle.
As usual, I started out intending to do as little as possible
to this to get it working and wound up going overboard.
However, I believe it does allow easy management of the effects
and this will provide a basis for the full blown plugin manager
dialog.
When requesting The icon size (under Gnome at least), the size was
overly large, so use the wxMac method and just estimate what it
will be.
And, limit the column widths so the dialog doesn't grow wider than
the screen width.
This adds radio buttons to view all effects, just unregistered effects (effects that are not yet in the menus) or just registered effects (effects that are in the menus. It remembers ticks and unticks until the dialog is closed, so changes to ticks for effects that are not shown by the current filter will still have an effect. It does this by switching back to show-all just before closing the dialog.
On a reset preferences, this adds the default built in effects only. The effects menu now has a 'More...' as its last item, and the list of plugins is invoked there. We can add from that list to the menus from that.
This brings the builtin, LV2, and VAMP effects inline with the
Audio Units, LADSPA, and VST effects. All effects now share
a common UI.
This gives all effects (though not implemented for all):
User and factory preset capability
Preset import/export capability
Shared or private configuration options
Builtin effects can now be migrated to RTP, depending on algorithm.
LV2 effects now support graphical interfaces if the plugin supplies one.
Nyquist prompt enhanced to provide some features of the Nyquist Workbench.
It may not look like it, but this was a LOT of work, so trust me, there
WILL be problems and everything effect related should be suspect. Keep
a sharp eye (or two) open.
Even though this is only a P2, I felt it would be
quite bothersome for the users and might cause some
confusion.
The problem was the the wxLocale was being deleted
before all usage of it was complete. The fix was
to explicitly delete the plugin and module managers.
If you can believe it, this whole big mess is
just to get localized effect labels back into
the menus.
I sure wish I'd had a little bit more time to
finish up all of the effects. It sure would
be a lot cleaner (code wise).
Audacity maintains a list of effects it has seen in the pluginregistry
to provide scanning for "new" effects during startup. It also uses
this list to determine if existing effects are still valid.
It was using the single "Enabled" setting to keep track of that, BUT
it also used the "Enabled" setting to determine if the user chose to
enable or disable the effect. That doesn't work since Audacity can
ignore the users choice if effects come and go.
So, this change fixes it by adding a "Valid" setting to separate the
two cases.
