1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-10 06:01:09 +02:00

9531 Commits

Author SHA1 Message Date
Paul Licameli
55774fbb29 When drawing, treat track plus separator BELOW as the natural grouping...
... and treat the top margin of the first track specially.
2018-11-02 23:16:05 -04:00
Paul Licameli
3589aacd7c Rewrite iteration over tracks in DrawEverythingElse 2018-11-02 23:00:28 -04:00
Paul Licameli
10bc061b00 Pass rectangles to drawing routines excluding left & right margins...
... not insets.

This makes them agree with the horizontal extents of the hit-test areas of
event handling code.

Some routines may draw outside of the box passed in to them, as when drawing
the border around a track.

In some of the routines, fewer pixels are painted than before, but these are
always either cleared already when painting left and right margins, or are
overpainted later, as with the right endpoints of sash borders overpainted by
the border around the track.
2018-11-02 22:45:22 -04:00
Paul Licameli
a2e392433a Paint left and right margins of the whole TrackPanel first 2018-11-02 22:38:11 -04:00
Paul Licameli
d0d88118cc Rectangle passed VRuler draw function agrees with hit test rectangle...
... that is, it is one wider than before.  But the drawing routine compensates
to make the picture no different.
2018-11-02 22:36:47 -04:00
Paul Licameli
e70b240338 The ruler and sash draw functions treat their own backgrounds 2018-11-02 21:10:30 -04:00
Paul Licameli
951e7d27da The vruler and sash draw functions treat their own left boundaries 2018-11-02 21:07:48 -04:00
Paul Licameli
0f17b309bc Fuse the two sash-drawing functions, pass a rectangle not a track...
... and be consistent about substituting the track before finding Y and height
2018-11-02 21:07:45 -04:00
James Crook
88c70f3c37 Remove win/compile.txt which was accidentally re-introduced.
win/build.txt is its replacement.
2018-11-02 23:09:16 +00:00
Paul Licameli
fb15558a07 Update XCode project for renamed header file 2018-11-02 18:44:17 -04:00
James Crook
dccf5fcbf9 Don't include "Quick Fix" in menus for 2.3.1. 2018-11-02 22:07:01 +00:00
James Crook
7f8bfa0ac2 Make microfades into a preference. 2018-11-02 21:58:53 +00:00
Paul Licameli
b07097df3a Reorganize some track drawing code, no change of appearance intended 2018-11-02 16:51:08 -04:00
Paul Licameli
8d02134d6a Simplify the track rectangle calculations in TrackArtist 2018-11-02 16:51:08 -04:00
Paul Licameli
49dd6002d3 Simplify HighlightFocusedTrack 2018-11-02 16:51:08 -04:00
Paul Licameli
3e1d4a962d Fix drawing of lower right corners of vertical rulers 2018-11-02 16:51:07 -04:00
Paul Licameli
e31669f555 comment out unused function 2018-11-02 16:51:07 -04:00
Paul Licameli
c1b729822c Remove unused arguments of some drawing functions 2018-11-02 16:51:07 -04:00
James Crook
36933b5c5e Show GStreamer in Doxygen too. 2018-11-02 19:54:04 +00:00
James Crook
095c6d87ef More complete doxygen coverage 2018-11-02 18:23:59 +00:00
James Crook
466e9c179e Create ComponentInterface
It combines the old IdentInterface with the ParamsInterface, providing an identifier and parameters (if needed).
The main purpose of the change is to make the class hierarchy (as viewed via doxygen) much easier to follow.
2018-11-02 17:04:43 +00:00
Paul Licameli
c63dcbd3ca Oops, forgot the vertical rulers in the subdivision of TrackPanel ! 2018-11-02 10:30:56 -04:00
Paul Licameli
b7e1cc09a5 TrackPanel, AdornedRulerPanel each define subdivision in one place...
... excepting the duplication still remaining in TrackPanel::FindTrackRect.

Subdivision of the panel's area is defined recusively using helper classes
that each report a refinement of a sub-rectangle on one of the two axes until
what remains is a rectangle occupied by one cell only.

TrackPanelCellIterator, which iterated over TrackPanel's subdivision by other
means, is replaced by this.

CellularPanel thus requires only one virtual function definition for
subdivision, not two as before, and from that figures out in a generalized way
how to find a cell given a point, or a rectangle given a cell, or an iteration
over all cells within visible bounds.

In future, a rewrite of drawing may invoke virtual functions not only on the
cell objects, but also on the groupings of them.  For instance to draw the
focus rectangle of a stereo track, which surrounds several of the cells -- the
control panel, the channels, and the resizer between.  So it's good to reify
such groupings of cells as objects.
2018-11-01 18:26:11 -04:00
Paul Licameli
39fc20c5ee TrackPanelCellIterator is no longer needed 2018-11-01 18:25:02 -04:00
Paul Licameli
005abb06d6 Replace uses of TrackPanel::Cells() with CellularPanel::VisitCells() 2018-11-01 18:25:02 -04:00
Paul Licameli
01551913f0 nonvirtual reimplementation of CellularPanel::FindRect using nodes 2018-11-01 18:25:02 -04:00
Paul Licameli
cfa7afcb24 nonvirtual reimplementation of CellularPanel::FindCell using nodes 2018-11-01 18:25:02 -04:00
Paul Licameli
128ba93ae7 Implement TrackPanel::Root() 2018-11-01 18:25:01 -04:00
Paul Licameli
08f88ebf2e Implement AdornedRulerPanel::Root() 2018-11-01 17:45:51 -04:00
Paul Licameli
588c050bbb Define visitation procedure skeleton for subdivision of CellularPanel 2018-11-01 17:43:04 -04:00
Paul Licameli
4fe97acbc9 Define CellularPanel::Root 2018-11-01 17:37:22 -04:00
Paul Licameli
30d55f476e Define abstract classes TrackPanelNode and TrackPanelGroup 2018-11-01 17:33:15 -04:00
David Bailes
7549b9f996 Correct mSeekShort to mSeekLong in a few places
Correct typos which were causing incorrect size of cursor movements
2018-10-31 13:43:42 +00:00
Paul Licameli
5b01f57919 Update comments about TrackPanel and TrackArtist...
... Remove mention of obsolete plans for TrackPanel refactor, superseded by a
different refactor now accomplished.

Remove detailed mention of names of functions and data members that implement
drawing.

Move most of Roger's comments about drawing into Overlay.h which is now the
more relevant place.

Commented more correctly what TrackPanelListener is.
2018-10-31 08:06:18 -04:00
Steve Daulton
6e75ff27c8 Bug 2022 Mixer Board does not automatically update
OnTrackSetChanged sets mUpToDate to false, which assumes that
MixerBoard::OnPaint(evt) will be called, but on Linux, the event
appears to be eaten by MixerTrackCluster::OnPaint and TrackClusters
were not updated.
2018-10-31 09:51:34 +00:00
Paul Licameli
912b24f211 Revert "Small widening of the click-to-deselect area below the tracks..."
This reverts commit c101cf3b32ab5023308f2331b5c49df51a492736.
2018-10-30 21:56:22 -04:00
Evropa1
3658032a8d Update ru.po 2018-10-30 18:35:50 +00:00
Paul Licameli
e9d1dfb2dd more const arguments in TrackArtist 2018-10-30 13:42:49 -04:00
Paul Licameli
c101cf3b32 Small widening of the click-to-deselect area below the tracks...
... this should make the division of the TrackPanel area defined in
TrackPanelCellIterator::UpdateRect exhaustive.
2018-10-30 13:03:47 -04:00
Steve Daulton
4f964c359b bug 2017 'offset' was used uninitialised 2018-10-30 15:58:47 +00:00
Paul Licameli
26abe0255d Precautions also in TrackIterRange::StaringWith() as in EndingAfter() 2018-10-30 11:37:08 -04:00
Paul Licameli
74a360f682 Bug2020: Fix sync-lock groupings 2018-10-30 10:54:37 -04:00
Paul Licameli
793949aa29 more comments about TrackIterRange operators 2018-10-30 09:32:29 -04:00
James Crook
cc2c3dc2fc Bug 2016 - Multiple problems with Change Pitch 2018-10-30 12:21:24 +00:00
Paul Licameli
3be57fce49 Bug2015: crash repeatedly append-recording with sync-lock on 2018-10-29 20:35:45 -04:00
Paul Licameli
911840074e Use tab character, not \t in translatable string in .ny file...
... The \t escape is changed to tab by the XLisp reader, but that is not
standard Common Lisp behavior, which would just strip the \ character and leave
t.

xgettext follows standard behavior when making the .pot file, so using \t
caused a mismatch between the catalog and the string actually looked up,
resulting in a translation failure.

There was only one occurence of \t in translatable strings in all of plug-ins.
I left alone the occurrences in non-translatable strings.
2018-10-29 17:23:03 -04:00
Paul Licameli
79cf475c87 Make update_po_files.sh run on macOS...
... BSD version of sed doesn't know -r, but does know -E.

BSD versions of head and tail didn't know --lines= but do know -n.

Also changed the mode to executable and added #! line.
2018-10-29 16:21:37 -04:00
Paul Licameli
9c9bc70e9b Fix sorting of effects below the separator...
... commit 52672ed was a mistake.
2018-10-29 16:21:37 -04:00
Steve Daulton
46a3f91d59 Add some useful path definitions for Nyquist 2018-10-29 20:01:21 +00:00
James Crook
c79d65cdeb Bug 2019 - Scriptables: Set Envelope allows envelope points at zero which can cause NaNs 2018-10-29 19:59:29 +00:00