Additionally, fix the UI portions of these, and fix Trim for note tracks
(the code already existed, but due to flags would not work). As PRL
requested, this is gated only behind USE_MIDI.
The fix was regarded as a workaround, and too draconian. The problem is that Left and Right shortcuts are being captured (somehow) by our CommandManager when navigating in docked toolbars. A full and proper fix rather than not binding these shortcuts would apply them to the toolbar in preference to the CommandManager, and so fix bug 1637, which Bug 1639 has now been marked as a duplicate of.
Previously, these two commands used the clips in the focused track. They now have similar to the Tracks->Pan->Left/Right/Center commands. That is if any audio tracks are selected, the clips in these tracks are used, otherwise the clips in all audio tracks are used.
This update affects the four commands:
Cursor to Previous clip boundary
Cursor to Next clip boundary
Select previous clip boundary to cursor
Select cursor to next clip boundary
Previously these commands all used the clips in the focused track. This update changes this so that their behaviour is the same as the Tracks->Pan->Left/Right/Center commands. That is, if any audio tracks are selected, all the clips in these tracks are used, else the clips in all audio tracks are used.
I've bound the commands that use Left and Right keys to use Ctrl-Left and Ctrl-Right instead. I did not find a simple fix that allowed docked toolbars to get 'furst dibs' and take left and right keys if they wanted them.
Now they are in the order they appear in the default interface and manual rather than alphabetic.
Also removed combined-meter option. Upgraders will potentially continue to have it, until they select one of the single meters. The die hards could also edit audacity.cfg if they really really want it enough.
Also added some comment lines in the ext menus to clarify structure.
Rearranged both View->Toolbars and Ext-Bar->
Enabling/disabling of ext menu items may not yet be exactly what we want, e.g. enabling cursor commands depends on tracks, but enabling selection commands does not. Not fixed, as it is not clear exactly what we want.
These commands all assumed they would be activated from a key press, and so take the key up/down state into account. This is not now the case, and there is no wxEvent to pass to them if they came via a menu item.
The new preference is in the view menu and on the Gui preferences page.
Also Ext Menus rearranged to more closely match default toolbar order.
Also F11 (a new menu command to show/hide maximised) now has a check mark.
This change needs testing on mac as mac is pickier about when menus are updated.
Even though it is a built-in Audacity effect, it is more logical in plug-ins, because the actual effect that will be run when the effect is applied is a plug-in. Makes the list of effects (sorted by type) more logical.
Problem: Mute/Unmute All Tracks in "None" Solo Button Mode does not change track audibility, only changes button state.
Fix: same fix for "none" as for "simple" in commit c8f58c9.
Please Note:
In ViewInfo.h there is the comment left by Paul:
// There is NO GetZoom()!
// Use TimeToPosition and PositionToTime and OffsetTimeByPixels!
I needed to get the value of the current zoom so that I could use the functions AudacityProject::ZoomInByFactor and AudacityProject::ZoomOutByFactor to handle the change in zoom when a preset zoom is chosen. So I added GetZoom() for this use.
If the solo buttons are set to "simple" then after mute/unmute all, the solo buttons should all be off. This is not the case.
Fix: turn the solo buttons off :).
Clip Left
Clip Right
If the cursor lies within a clip, the clip and the cursor is moved 1 pixel left/right.
If the cursor position is at both a clip end and a clip start, the second of these clips is moved.
The movement currently ignores the snap to setting on the selection bar, and there is no snapping to the clip boundaries of other clips.
Following the behaviour or shifting with the mouse, the distance moved is rounded to an integral number of samples, and the minimum distance moved is one sample.
Added two commands:
Select > Previous clip. Select the previous clip for which clip start < selection start/cursor position.
Select > Next clip. If the position of selection start/cursor is at the start of a clip, and selection end is not at the end of the clip, select that clip. Otherwise, select the next clip for which clip start > selection start/cursor position.
Added the commands:
Cursor to > Previous clip boundary
Cursor to > Next clip boundary
Select > Previous clip boundary to cursor
Select > Cursor to next clip boundary
This commit adds note tracks into the mixerboard. It's done as a separate
slider this time instead of via subclasses (as PRL requested), so which
should be easier to use.
This also changes some of the gaurds to EXPERIMENTAL_MIDI_OUT from
USE_MIDI, as it's meaningless to have the note track code in mixerboard
when it cannot do anything (depends on methods that exist behind
EXPERIMENTAL_MIDI_OUT).
... The return codes were mostly ignored anyway, and exceptions will be thrown
instead.
It seems there was also confusion whether the return values of Track::Paste
and Track::SyncLockAdjust were to indicate success or indicate whether there
was any change. No matter now.
No ellipses in title bar of file open/import dialogs
Auto Recovery Discard dialogs say only recoverable projects are discarded
Capitalised button in Dependency dialogue per MS guidelines.
Group "cursor to project start / end" with other "Cursor to" commands.
Move remaining two "Skip to" commands to View menu (subject to change).
Access keys to be decided.
