Paul Licameli
852c07bc58
Eliminate GetActiveProject from WaveTrack.cpp
2020-01-07 16:16:18 -05:00
Paul Licameli
aa39f9ade2
Rewrite FileNames::SelectFile using FileTypes...
...
... And more uniformity in the descriptions of file types used in more than
one place
Also fixes missing translations in VSTEffect.cpp
2019-12-29 15:35:04 -05:00
Paul Licameli
8c4bc6c91f
Make some more text windows read-only
2019-12-28 19:43:36 -05:00
Paul Licameli
ced6221b57
Rewrite format of output in Benchmark.cpp...
...
... Note that %ld must replace %d in many formats to keep it working, because
wxWidgets does more type-checking inside TranslatableString::Translation(),
because we now capture arguments with type-smart modern C++ variadic templates,
rather than using the old C variadics.
2019-12-26 22:11:44 -05:00
Paul Licameli
747c35645a
TranslatableString for checkbox captions
2019-12-23 19:15:34 -05:00
Paul Licameli
5168d62e3d
TranslatableString for captions of text entry boxes
2019-12-23 18:53:00 -05:00
Paul Licameli
1944ac2040
TranslatableString for labels of ShuttleGui buttons
2019-12-23 15:35:48 -05:00
Paul Licameli
dc39f22442
AudacityMessageBox takes TranslatableString message and caption
2019-12-20 21:32:50 -05:00
Paul Licameli
ae42397d64
FileNames::SelectFile takes TranslatableString for message
2019-12-20 13:40:20 -05:00
Paul Licameli
53ee9c9800
TranslatableString for titles, names, labels of wxDialogWrappers...
...
... Found one missed translation in CommandTargets.cpp
2019-12-16 10:58:05 -05:00
Paul Licameli
b5ee7676fd
Rename ShuttleGui::SetSizeHints, chain-call it like other methods...
...
... And rewrite some other existing calls to SetMinSize
2019-12-02 19:35:06 -05:00
Paul Licameli
9eeef4713d
Define and use ShuttleGui::Name and NameSuffix...
...
... For radio buttons, the name will default to the same as the prompt if not
otherwise specified
2019-12-02 16:55:46 -05:00
Paul Licameli
1d32824e02
Define and use ShuttleGui::Validator
2019-12-02 11:21:40 -05:00
Paul Licameli
bca0afd52e
ShuttleGui lets you specify whether a button is default. Use that.
2019-11-28 14:24:43 -05:00
Paul Licameli
b25d3ad344
Limit access to global array of open projects & simplify iterations
2019-05-30 01:55:25 -04:00
Paul Licameli
b5a57682b6
static ViewInfo::Get() and ZoomInfo::Get()...
...
... not member functions of AudacityProject
2019-05-23 12:58:47 -04:00
Paul Licameli
f86403378b
Move AudacityMessageBox to its own files...
...
... breaking cycles among low-level files introduced by 273ba9f
2019-05-20 14:48:36 -04:00
Paul Licameli
9b32fc7a2b
DirManager.cpp doesn't depend on Clipboard...
...
... Locate other outstanding DirManagers by other means, a global tracking
array.
This does not yet break any dependency cycles.
2019-05-18 20:32:19 -04:00
Paul Licameli
7766d9a192
AddCheckBox takes a bool for initial state, not string
2019-03-27 12:58:40 -04:00
Paul Licameli
b4ce681867
WaveTrack.h does not include WaveClip.h
2019-03-18 01:44:42 -04:00
Paul Licameli
1bcb7c20a5
Remove some nested #include from Project.h
2019-03-16 13:09:54 -04:00
Paul Licameli
50074f2cfe
Replace comparisons against "" with empty()
2019-03-14 13:23:41 -04:00
Paul Licameli
c68e336247
More use of std:: style members of wxString...
...
... replacing:
Length => length
Len => length
2019-03-10 14:44:54 -04:00
Paul Licameli
2db49dc1f0
Use standard library style members of wxArrayString (and wxString) ...
...
... which will make it easier to change the types of those containers to
std::vectors of other string-like classes
for wxString,
IsEmpty => empty
Clear => clear
Alloc => reserve
for wxArrayString,
Count => size
GetCount => size
IsEmpty => empty
Add => push_back
Clear => clear
Empty => clear
Sort => std::sort (only with default comparator)
SetCount => resize
Last => back
Item => operator []
Alloc => reserve
2019-03-10 14:43:57 -04:00
Paul Licameli
ccb4bbac33
Translate "Message" as default title of message box...
...
... This required a sweeping change of all calls to wxMessageBox! But it seems
safe to me, despite the great number of touched files.
2018-01-01 17:50:02 -05:00
Paul Licameli
ec5f9d6b66
Translation of strings in Benchmark
2017-09-10 19:24:42 -04:00
Paul Licameli
5d48e96942
Where FileSelector was used, default to Documents not cwd; save prefs
2017-08-03 08:02:33 -04:00
Paul Licameli
2ba6065961
Sequence consistency check throws; new unused commit functions use it
2017-04-02 21:33:22 -04:00
Paul Licameli
e1473dfe76
void return, not boolean success, from some Track virtual functions...
...
... The return codes were mostly ignored anyway, and exceptions will be thrown
instead.
It seems there was also confusion whether the return values of Track::Paste
and Track::SyncLockAdjust were to indicate success or indicate whether there
was any change. No matter now.
2017-03-31 18:26:52 -04:00
Paul Licameli
6b84dc1c1d
Factory methods will return non-NULL or throw
2017-03-31 18:14:29 -04:00
Paul Licameli
d1cbac4181
more finally, more const, remove unused, fix warnings
2017-03-31 17:47:18 -04:00
Paul Licameli
ce2e154e89
Remove naked new[] in: Benchmark
2017-03-17 17:52:47 -04:00
Paul Licameli
40651241d9
Benchmark::OnRun: clarify, simplify, avoid possible divide by 0
2017-03-17 17:52:34 -04:00
Paul Licameli
5036583549
Fewer inclusions of AudacityApp.h
2017-03-17 17:52:24 -04:00
Paul Licameli
78be459fa1
Convert sampleCount <-> floating or -> long long explicitly ...
...
... A non-narrowing conversion out to long long is a necessity, but the
conversions to float and double are simply conveniences.
Conversion from floating is explicit, to avoid unintended consequences with
arithmetic operators, when later sampleCount ceases to be an alias for an
integral type.
Some conversions are not made explicit, where I expect to change the type of
the variable later to have mere size_t width.
2016-09-15 21:02:31 -04:00
Paul Licameli
96242ef2df
Undo a global effect with RAII
2016-09-06 12:39:57 -04:00
Paul Licameli
86b633bab2
Remove more unnecessary casts to sampleCount
2016-08-26 12:42:22 -04:00
Paul Licameli
fd2b050d6f
Type agnosticism for some other variables that were not sampleCount...
...
... in some cases, this fixes narrowings.
2016-08-24 14:50:45 -04:00
Paul Licameli
46f38708ed
Dir manager uses std::shared_ptr
2016-08-13 12:23:05 -04:00
Paul Licameli
84c0337aba
Fix TAB key navigation on Mac for all dialogs (not only for panels)
2016-07-10 17:12:27 -04:00
Paul Licameli
3015a9c8d9
Track cut and copy functions return a unique_ptr argument...
...
... Because they are factory functions.
2016-03-26 11:50:13 -04:00
Paul Licameli
5ef4dd46a5
TrackFactory functions return std::unique_ptr, although some callers...
...
... release() them for now.
2016-03-26 11:50:12 -04:00
Paul Licameli
7824e94030
Harmlessly qualify classes as final (or explicitly comment not)...
...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls. Mostly useful as documentation of design intent.
Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
dbaa811577
Stack-allocate where possible! ...
...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
17c9369286
Bug1239: Correct time rulers after importing files (with File>Open) ...
...
... The fisheye stuff was to blame.
2016-01-26 18:09:29 -05:00
Leland Lucius
1e195ecea6
Fix many wx3.1.0 assertions now to prevent double testing
2015-07-30 02:05:23 -05:00
Leland Lucius
3fe146f306
Merge remote-tracking branch 'upstream/master' into wx3
2015-07-19 18:00:02 -05:00
Paul Licameli
e70f91c64e
Removed ShuttleGui.h from other headers
2015-07-19 12:31:03 -04:00
Leland Lucius
9b9c8cc073
Round 5 of wx3 changes
...
FileDialog now complete on Linux. Needs some fine tuning on
Windows and OSX.
Builds with wx3 and gtk2 or gtk3.
Still more effect work to do.
2015-07-14 23:33:53 -05:00
David Bailes
f458df1c7b
Changes to a number of dialogs so that the NVDA screen reader can read the titles. Missed these in my last patch. The accessibility name of the dialog is set to the title.
2015-05-18 13:57:05 +01:00