Paul Licameli
473e955da3
Remove some naked new amd delete in: ondemand
2016-08-08 07:53:28 -04:00
Paul Licameli
fd2e36e0c8
Remove some naked new amd delete in: FFmpeg
2016-08-08 07:51:24 -04:00
Paul Licameli
8392a57d34
Fix crash bug on on-demand ffmpeg decoding (an experimental)
2016-08-06 09:56:20 -04:00
Paul Licameli
24df87bb4c
Fix resource leaks in the usage of the FFMPEG library with RAII objects...
...
... This includes failure paths in the initialization if import. Those
resources would have been reclaimed before program exit, but not as soon as
they should have been.
... This also includes certain leaks that would happen every time a file is
successfully imported or exported. We never used avformat_free_context or
av_dict_free as we should have!
... There were also AVPacket objects repeatedly reinitialized without proper
cleanups in between. That might have leaked memory too.
2016-04-13 20:31:54 -04:00
Paul Licameli
7c0073dd77
Unreported bug: memory and file handle leak when importing custom mpeg...
...
I could see this on windows:
Import a file such as .aiff format, while "Files of type:"
reads "FFmpeg-compatible files".
Leave Audacity running.
Attempt to delete the file in Windows Exploerer.
Get a message from Windows that the file is in use by Audacity and cannot be
deleted.
2016-04-09 00:21:38 -04:00
Paul Licameli
c9d50dc20b
ODTask cloners return smart pointers
2016-04-06 16:06:36 -04:00
Paul Licameli
539eb0edf6
Fix "memory leak" of decoder objects... though it wasn't really reachable...
...
... except with some EXPERIMENTAL flags turned on
2016-04-02 00:40:19 -04:00
Paul Licameli
cbd561be7d
Make EXPERIMENTAL_OD_FFMPEG compilable, and change some memory management
2016-04-02 00:02:52 -04:00
Paul Licameli
990080ae7d
Replace virtual with override wherever possible; eliminate needless virtual...
...
... for functions in final classes.
override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.
There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030
Harmlessly qualify classes as final (or explicitly comment not)...
...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls. Mostly useful as documentation of design intent.
Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
7c4c45a0d5
"new"->"NEW" in comments, easier to find remaining naked operator new
2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343
"delete"->"DELETE" in comments, easier to find remaining naked operator delete
2016-02-14 18:50:45 -05:00
Paul Licameli
321d5259a2
More uses of SampleBuffer, eliminating explicit DeleteSamples calls
2016-02-01 10:16:00 -05:00
Daniel Winzen
92d522132e
Variable cleanup
2015-04-23 18:30:38 +02:00
benjamin.drung@gmail.com
149fcafc1c
Replace tabs by spaces.
2014-06-05 22:04:22 +00:00
benjamin.drung@gmail.com
277932dccb
Remove trailing spaces.
2014-06-03 20:30:19 +00:00
benjamin.drung@gmail.com
4d4580a042
FFmpeg: Replace long deprecated functions by current ones.
2014-05-31 14:01:57 +00:00
benjamin.drung@gmail.com
33b9e9336f
FFmpeg: Replace deprecated av_close_input_file by avformat_close_input.
2014-05-29 15:50:47 +00:00
benjamin.drung@gmail.com
0a1999130d
Drop compatibility for libav/FFmpeg < 0.7.
2014-05-25 21:08:58 +00:00
RichardAsh1981@gmail.com
fc0cb41356
fix the build of on-demand ffmpeg, disable the preference if FFmpeg support is not compiled in. Patch by Michael Chinen. This feature is currently off in experimental.h.
2013-05-25 15:36:04 +00:00
richardash1981
393129d9b9
fix the line endings on this file, and set svn:eol-style to native so they stay fixed
2013-01-01 15:54:53 +00:00
v.audacity
24af4febea
Bug 539 (P2) - Audacity does not build if configured --without-ffmpeg
...
Revert to quick fix of r 11867. Steve reports Debian build error with r11868. Left that code in, because this should override it.
2012-07-25 06:20:17 +00:00
v.audacity
d90e6c5285
Bug 539 (P2) - Audacity does not build if configured --without-ffmpeg
...
more pinpointed fix that should close this
2012-07-25 02:00:48 +00:00
v.audacity
15f9695d18
Fix a compiler warning.
2012-07-16 23:46:20 +00:00
v.audacity
87610cea39
Benjamin Drung's disable-dynamic-lame.patch for http://bugzilla.audacityteam.org/show_bug.cgi?id=233
2012-06-25 01:41:57 +00:00
mchinen
b8f19b58d9
OD FFmpeg: disable seeking (caused issues on windows)
2012-06-17 13:33:13 +00:00
mchinen
a09fe983ed
remove debug printfs
2012-06-01 06:11:54 +00:00
mchinen
c4f1a52413
OD FFmpeg: fix a bug with demand seeking by using a safer seek test
2012-06-01 06:11:49 +00:00
mchinen
1fb7a1dcee
OD FFmpeg: do not attempt to correct stream lag unless a seek was demanded by user
2012-06-01 06:11:45 +00:00
mchinen
2aedaaa68d
lazy evaluate for OD ffmpeg seek test
2012-06-01 06:11:41 +00:00
mchinen
77917b3268
change flushing case for OD ffmpeg
2012-06-01 06:11:36 +00:00
mchinen
e5520d0b7d
fix case where DecodeFrame() was not returning errors
2012-06-01 06:11:31 +00:00
mchinen
f837c1fefd
fix indentation
2012-06-01 06:11:26 +00:00
mchinen
80a2b68bcf
Fix warnings for OD ffmpeg
2012-06-01 06:11:21 +00:00
mchinen
816b58bc08
integrate OD FFmpeg to work with multiple formats, including wav
...
also move streamContext to ffmpeg.h to allow for refactoring of import code
2012-06-01 06:11:07 +00:00
mchinen
8cb2a38fbe
restore build for EXPERIMENTAL_OD_FFMPEG
...
EXPERIMENTAL_OD_FFMPEG is still commented out
2012-06-01 06:11:01 +00:00
lllucius
f50be91900
Bug #176 - Support newer versions of FFmpeg.
...
Also includes Benjamin's ffmpeg-configure-v2.patch.
2011-04-02 02:10:50 +00:00
mchinen
5a5957b422
Add seek support to OD-based FFmpeg import.
...
Also some minor refactoring.
This feature works with mp3 right now - may work on other formats, but that will be a seperate commit.
It is not enabled so most of the changes won't even be compiled, and those that do won't be run.
To enable it uncommment the EXPERIMENTAL_ODFFMPEG def in Experimental.h
2010-07-05 14:38:47 +00:00
BusinessmanProgrammerSteve
4cdbbce01f
Add ODDecodeFFmpegTask to Unix makefile, fix some errors and warnings
2010-03-19 21:41:44 +00:00
mchinen
b07f23d6de
added on-demand support for non-seeking loading of FFmpeg files. This feature is not on, controlled by ifdefs via the #define EXPERIMENTAL_OD_FFMPEG in Experimental.h
2010-03-19 14:57:10 +00:00
