Paul Licameli
bd57f6392f
Simplify iterations over cutlines in WaveClip.cpp; stl idioms
2016-08-12 20:53:37 -04:00
Paul Licameli
77a3647922
Simplify iterations over WaveClips in WaveTrack.cpp; stl idioms
2016-08-12 20:53:37 -04:00
Paul Licameli
b548e641ae
Simplify iterations over WaveClips outside of WaveTrack/WaveClip; ...
...
... also add some const qualifiers
2016-08-12 20:53:37 -04:00
Paul Licameli
cb7872f980
use std::vector to hold TrackClip; move ctor and dtor out of line
2016-08-12 20:53:37 -04:00
Paul Licameli
c373f4d859
Merge branch 'master' into deletes
2016-08-12 20:53:04 -04:00
James Crook
2d2cf5911f
Pinned/Unpinned button now affects PlayHead.
...
Bug 1451 comment 6 asks for PlayHead to change too with the change in the button icon on up/down, making the action of the button clearer.
This change does not though change the icon on the button to red when recording. It stays green, though the PlayHead does change correctly.
2016-08-12 17:32:30 +01:00
James Crook
c2eda38ee1
Bug 1455 - Windows/Linux: Scrub Bar button background colour darker than Timeline/other toolbar buttons
...
Background, over the part that shows the number '1.0' is now transparent.
2016-08-12 13:49:02 +01:00
James Crook
53bb478600
Bug 1457 - Transport Menu "Scrub" and "Seek" do not correctly indicate when either Scrubbing mode is active
2016-08-11 22:30:51 +01:00
James Crook
35c033d3fa
Bug 1451 - On Mac the background of the Pinned/Unpinned button is not the same color as the Timeline
...
Per comments in the bug, fixed by making the pinned/unpinned button more clearly a button.
This involved adding a new type of grabber that does not have the ribs for dragging it and acts as a spacer.
Also fixing grabber so that it does not have to be at position (0,0)
Also making the ruler 1 pixel higher.
Also changing the pin button to be a toggle button that changes from up to down on a click.
Also fixing AButton so that an image can be bigger than the button.
2016-08-11 21:54:45 +01:00
James Crook
eebe4a961e
Bug 1419 - Confusing and unnecessary widget change when clicking in Scrub Bar
...
Behaviour now is still (in my view) confusing, but the widget does update when you click and release and haven't moved yet, which it didn't do before.
2016-08-11 17:59:41 +01:00
Gale Andrews
f7a85f4d52
Fix typo in label
2016-08-11 17:12:00 +01:00
Paul Licameli
9c0ac0aaa4
NEW SOURCE FILE: Remove naked news and deletes in directory import
...
New source file is only a header however.
2016-08-11 11:52:42 -04:00
Paul Licameli
eef2669abd
One less indirection accessing containers in Importer
2016-08-11 11:51:33 -04:00
Paul Licameli
8226441210
use vector of smart pointers to ExtImportItem objects
2016-08-11 11:51:33 -04:00
Paul Licameli
28f0b11376
Use arrays of smart pointers to import plugins
2016-08-11 11:51:33 -04:00
Paul Licameli
7d89e5ff68
Pass containers by ref to import plugin factories, use STL idiom
2016-08-11 11:51:33 -04:00
Paul Licameli
924df495ff
Make headers in import directory self-contained
2016-08-11 11:51:33 -04:00
Paul Licameli
256a595d0f
Use const
2016-08-11 11:51:33 -04:00
Paul Licameli
1d08c793ed
Merge branch 'master' into deletes
2016-08-11 11:51:10 -04:00
James Crook
a90f32e60d
Bug 1456 - Scrub Bar tooltip is incorrect on mouse down because there is no separate tooltip for that state
2016-08-10 22:21:21 +01:00
James Crook
5939fe66e8
Bug 1053 - [Scrub Phase I] Status Bar messages incomplete for scrub started with menu or shortcut.
2016-08-10 21:57:29 +01:00
James Crook
48ad701e57
Bug 1421 - When Scrubbing the Play button in the Transport Toolbar should not change its icon
2016-08-10 21:04:46 +01:00
Steve Daulton
75f1f30fcb
Add track scrolling shortcut to mouse preferences
2016-08-10 19:56:16 +01:00
James Crook
2a93e451b6
Bug 1458 - Scrubbing Toolbar buttons do not update to show the action they will perform
2016-08-10 19:36:09 +01:00
James Crook
e96edb8f26
Bug 1457 - Transport Menu "Scrub" and "Seek" do not correctly indicate when either Scrubbing mode is active
2016-08-10 19:17:40 +01:00
James Crook
8dd93ef2a8
Bug 1467 - New pref for pinned head should move to the Prefs>Tracks
...
Also updated the wording as per comment #2 in Bug 1467.
2016-08-10 18:38:37 +01:00
James Crook
8089bd484a
(Cosmetic) added 'final' to class definition.
...
Putting the word 'final' is a bit like adding a comment that nothing is derived from this effect.
2016-08-10 18:25:07 +01:00
Paul Licameli
062e50eca6
Remove various scalar naked news and deletes
2016-08-10 11:06:07 -04:00
Paul Licameli
14c23803ac
Various uses of make_unique
2016-08-10 11:05:52 -04:00
Paul Licameli
11305b956f
Use make_unique for wxMenu objects
2016-08-10 11:05:52 -04:00
Paul Licameli
4045d96a58
Fix a memory leak I introduced in Truncate Silence ... sorry
2016-08-10 11:05:52 -04:00
Paul Licameli
7c1511c604
Fix memory leak in global print settings
2016-08-10 11:05:52 -04:00
Paul Licameli
6e4e710d3b
Remove seeming naked new and deletes in comments and uncompiled code
2016-08-10 11:05:51 -04:00
Paul Licameli
8572b425c1
More safenew
2016-08-10 11:05:51 -04:00
Paul Licameli
c438925a22
Use Destroy_ptr for the toolbars
2016-08-10 11:05:51 -04:00
Paul Licameli
fec4069d9d
Some uses of Destroy_ptr let us remove some naked news
2016-08-10 11:05:51 -04:00
Paul Licameli
aaeaadff07
Define Destroy_ptr
2016-08-10 11:05:51 -04:00
Paul Licameli
384fc4a4ae
Prefer Destroy() to deleting a window
2016-08-10 11:05:50 -04:00
Paul Licameli
a27d0aca2b
Merge branch 'master' into deletes
2016-08-10 11:05:04 -04:00
Paul Licameli
9cc4eaadf8
Define swap for std::unique_ptr
2016-08-09 21:56:23 -04:00
Steve Daulton
586074bab8
Add missing hyphen
2016-08-09 18:56:37 +01:00
Gale Andrews
8cb8e59046
Remove line breaks now help window is smaller
2016-08-09 17:55:03 +01:00
Steve Daulton
256a8aaedd
Consistent vert/horizontal waveform zoom/scroll
...
Shift+Wheel -> scroll
Ctrl+Wheel -> zoom
Ctrl+Shift+Wheel -> Waveform dB end range adjust (when visible).
2016-08-09 17:01:05 +01:00
Steve Daulton
6089c94971
Fix bug 1473
...
Disallow scrub / seek during record.
2016-08-09 14:10:04 +01:00
Paul Licameli
6b9d69f3f8
Remove more naked news by editing comments, safenew and make_unique
2016-08-08 10:08:38 -04:00
Paul Licameli
15004b1ade
More uses of std::make_unique
2016-08-08 10:07:37 -04:00
Paul Licameli
13e056de43
More uses of safenew
2016-08-08 10:07:37 -04:00
Paul Licameli
a52f7f8410
new -> NEW in comments, so text search for naked new excludes them
2016-08-08 10:07:37 -04:00
Gale Andrews
6a4c74f592
Fix incorrect Wiki link
2016-08-08 14:48:53 +01:00
Paul Licameli
07ff4d3d02
Remove many naked (scalar) news and deletes with smart pointers
2016-08-08 07:54:10 -04:00
