1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-07 23:32:53 +02:00

672 Commits

Author SHA1 Message Date
Paul Licameli
65c7beff99 Move mAdjustSelectionEdges from TrackPanel to ViewInfo 2017-06-08 15:30:52 -04:00
Paul Licameli
c300c33901 Remove a few unused members from class TrackPanel, and an unused #include 2017-06-08 15:30:31 -04:00
Paul Licameli
a33ec61ddf Move code for toggling spectral selection (Q key) out of TrackPanel 2017-06-08 12:48:28 -04:00
Paul Licameli
a4f0a8c39a Remove some unused members 2017-06-08 12:48:28 -04:00
Paul Licameli
3255ab6c5b Remove some unused members 2017-06-07 21:57:42 -04:00
windinthew
cb039c200a Wiki wording changes
a) 'Ends to Zero Crossings' to 'At Zero Crossings' and move from Region submenu to
root because this is not only a region command and to aid finding and easy access

b) Draw Tool error message recognises again that the tool works in Waveform (dB)
2017-06-08 01:57:30 +01:00
Paul Licameli
05f1a03cb4 Do not HandleInterruptedDrag for ESC key, it would be redundant 2017-06-07 12:22:29 -04:00
Paul Licameli
7bf7815c75 Move HideTopItem into class TrackInfo, for later use 2017-06-07 10:39:47 -04:00
Paul Licameli
acce480a76 Mac: shift WaveTrack status text down one more; others: don't shift 2017-06-07 00:07:03 -04:00
Paul Licameli
84b5fd6075 Compute default WaveTrack height analogously to NoteTrack...
... though in fact this comes to the same 150 pixels as before, given the
present layout table.
2017-06-06 22:39:30 -04:00
Paul Licameli
f0c149b890 Default MIDI track height is enough to display velocity slider...
... It is computed from the layout table, and in fact comes to 158 pixels,
versus 150 for other tracks.
2017-06-06 22:39:30 -04:00
Paul Licameli
0204cd80c5 Make gain slider again visible in default sized WaveTrack 2017-06-06 22:39:30 -04:00
Paul Licameli
8d517bd3bd EXPERIMENTAL_MIDI_OUT off -- then no invisible channel buttons...
... They were still clickable before this commit.
2017-06-06 21:49:39 -04:00
Paul Licameli
191eeaf19e Rewrite drawing routines equivalently without kTrackInfoWidth...
... using rect.width instead; and making no changes in appearance.

Some routines, like that for the sync lock icon, are pleasingly simplified.

But see comments about some questionable things that may have been based
on the misunderstanding that kTrackInfoWidth was the width between bounding
lines, when in fact, that width was 5 less.
2017-06-06 18:28:35 -04:00
Paul Licameli
64a0d788a5 Rewrite the unused DrawBordersWithin...
... Remembering inclusivity of the endpoints in AColor::Line, and avoiding
use of the constant kTrackInfoWidth
2017-06-06 15:44:26 -04:00
Paul Licameli
ad4d6d148a Fix unintended one-pixel change in width of title button 2017-06-06 14:16:50 -04:00
Paul Licameli
ceaa050a24 Change some names in TrackArtist to match terminology in TrackPanel 2017-06-06 13:29:33 -04:00
Paul Licameli
24858dcb90 Exclude left, top, bottom margins from rectangles describing TCP 2017-06-06 13:29:28 -04:00
Paul Licameli
3567f99e06 Exclude bottom margin from vruler rectangle reported from FindCell...
... Fixes a small discrepancy between drawing and interpretation of mouse
drag events
2017-06-06 13:27:56 -04:00
Paul Licameli
02ee10d98d Fix a confusion in argument names. No change in behavior 2017-06-06 13:17:53 -04:00
Paul Licameli
75bf6f90e4 Explanatory comments in TrackPanel drawing; fewer magic numbers 2017-06-06 13:17:51 -04:00
Paul Licameli
63c89e1fe3 Simplify logic of track control panel click to rearrange...
... Rearrange drag is now simply the default of all other hit tests.

The comment, as to the purpose of the removed call to TrackSelFunc, is
obsolete, because clicks on hidden buttons and sliders have recently been
disabled.

The mention of "the area left of the minimize button" is obsolete because there
is no such area any more after 2.2.0 layout changes.

Just before this commit, click in the minimize button but near the left edge
did not minimize, but started a track rearrange drag!  That should not be so.
2017-06-05 22:18:24 -04:00
Paul Licameli
62cccba16d Shift TCP status text down two pixels, leaving other controls unmoved 2017-06-05 21:42:47 -04:00
Paul Licameli
52017948d1 Remove argument of DrawOutside that is no longer used...
... This only was a source of confusions.
2017-06-05 21:42:47 -04:00
Paul Licameli
31fcfe743d Don't overlap WaveTrack status and title bar by one pixel...
...Placement of status text lines in TCP is also table-driven
2017-06-05 21:42:37 -04:00
Paul Licameli
4244d55b77 Fix NoteTrack stray lines; no magic numbers in DrawBordersWithin...
... even though we are now skipping that drawing step.
2017-06-05 21:42:36 -04:00
Paul Licameli
895102bf9a Hidden buttons and sliders in narrow tracks are never clickable 2017-06-05 21:39:34 -04:00
Paul Licameli
5520abaa81 Placement of minimize button and sync-lock icon are also table driven 2017-06-05 21:39:13 -04:00
Paul Licameli
672f47d4da Don't overlap MIDI channel buttons with menu button & slider...
... and placement of them, and of velocity slider, is also by table
2017-06-05 21:35:41 -04:00
Paul Licameli
b8492d02d6 CalcItemY is table-driven; stack Mute & Solo for NoteTrack too in DA 2017-06-05 21:35:39 -04:00
Paul Licameli
71b63843a7 some const 2017-06-04 14:04:14 -04:00
Paul Licameli
c38efc1fcd FindTrackRect omits all margins; better screen reader focus rects...
... Formerly it was outside of the yellow focus at the right side.  Now it
follows the yellow consistently on four sides.

The constant dx in TrackPanelAx::GetLocation might be adjusted.

No change of behavior is intended at other uses of FindTrackRect
2017-06-04 11:31:46 -04:00
Paul Licameli
7f079262e2 Rectangle reported for vertical ruler cell omits top inset and border 2017-06-04 09:06:37 -04:00
Paul Licameli
afd3b0ba19 Remove some uses of Track::GetHeight()...
Pass top-left point, not a rectangle, to places that did not use width or
height.
2017-06-04 08:29:32 -04:00
Paul Licameli
5395f253bf Reviewed use of Track::GetY; don't use in NoteTrack; fix off-by-1's 2017-06-04 00:15:29 -04:00
Paul Licameli
beab669f42 Update mixer board for name change of MIDI track...
... as well as for WaveTrack, if EXPERIMENTAL_MIDI_OUT
2017-06-02 18:35:29 -04:00
Paul Licameli
f807f7fd6d Removed a disabled piece of track list selection...
... that interferes with track panel refactor
2017-06-01 12:06:28 -04:00
Paul Licameli
8da228748b Delete this start of time shift on double-click (it never completed) 2017-06-01 11:55:10 -04:00
Paul Licameli
537ccfbc4f Change evaluation of envelope near discontinuities...
... So that even if the time is "slightly" (less than 1/2 sample interval) left
of the discontinuity, the right-hand limit is always used.

Thus this compensates for some roundoff errors when pasting one clip with
an envelope into another.

This overcomes the objections that were in a comment in Envelope::Paste
to making control points with exactly equal times.

And therefore Paste can be rewritten to do so, but that has not happened yet.

Envelope points at exactly equal time coordinates can already be made by
dragging points in the envelope editor.
2017-05-26 14:50:43 -04:00
Paul Licameli
646c66f78f Sync lock adjustment for NoteTrack stretch...
... It applies only at button-up, not in a previewing fashion during the drag.

Realizing that preview is more work than I want to do right now.
2017-05-22 23:25:39 -04:00
Paul Licameli
54636c65fa Allow NoteTrack to stretch left of zero 2017-05-22 23:16:44 -04:00
Paul Licameli
82ce041c75 Preview cursor for Stretch can take left, right, or center form 2017-05-22 23:16:42 -04:00
Paul Licameli
90eb4ec142 Make MIDI track stretch path-independent 2017-05-22 23:15:26 -04:00
Paul Licameli
9fb7185ea4 Rewrite undo handling for Stretch to be more like other drags...
... that is, push a state only at button-up.

The undo during each drag increment didn't actually happen, because of a check
in OnUndo whether there is a drag in progress!

But this is not necessary to fix the excessive number of undo items, because
commit 63ae687bafd1123bf4bf7d00070e1dd9f38dc8a2 already did that by other means.

It only removes an unusual usage.
2017-05-22 23:12:36 -04:00
Paul Licameli
2eb6285ddc Group some TrackPanel fields into a structure 2017-05-22 23:12:35 -04:00
David Bailes
f9827a57a7 Minor fix for commands for shifting clips using the keyboard.
Fix for minor bug introduced in commit 9da999d. The selection wasn't being updated by the actual slide amount.
2017-05-20 11:26:59 +01:00
Paul Licameli
01f853f174 Fix Windows build 2017-05-18 19:01:46 -04:00
James Crook
a6310d770d Fix Travis build
Add return 0.0
This does not fix the windows build, which is complaining about deleted functions.
2017-05-18 21:34:46 +01:00
Paul Licameli
f7578193b4 TrackPanel::OnClipMove is a static function 2017-05-18 07:46:54 -04:00
Paul Licameli
227850f9cd Group some member variables into ClipMoveState 2017-05-18 07:45:04 -04:00