Thanks to Walter Gladwin.
The comment said "Is this correct??" the answer is no. However the problem only showed when other fixes were made elsewhere, and Add Label at Playback Positions then stopped working when in Pause.
I first of all added a warning message if trying to configure while playing.
Then decided that it is more in keeping with current style to grey out the Spectrogram Settings menu item.
So the new warning message should actually never be reached.
Comment more cases of bad sampleCount truncation, and even worse...
Fix progress indicator again: must do a floating-point division...
A little more type agnosticism
Remove more unnecessary casts to sampleCount
Fix more narrowings of sampleCount
Caused by optimisation of NumericTextCtrl::ValueToControls(). It now only updates on a change, and because mValueStr was being updated without calling value to controls, the string was not being identified as having changed.
* sampleCount:
Remove unnecessary casts to sampleCount
Type agnosticism for some other variables that were not sampleCount...
Remove many mentions of sampleCount with auto and decltype...
Use sf_count_t not sampleCount
some uses of size_t
Use long long for argument passed to wxString::ToLongLong
More cautions in SBSMSEffect.cpp...
... This makes much code agnostic about how other things (functions and
arguments) are typed.
Many of these neeed to become size_t instead of sampleCount.
These changes fix a broken build in Windows.
#include <algorithm> needed for min/max to be in std.
decltype(+name) was declaring a const variable, that could not be incremented. Changed to auto.
Uniform init in blockfile ctors (prevents implicit narrowings)
spaces
change a variable name
Don't use conversion of sampleCount to bool
Add explicit cast to sampleCount where negative values are possible
use std::min and std::max
an assertion
LadspaEffect::mSampleRate has type double, like other plug-in effects
