1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-09-14 07:20:35 +02:00

389 Commits

Author SHA1 Message Date
Paul Licameli
303553ae4e Take class AdornedRulerPanel out of src/widgets...
... It's not a utility widget like RulerPanel.  It has a lot of application
specific logic in it.
2018-10-24 15:04:41 -04:00
Paul Licameli
e048a4aacd Move a static function and an enumeration out of MenuCommandHandler 2018-10-24 12:16:46 -04:00
Paul Licameli
9759c6bd4f Plugin Menus 2018-10-24 12:16:44 -04:00
Paul Licameli
2792faa114 Edit and Label Menus 2018-10-24 12:14:05 -04:00
Paul Licameli
d1e2ec3b0f Remove some uses of MenuCommandHandler outside Menus.cpp...
... where the functions were simple call-throughs to something else
2018-10-24 11:02:32 -04:00
Steve Daulton
388cf47a92
Update SetLabelCommand.cpp
SetLabels: command may put labels out of order, so sort them after.
2018-10-22 17:59:14 +01:00
Paul Licameli
d40dfa2de2 More comments explaining the C++11 exotica 2018-10-21 12:46:41 -04:00
Paul Licameli
e756f2e71c Define classes and interpreter to be used in menu definition tables 2018-10-21 12:16:22 -04:00
Paul Licameli
5277584bb0 Hide details of managing occult command items 2018-10-20 14:19:58 -04:00
Paul Licameli
01875db4bd Don't hold a dangling pointer to a menu bar in CommandManager 2018-10-20 12:53:03 -04:00
Paul Licameli
fefc3bf35d Don't call CommandManger::AddGlobalCommand, use an option instead 2018-10-20 11:59:39 -04:00
Paul Licameli
c9d9871f6c Remove a comment 2018-10-20 11:58:02 -04:00
Paul Licameli
7f5e6d12b1 Only one public CommandManager fn to begin a menu and one to end...
... It knows the nesting, so it decides for itself whether to manage the menu
as main or sub-.
2018-10-20 09:40:03 -04:00
Paul Licameli
83ede10891 Remove unused forward declaration 2018-10-20 09:21:22 -04:00
Paul Licameli
27aa59ed50 AddItemList takes IdentInterfaceSymbol (untranslated) ...
... so that we can use a static constant table of names, which can't use
macro _ in initializers.
2018-10-20 09:21:22 -04:00
Steve Daulton
f09bfbc217 Small change of format for GetInfo Labels
to make parsing a bit easier in LISP
2018-10-18 22:56:02 +01:00
Paul Licameli
16ab48079b Don't include CommandManager.h in other headers 2018-10-18 09:25:14 -04:00
Paul Licameli
fc1bc7994e Remove CommandManager::SetDefaultFlags and related 2018-10-17 23:14:55 -04:00
Paul Licameli
a1bd9062ae Remove dead code; so that all remaining calls to NewIdentifier...
...are followed by a setting of flags and mask
2018-10-17 23:13:56 -04:00
Paul Licameli
63f20f3405 CommandManager::AddItemList requires flags 2018-10-17 23:13:56 -04:00
Paul Licameli
742e578d49 Flags in AddItem (and AddCommand) may not be NoFlagsSpecified 2018-10-17 23:13:56 -04:00
Paul Licameli
db997f8ecd Flags argument of AddItem (and AddCommand) is obligatory 2018-10-17 23:13:56 -04:00
Paul Licameli
596eefe675 CommandManager::Options also specified the long name 2018-10-17 13:49:43 -04:00
Paul Licameli
cfe7ddcf55 struct CommandManager::Options lets us fold AddCheck into AddItem 2018-10-17 13:32:39 -04:00
Paul Licameli
de4132d66c Reorder accel argument and unify two overloads of AddItem 2018-10-17 13:32:36 -04:00
Paul Licameli
c376ffb165 Simplify calls to SetDefaultFlags: default mask to equal flags 2018-10-17 13:21:00 -04:00
Paul Licameli
42aef9f3e8 Mask != flags is unusual: simplify most AddItem/AddCheck...
... and the no longer used AddCommand.

There are only four exceptions, all using NoAutoSelect in the flags and not in
the mask.
2018-10-17 13:20:58 -04:00
Paul Licameli
399e2d099d Fix spelling in an enum constant name 2018-10-17 12:53:25 -04:00
Paul Licameli
88c67c46f3 Unify the two overloads of CommandManager::AddCheck 2018-10-17 12:53:25 -04:00
Paul Licameli
fef9e2abac Remove some unused things 2018-10-17 12:53:25 -04:00
Paul Licameli
ce9f2e2538 Include Menus.h directly, only where needed, not via Project.h 2018-10-16 16:45:26 -04:00
Paul Licameli
fc6570646d MenuCommandHandler is not a base class of MenuManager...
... This forces a better placement of state variables in the appropriate
classes.

In future perhaps, MenuManager should be splintered into several classes, one
for each of the main toolbar menus.
2018-10-16 13:01:22 +01:00
James Crook
51b3076786 Fix include path 2018-10-16 13:01:22 +01:00
Steve Daulton
cb55164c43 Add Project Rate to SetProjectCommand 2018-10-15 23:51:41 +01:00
Paul Licameli
ef97ce88ca Correct more double spaces 2018-10-15 12:54:44 -04:00
Paul Licameli
297f3b4d84 Fix another mistake in iteration over channels in src/commands 2018-10-11 21:40:38 -04:00
James Crook
15a3ea7763 Bug 2010 - Scriptables: SelectTracks and Select incorrect for stereo tracks 2018-10-11 11:29:53 +01:00
James Crook
657159d542 Fix C4189 and C4100 Warnings
C4189 is 'Local variable initialised but not used'
C4100 is 'Unreferenced parameter'

Fixed some other warnings, e.g. about empty if, too.
2018-10-10 19:46:24 +01:00
Paul Licameli
c7ab9f2338 Rewrite many iterations over tracks and channels in src/commands 2018-10-01 11:24:37 -04:00
Paul Licameli
b94e8fec96 Remove VisibleTrackIterator 2018-10-01 11:20:52 -04:00
Paul Licameli
51842fc78b Use TypeSwitch and track_cast 2018-10-01 10:58:47 -04:00
Paul Licameli
7c924012fb A redundant high-level GuardedCall around macro command execution...
... Redundant with the guard already in ApplyAndSendResponse, but this makes it
easier to reason about the exception safety of calls into Audacity from
Nyquist tools.
2018-09-29 12:10:27 -04:00
Paul Licameli
9481587fa8 Move menu handling functions out of class AudacityProject 2018-09-29 12:10:27 -04:00
James Crook
1b6cd725e6 Use count of channels instead of boolean 'linked' in GetInfo.
This change is inspired by the plan to eliminate GetLinked() in 2.3.1.  Logically we shouldn't be exposing a boolean 'linked' in scripting, but instead a channel count.
2018-09-10 23:54:16 +01:00
James Crook
1ecff6d5db Bug 1971 - Linux: Scriptables screenshot command only grab a small rectangle of window 2018-09-05 19:16:07 +01:00
James Crook
7d0839393b Report selectedness of all tracks, not just WaveTracks.
(Suggested by Steve Daulton).
2018-09-03 22:02:15 +01:00
James Crook
85c1eb4720 Fix GetInfo: Type=Labels counts channels rather than tracks. 2018-08-29 13:35:21 +01:00
James Crook
d79c071d6d Change 'mouse_move' to 'move_mouse'.
Fixing a hyperlink.
2018-08-25 17:41:28 +01:00
James Crook
ac5b743dd2 Bug 1944 - Many "scriptables" link to non-existent pages or incorrect target pages 2018-08-24 19:18:04 +01:00
James Crook
66df5786de Make AUD-DO return a cons.
This is simple parsing of the response from AUD-DO.  The first part is the string message, the second 1 or NIL depending on if scripting reported OK or not.  Note that illegal scripting options often don't produce a 'Failed' but are silently substituted with valid ones.
2018-08-24 18:45:09 +01:00