1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-01 16:19:43 +02:00

10729 Commits

Author SHA1 Message Date
David Bailes
b06af2330b Revert "Bug 2215 - Cut does not work when in Pause mode"
This reverts commit 458d92157a4fccb2524971f607e28a6c73b1901f.

The fix caused another bug: when paused, with select all enabled, all audio was selected.
2019-10-01 15:19:11 +01:00
David Bailes
458d92157a Bug 2215 - Cut does not work when in Pause mode
In bool MenuManager::TryToMakeActionAllowed(), there's the condition:
(MissingFlags & enabler.possibleFlags()) == Missing

that is, the missing flags has to be a subset of the possible flags.
For cut in pause mode, this condition is not met for the enabler stopIfPaused, because MissingFlags also includes the CutCopyAvailableFlag, which is not one of the enabler's possible flags.
It is not sensible for the missing flags to have to be a subset of the possible flags, because for this to work, for each enabler the possible flags would have to include other flags that could need fixing by other enablers.

Fix: change the condition to the intersection of the missing flags and possible flags is non-empty.
2019-10-01 13:56:33 +01:00
David Bailes
6b2785b625 Revert "Bug 2215: Cut does not work when in pause mode"
This reverts commit 6a37cbae35da95b45f88d310a65b23064f3ed117.

This was reverted because it caused bug 2221.
2019-09-30 12:57:31 +01:00
David Bailes
6a37cbae35 Bug 2215: Cut does not work when in pause mode
Minor fix to logic required.
2019-09-23 12:31:05 +01:00
James Crook
cabe925ab7 Make exporting of Soloed Tracks WY(S/H)IWYG
Now the export (should) exactly match the (selected) non greyed out tracks.
i.e. what you see and hear is what you export - no matter which mode of
mute/solo you choose.

This is now applied not just to export but also to export multiple.
2019-09-08 14:22:40 +01:00
James Crook
ef8e1ed6ef Update pot and po files, ready for translation. 2019-09-07 14:09:35 +01:00
Jonatã Bolzan Loss
a77a3ab2ac Fix exporting soloed track 2019-09-05 17:57:57 -03:00
SteveDaulton
5d4c884764 Fix bug 1824
Generate effect preview fails when no selection
2019-09-05 21:01:46 +01:00
James Crook
76d52fdc99 Make Bevel2 widget antialiased
Hat tip to Jonatã Bolzan.
2019-09-05 13:02:31 +01:00
James Crook
fad541e818 Change wordings, (as requested by wiki page). 2019-09-04 20:12:26 +01:00
James Crook
a3eaf7d46e Fix Graphic EQ slider height tiny on Linux.
Thanks to Steve for alerting to the problem.
2019-09-04 20:07:26 +01:00
James Crook
72f36f8a82 Bug 1622 - Cryptic error message when existing project cannot be saved 2019-09-01 15:28:00 +01:00
James Crook
9a3bd94459 Bug 2185 - Import2: Incorrect error message if file not found 2019-09-01 15:11:22 +01:00
James Crook
844778797a Bug 46 - GSM 6.10 files cannot be exported - failure messages are unhelpful un-illuminating 2019-09-01 13:15:13 +01:00
James Crook
1a49d0a812 Bug 59 - Residual. MP2 exporting is broken. So disable it.
This fix also allows for reporting illegal combinations on OK.  However, we don't yet need to use that feature, as the dialog now prevents illegal combinations EVEN when you use 'Show all Codecs'
2019-09-01 13:13:20 +01:00
Paul Licameli
15fa593906 Remove a comment 2019-08-31 23:21:07 -04:00
David C. Manuelda
aab48c58f0 Ensure EXPERIMENTAL_MIDI_OUT is not defined if midi is disabled 2019-08-30 20:51:01 +01:00
David C. Manuelda
db0dceac54 Fix ill-formed std::hash<> specialization 2019-08-30 20:51:01 +01:00
David C. Manuelda
61598c4c27 Fix libtool linking 2019-08-30 20:51:01 +01:00
James Crook
fe3a866117 Bug 2077 - Residual: Original code was correct for Windows
If new code is used on windows, we get an assert.
2019-08-30 19:00:37 +01:00
James Crook
9e69be9f6f Bug 2182 - Updating Audacity can cause messed up toolbar layout 2019-08-30 09:28:26 +01:00
Paul Licameli
7149d8fcf9 Bug2077: FFmpeg custom options sub-modal dialog should appear foremost 2019-08-28 11:54:17 -04:00
Paul Licameli
fcf4b635d3 Fix line continuation (don't leave a space after \) 2019-08-28 11:34:32 -04:00
James Crook
089a7ec166 Bug 59 - No error reported to user and crash when FFmpeg attempts invalid custom export of WAV with mp2 codec
If one selects fmt wav in FFmpeg options, only legal exports are now available.
2019-08-28 13:14:14 +01:00
Alexander Tsoy
7a91b6c5e9 Fix compilation without USE_MIDI 2019-08-28 00:17:39 +03:00
James Crook
45ddc8c413 Rename EQ effects and lose 'extra knobs'
Team agreed on new names, and to remove redundant controls that are (mostly) just confusing.  Also retired EQ effect.
2019-08-27 19:38:32 +01:00
James Crook
c32b92c377 Bug 2199 - crash after attempting to export as OGG at very high sample rate 2019-08-24 19:13:05 +01:00
James Crook
569028268d Bug 2207 - Filter Curve and Graphic EQ have no factory presets (available in 2.3.2 and earlier) 2019-08-24 13:55:54 +01:00
James Crook
5fe04e19eb Add EQ functions to Screenshot Tools 2019-08-23 19:36:05 +01:00
James Crook
83ddabc895 Bug 1750 - Equalization: EQ control points can disappear if the points are at the same frequency 2019-08-23 19:28:35 +01:00
James Crook
a1f0a70ddd EQ Tweaks for Independence
Added:
- Independent Help pages
- Independent Curves

Also tweaked for the new namings
2019-08-23 18:41:26 +01:00
James Crook
8031bf7c14 Bug 2206 - Filter Curve (and Graphic EQ) corrupt saved curves (on the right)
Frequency range was set too narrow.
2019-08-23 16:39:05 +01:00
James Crook
bbc202807f EQ: Don't Load XML data any more
Also abolished use of nPoints, making parameters easier to set up.
This also fixes an issue where more points than are there could be read, if cfg file bad.
2019-08-23 12:12:07 +01:00
David Bailes
889bf7c191 Graphic equalization: fix accessibility name
Overlooked this change which should have been done when we moved to wxWidgets 3.1.1
2019-08-23 11:10:15 +01:00
James Crook
3e98a109c9 Make Graphic EQ vertically stretchable
Drag to enlarge the window, and the length of the graphic sliders.
This was part of splitting EQ.  The split effect would look strange if we did not do this.

Graphic EQ sliders are now in a sizer, and so we no longer lay them out 'by hand' in the way we previously did.
2019-08-22 20:08:52 +01:00
David Bailes
9cfff86763 Bug 1548 - Newly recorded tracks do not acquire focus
Problem: The previous fix (+ possibly later changes) meant that this was working for mono tracks but not stereo. When recording in a new stereo track, the first track in the project became the focus.
The existing code sets the second of the two new tracks to be the focus before the tracks have been grouped into a stereo pair.

Fix: Set the first of the new tracks to be the focus.
2019-08-22 18:27:11 +01:00
James Crook
c9fbd283b7 Fix release build EQ functions.
Uninitialized variable was 0 in debug builds, but could be very high value in release.
2019-08-21 23:46:31 +01:00
James Crook
c1c7d5f0a0 Graphic EQ / Filter Curve mods
This is part of the work of fixing Equalization by splitting it into two effects.

The Graphic EQ effect now does not show the curve or 'grid on/off' checkbox.
Screenshot Commands now include Graphic EQ and Filter Curve in the captures (and not EQ anymore).
Menu items now have a space in them.
2019-08-21 22:22:13 +01:00
James Crook
23063511d9 Bug 2031 - Equalization: presets under the Manage button do not save custom EQ curves
Further work needed, and a tidy up to bring arrays into ShuttleGui would be nice, but this gets us most of the way.
2019-08-21 17:56:31 +01:00
James Crook
80ef424338 Bug 169 - Welcome Message: Local links to "Quick Help" and "Manual" do nothing if help is not installed. 2019-08-20 22:29:18 +01:00
Paul Licameli
efc95152d5 Bug2191: Opening project with silent blocks should not warn...
... Bug began at ca0fb190e6a98a8c44c8c2ed7fe2422c47a22845
2019-08-20 13:41:00 -04:00
Paul Licameli
0c1b969c12 Fix Mac build, was broken at da66806...
... Fix I wrote as a late 2.3.2 pull request was before I did other cuts and
pastes for cycle breaking.  Replicating the patch in the new place without
extra #include directives did not compile.
2019-08-20 12:53:29 -04:00
Mikhail Novosyolov
3b9174cd9b Fix building with wxWidgets 3.1.2
From changelog:
- wx/treebook.h doesn't include wx/treectrl.h (and, via it, wx/textctrl.h) any
  more, include these headers explicitly from your code if necessary.
2019-08-19 22:57:53 +03:00
James Crook
06af0c6296 Bug 803 - Incorrect pointer (cursor) when rearranging tracks
There is no wxCURSOR_REARRANGE so made a custom cursor instead.
2019-08-18 14:47:17 +01:00
James Crook
c65eb8fea5 Bug 2193 - Remove Tracks in Tracks menu is grayed-out if there is no selection 2019-08-17 18:52:46 +01:00
James Crook
da5d049fa0 Bug 2200 - Uncompressed exports in formats that have no (realistic) size restriction fail the 4GB trap for WAV & AIFF 2019-08-17 15:09:06 +01:00
Jonatã Bolzan Loss
6e5437587b Bug 1904 - Audio offset not honored in Export/Export Multiple/Export Selection 2019-08-17 11:24:15 +01:00
James Crook
da66806bc0 Bug 2107 - Mac Accessibility: if a text box is the focus, pressing enter does not press the default button
Adapted very slightly from Paul's fix and pull request.
See also Bug 1329.
2019-08-14 21:37:57 +01:00
James Crook
44c46f7574 Wording - further requested tweak.
It's the behaviors of tracks (plural), so possessive apostrophe after.
2019-08-12 12:58:45 +01:00
James Crook
ce5884a1f9 Wording fixes for 2.3.3
Per https://wiki.audacityteam.org/wiki/Wording
2019-08-12 10:39:20 +01:00