This reverts commit 458d92157a4fccb2524971f607e28a6c73b1901f.
The fix caused another bug: when paused, with select all enabled, all audio was selected.
In bool MenuManager::TryToMakeActionAllowed(), there's the condition:
(MissingFlags & enabler.possibleFlags()) == Missing
that is, the missing flags has to be a subset of the possible flags.
For cut in pause mode, this condition is not met for the enabler stopIfPaused, because MissingFlags also includes the CutCopyAvailableFlag, which is not one of the enabler's possible flags.
It is not sensible for the missing flags to have to be a subset of the possible flags, because for this to work, for each enabler the possible flags would have to include other flags that could need fixing by other enablers.
Fix: change the condition to the intersection of the missing flags and possible flags is non-empty.
Now the export (should) exactly match the (selected) non greyed out tracks.
i.e. what you see and hear is what you export - no matter which mode of
mute/solo you choose.
This is now applied not just to export but also to export multiple.
This fix also allows for reporting illegal combinations on OK. However, we don't yet need to use that feature, as the dialog now prevents illegal combinations EVEN when you use 'Show all Codecs'
Also abolished use of nPoints, making parameters easier to set up.
This also fixes an issue where more points than are there could be read, if cfg file bad.
Drag to enlarge the window, and the length of the graphic sliders.
This was part of splitting EQ. The split effect would look strange if we did not do this.
Graphic EQ sliders are now in a sizer, and so we no longer lay them out 'by hand' in the way we previously did.
Problem: The previous fix (+ possibly later changes) meant that this was working for mono tracks but not stereo. When recording in a new stereo track, the first track in the project became the focus.
The existing code sets the second of the two new tracks to be the focus before the tracks have been grouped into a stereo pair.
Fix: Set the first of the new tracks to be the focus.
This is part of the work of fixing Equalization by splitting it into two effects.
The Graphic EQ effect now does not show the curve or 'grid on/off' checkbox.
Screenshot Commands now include Graphic EQ and Filter Curve in the captures (and not EQ anymore).
Menu items now have a space in them.
... Fix I wrote as a late 2.3.2 pull request was before I did other cuts and
pastes for cycle breaking. Replicating the patch in the new place without
extra #include directives did not compile.
From changelog:
- wx/treebook.h doesn't include wx/treectrl.h (and, via it, wx/textctrl.h) any
more, include these headers explicitly from your code if necessary.