... Cross platform differences in Focus handling are confusing, and we don't
know yet how to abort drags and also put focus back where we want it on Linux.
So don't take focus even temporarily in the time ruler. Sorry, ESC key won't
work.
Problem:
1. Set no access to microphone in Privacy category of Settings app.
2. Try to record in a new track. (not append to an existing track.)
3. Audacity crashes.
Cause of crash:
TrackPanel::OnTrackListResizing is called with a track after a call to
TrackList::ClearPendingTracks, which has removed its owner.
TrackPanel::OnTrackListResizing ends up calling TrackPanel::UpdateTrackVRuler,
and this function calls TrackList::Channels(t)), which assumes the track has an owner.
Crash.
Fix: in TrackPanel::OnTrackListResizing, check that the track has an owner.
... Fixed as suggested by David Bailes.
Confirmed on Mac and Windows that the intended ESC key handling to abort drag
in the ruler also now works. (It didn't on Windows in 2.3.0.)
Windows: Macros - "ExportMP3 before" and "ExportMP3 after" overwrite
causing non-critical data loss.
Thanks to Mike Barker for locating the problem.
This fix also corrects the bit-rate for the ExportMP3_56k commands.
... in case clip boundaries don't match and the right channel covers a greater
time extent than the left.
Don't lose those parts of the right channel, before or after, and also make the
start time of the project correct in case the right channel starts earlier.
This is an old bug, going back as far as the git history.
With the steps in bug 2028, FindFocus() could return a nullPtr - which is now safe.
No right context menu will appear though.
This looks like a bug in wxWidgets.
We could take more/different steps to find the parent for the LabelTrack, if we really want to do that. However, this change is enough to close the bug.
This arose from the conversion from optional parameters to required parameters.
The same problem was found in Screenshot command and in open/save command.
Bug 2013 - Extended ASCII characters in Nyquist plug-ins freeze Audacity
We previously assumed that plug-ins would always be valid UTF8, but
if it isn't then the conversion to wxTextInputStream fails, causing
pgm.ReadLine() to perpetually return a zero length line.
... I checked, and there are no other missed inclusions of Experimental.h
before tests of EXPERIMENTAL_* macros, except the special handling of version
numbers in Audacity.h.
Problem: With host set to WASAPI: if the playback position is less that about ten seconds before the end of any of the tracks and the user presses one of the left/arrow keys to seek, then a bug alert appears, and it's seems like it's impossible to recover from this.
libsoxr 0.1.3, first used in Audacity 2.3.0, crashes with constant rate resampling if you try to reuse the resampler after it has flushed.
Fix: work around which is the same as used for bug 1887 - recreate resamplers, rather than reusing them.
