Works by un-full-screening before closing. Patching wxWidgets was needed to
make that work correctly after full-screening by clicking on the green circle
in the title bar, but that fix is not needed for full screen after command+/
... To short selections (under 1/100 second), at the start of the second of
two separated clips, in a project with a high sampling rate of 192000.
Symptom was that the audio moved so it was pasted to the end of the first clip.
Other uses of the constant WAVETRACK_MERGE_POINT_TOLERANCE should be
reviewed too but this is a conservative fix made close to release time.
... Partial reversion of commit 2e8ee5fe75789d60869b19fe1986c8d47cf0b995
Now, if you open an effect dialog, Return key will apply it. But, if you
cycle among windows with alt+f6, then the focus moves among the controls in
the effect dialog, and I don't know how to prevent that.
At least so it is in Mac. I have not verified it with Linux.
Problem was that when these commands were used when playback was stopped, the tracks did not automatically scroll to make sure that the label that had been moved to was visible.
Fix: call TrackPanel::ScrollIntoView().
Reasons for removing the default keystrokes:
1. Added keystrokes may conflict with keystrokes already defined by user, and Audacity doesn't currently handle this situation in a user friendly manner.
2 There may be additional label commands in the near future, so even if default keystrokes were felt appropriate for these commands, it may be useful to delay the assignment until any other related commands have been decided.
After discussion on Audacity-quality mailing list, the commands now refer to the stored cursor position, rather than the saved cursor position. (This position is not saved to disc).
When used during playback, this was producing unexpected results.
Fix is to use setTimes(t0,t1), rather than calls to setT0(t0) and set(t1) which was producing unexpected results.
Changes to "Save Cursor Position" and "(Select) Cursor to Saved Cursor Position"
Both the saved cursor position, and the current cursor position are the audio position if audio is active, else selection start.
The selected time range is the min, and max of these two values.
... Don't double-count any block files. Count each only in the latest undo
history state containing it, because you reclaim its space only by deleting
the history at least up to that state.
Block files may still be double-counted between undo history and the clipboard.
A sync-lock group is a maximal sub-sequence of the tracks, containing:
one or more wave tracks (and/or Note tracks, if MIDI is enabled),
and zero or more label tracks.
(These are not exhaustive of all of the types of tracks.)
So redefine Next(), Prev(), and Last() carefully to implement this intention.
Problem: On Windows, if you set the "length" radio button in the selection bar, then tab round to it, this sets the "end" radio button.
This was caused by commit 7e49dc4.
The fix is to restore the previous code just for Windows.
... This is done with Shift+Ctrl+wheel and pointer in the vertical ruler, and
the pointer y coordinate near the bottom of the dB scale.
If y coordinate is far from there, then Shift+Ctrl+wheel changes dB level
without change of magnification (as before this commit).
The Edit buttons now enable/disable whenever their Menu counterparts
are enabled/disabled, but there are residual issues due to incorrect
behavior in "Select all if none selected" (noted in comments).
Added a setting for whether labels can be created by typing in a label track.
The setting can be changed in either the Tracks menu, or the Tracks category in Preferences.
By default the setting is set to on.
The two commands are "selection to next label" and "selection to previous label".
They have default shortcuts alt+right and alt+left.
A label track does not have to be the focus. If there is a single label track in the project, that it used. If there is more than one label track, then the first label track, if any, starting at the focused track is used.
If the commands are used during playback of the project, playback continues from the new cursor/selection.
The commands provide feedback to screen readers: the name of the label, and position in the form of "i of n".
These are "Moved focused track up/down/to top/to bottom" in keyboard
preferences.
There were prior changes that made any shortcuts for them appear in the track
control drop-down menu, but only after closing Preferences. They still did
not appear after restart of Audacity, although the keystrokes had their effect.
See commit bb7dba2b678735da60b857fa99e963396d5a875f
and commit 7608e9cb521a6d57a030e1339b980c85f6b97227
