Paul Licameli
12adba0c1d
Merge pull request #116 from ThomasFeher/fix_warnings_uninitialized
...
fix -Wmissing-field-initializer (3 occurences)
2016-03-01 17:19:14 -05:00
Thomas Fehér
7e0eb8683c
fix -Wmissing-field-initializer (3 occurences)
2016-03-01 20:54:52 +01:00
Paul Licameli
0c9deb398c
Fix mac build. No standard headers in Audacity.h.
2016-03-01 12:22:37 -05:00
Paul Licameli
7aee5d09d8
Move the recent const_casts elsewhere
2016-02-29 19:56:27 -05:00
Steve Daulton
4173bb1a37
Fix error in string comparison
2016-02-29 13:26:38 +00:00
Paul Licameli
0094c4f465
Bug1348, partial: Fix bad undo after cancelling Vamp or FindClipping analyzer
2016-02-27 18:12:36 -05:00
Paul Licameli
48a5f55179
More const qualifiers, for copying of tracks, and replacing in lists of tracks
...
... (the tracks may be const, not the list, when replacing)
2016-02-27 17:30:30 -05:00
Steve Daulton
36f3f8aab2
Update Eq factory presets on upgrade
...
Add search paths for EQDefaultCurves.xml
2016-02-27 21:20:53 +00:00
Paul Licameli
6f63226291
More const qualifiers and mutable members for drawing of tracks
2016-02-27 13:04:34 -05:00
Paul Licameli
d097c7fad4
More const qualifications. The source of a paste is const.
2016-02-27 12:54:57 -05:00
Paul Licameli
70c1d57591
More const qualifications, and mutables, for functions that draw tracks...
...
... The display related members that had to become mutable are probably
ones that don't belong in the track classes, ultimately.
2016-02-27 12:35:17 -05:00
Paul Licameli
05f5375e4a
Use std::vector for wave track locations
2016-02-27 12:08:03 -05:00
Paul Licameli
60eeac0b10
Remove changes not really needed to fix warnings, and which broke some builds
2016-02-27 09:41:23 -05:00
Steve Daulton
b5d2528c03
Enable Eq factory presets to be updated on upgrade
2016-02-27 13:17:27 +00:00
Paul Licameli
60f2322055
Fix warnings for returning false instead of null
2016-02-26 14:56:32 -05:00
Paul Licameli
3cc4754ac7
Fix warnings for nonexhaustive switches on enumerations
2016-02-26 14:56:31 -05:00
Paul Licameli
dfc84d030c
Fix warnings for out-of-order initializers, with in-class member initializers
2016-02-26 14:56:30 -05:00
Paul Licameli
1398d1a953
Fix warnings for ambiguous else
2016-02-26 14:56:29 -05:00
Paul Licameli
60bcd7aea2
Fix warnings for unused variables and functions
2016-02-26 14:56:26 -05:00
Paul Licameli
990080ae7d
Replace virtual with override wherever possible; eliminate needless virtual...
...
... for functions in final classes.
override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.
There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
74121c1494
Comment a questionable function
2016-02-26 12:35:31 -05:00
Paul Licameli
4a6fd96a97
Commented out some unused functions
2016-02-26 12:35:30 -05:00
Paul Licameli
89f28546a3
Commented suspicious non-override virtual functions of Effect
2016-02-26 12:35:29 -05:00
Paul Licameli
ba4006a454
Removed unused functions of LabelTrack, but was there an error?
2016-02-26 12:35:28 -05:00
Paul Licameli
970205527b
Fix argument error, found using override!
2016-02-26 12:35:27 -05:00
Paul Licameli
a8652c5e74
uses
2016-02-25 20:18:31 -05:00
Paul Licameli
e3e10f1fc1
A few changes not using Maybe
2016-02-25 20:18:30 -05:00
Paul Licameli
62361c32f4
Define Maybe<X>
2016-02-25 20:18:29 -05:00
Paul Licameli
527a826b86
Define and use PROFILE_DLL_API
2016-02-24 21:29:25 -05:00
Paul Licameli
6a3d99a8e6
travis
2016-02-24 21:14:19 -05:00
Paul Licameli
7824e94030
Harmlessly qualify classes as final (or explicitly comment not)...
...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls. Mostly useful as documentation of design intent.
Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
e2f7e5f6f6
travis
2016-02-24 20:45:49 -05:00
Paul Licameli
e815090139
travis
2016-02-24 20:30:26 -05:00
Paul Licameli
88eeebcb8b
Undoing and redoing of Tags...
...
Use reference counting (in std::shared_ptr) to avoid replicating Tags with each
Undo state.
2016-02-24 19:25:39 -05:00
Paul Licameli
e12a060751
Define UndoState
2016-02-24 19:10:40 -05:00
Paul Licameli
a5b6c9fd8f
Add some const qualifiers; define TrackListConstIterator
2016-02-24 19:10:39 -05:00
Paul Licameli
ffe9989f7c
Don't use an internal iterator in Tags
2016-02-24 19:10:38 -05:00
Paul Licameli
a1c7b396b3
UndoStackElem has proper constructor and destructor; use std::vector
2016-02-24 19:10:36 -05:00
Paul Licameli
cd9bd79d83
Use an enumeration for UndoManager::PushState
2016-02-24 19:10:35 -05:00
Paul Licameli
73ced7b93f
Remove UndoManager.h from other headers
2016-02-24 19:10:34 -05:00
Paul Licameli
0c182c3c0b
Shrink the command functor objects by using more subclasses...
...
... Let virtual function dispatch do the work, don't write our own dispatch!
2016-02-24 15:17:06 -05:00
Paul Licameli
09b4dfc5a2
travis
2016-02-24 13:52:21 -05:00
Paul Licameli
c98b090182
Rename SyncLockTracksIterator::First to StartWith to be consistent
2016-02-24 12:59:28 -05:00
Paul Licameli
9bf098c7d9
Sweep unnecessary wxString copies: rest
2016-02-23 02:15:56 -05:00
Paul Licameli
6597575f6a
Sweep unnecessary wxString copies: blockfile
2016-02-23 01:40:29 -05:00
Paul Licameli
923a6ce4af
Sweep unnecessary wxString copies: commands
2016-02-23 01:40:21 -05:00
Paul Licameli
99f161c36c
Sweep unnecessary wxString copies: effects
2016-02-22 22:31:47 -05:00
Paul Licameli
83e8a80f61
Sweep unnecessary wxString copies: export
2016-02-22 22:22:25 -05:00
Paul Licameli
d21c0aa478
Sweep unnecessary wxString copies: import
2016-02-22 22:13:50 -05:00
Paul Licameli
0ce4fe0b83
Sweep unnecessary wxString copies: prefs
2016-02-22 21:30:42 -05:00
