Modification to commit 7ab4b8c. The first non-zero digit only becomes the focus on the first visit to the control. On subsequent visits, the focus is the previous focus. Example use case: modifying start and end times by a tenth of a second. The user can move between the controls without loosing his "place".
The name of the button was not being read as "help" by NVDA due to its built in appmodule for audacity. This meant that the empty label was being read rather than the accessibility name.
Fix: Call SetLabel. In addition, with the label being set, an accessible does not need to be set, because we can just let windows set the accessibility name from the label.
Prefs dialog can now be more compact, but the tree control gains scrollers which look poor. So a height of at least 480px, if no height was set by the user, is used. This way also the key config prefs have reasonable height.
Doesn't set the min size. On small screens, users can scrunch the dialog up tightly if they really want to.
... This may make a difference and breadk compatibility only for Sliding Time
Scale/Pitch Shift, the one effect for which those were different.
Using a locale-independent internal string in a config file is the Right
Thing To Do.
The third argument of ASlider constructors already provided suitable accessibility names. So removed the unnecessary calls to SetName which set unsuitable names.
... Allow recording stereo into non-adjacent mono tracks, if they are selected.
Prefer the earliest-starting set of tracks in the track list, among either
selected tracks, or else among all tracks.
Therefore if selection contains a mono, a stereo, and a mono in that order,
the two monos may be chosen to record new stereo.
The worst symptoms of this are fully fixed.
1: The device info now uses all the space in the toolbar, no matter how the toolbar is resized.
2: The undocked toolbar can now be moved around repeatedly without changing size at all.
There is a small residual - a much toolbar size change of a few pixels on docking. The contents though still fit nicely. The 'incredible' part of this bug is gone. I'd like us to close this bug as the residual of a few pixels change in the toolbar size on repeated docking and undocking scarcely matters.
The main change in wxWidgets for the setting of accessibility names is:
7dab555f71 (diff-04f5191d86f95b1c4d5d9c979da65878)
Before this change, with wxUSE_ACCESSIBILITY set to 1, for wxWindow and all the classes derived from it, wxWidgets automatically created accessible objects to handle accessibility itself. Because the way wxWindowAccessible::GetName() was written, the accessibility names of lots of windows and controls had to be set using SetName().
After the change, by default, the accessibility of instances of these classes is handled by Windows. Where the accessibility of a control is handled by Windows, then the accessibility name is automatically set to so the appropriate value. However, an accessible can still be set using SetAccessible() then wxWidgets handles the accessibility for this object.
So for many controls we can just leave Windows to set the accessibility name. However, for controls which don't have any visible labels, or where we want to accessibility name to different from the visible text, then we have to set an accessible object for that control, and then call SetName(). The Class WindowAccessible can be used for this purpose. And for custom widgets, like the TrackPanel, and the NumericTextCtrl, SetAccessible() still has to be called, since they need bespoke accessible objects
So in the cases where we want the accessible name to be different from normal, we now need to explicitly set an accessible object. (Before, this wasn't needed, as accessible objects were automatically created.).
Some notes of the fixes included in this commit:
1. The fixes cover the main window, preferences, and built-in effects. Other fixes will follow.
2. In ShuttleGui, I've set accessible objects for wxTextCtrls and wxSliders. So all of these widgets still need the name set. This was done because there are a lot of instances where these controls need non standard accessibility names, and so it saves having to put lots of SetAccessibles throughout the code.
3. For wxPanel, Windows picks up the accessibility name from the label, and so SetLabel() can be used instead of SetName(). This is just as well, since for windows that contain other windows or controls, setting WindowAccessible as the accessibility object breaks the accessibility tree.
Note that at some stage a lot of calls to SetName() can be removed from the code as they are no longer needed, but it might be better to leave them there for the moment, just in case they are unexpectedly needed.
Or more precisely, don't do append-record, if doing so would lose a channel - e.g. if there is only a mono track selected and recording is set to stereo.
The commented out wxLogDebug statements in Theme.cpp give the
location of all the boxes in the theme. This is useful
for identifying what is in the theme cache for javascript code.
This #ifdeffed out TEST_CARD is useful for javascript code that shows how a
theme will look, when applied to Audacity. With the code enabled, each
pixel of audacity is painted with a colour that encodes the location in
the theme image map that was used.
Net result - in javascript you can change any colour in the theme cache
and instantly see how Audacity will look.
