Paul Licameli
41efaeeef0
Fix Windows build
2016-08-14 09:35:04 -04:00
Paul Licameli
32f24eabb2
Review uses of safenew...
...
... add comments and assertions, and use make_unique instead where possible
2016-08-13 23:16:05 -04:00
Paul Licameli
84a6456788
Iterate over all clips of a track, including cutlines, where needed
2016-08-13 20:17:55 -04:00
Paul Licameli
6909bdf398
Define and use IteratorRange
2016-08-13 16:31:31 -04:00
Steve Daulton
90e400b0a7
Add SBSMS option to Change Pitch effect
2016-08-13 17:28:49 +01:00
Paul Licameli
389d4dc9e6
Dir manager uses std::shared_ptr
2016-08-13 12:23:42 -04:00
Paul Licameli
46f38708ed
Dir manager uses std::shared_ptr
2016-08-13 12:23:05 -04:00
Paul Licameli
13e5788a6b
Merge branch 'master' into deletes
2016-08-13 12:22:47 -04:00
Paul Licameli
e412c13e78
Fix crash at program exit after use of Stereo to Mono
2016-08-13 10:39:56 -04:00
Paul Licameli
291aff18e1
Remove various naked news and deletes
2016-08-13 10:38:50 -04:00
Paul Licameli
bf1e8a1227
One more safenew for the logger object
2016-08-13 10:37:52 -04:00
Paul Licameli
2024c8b319
Remove a naked new in AudacityLogger.cpp
2016-08-13 10:37:52 -04:00
Paul Licameli
b6241c46d3
Remove a few more naked new in CommandManager.cpp
2016-08-13 10:37:52 -04:00
Paul Licameli
2917fe5087
One more make_unique for WaveClip, and comment changes
2016-08-13 10:37:52 -04:00
Paul Licameli
e599cfa6fa
Effect::mOutputTracks is managed by smart pointer
2016-08-13 10:37:51 -04:00
David Bailes
7f122a42f9
Fix Windows build
...
vs2013/5 do not support defaulted move constructed, so made it explicit.
2016-08-13 13:18:34 +01:00
Paul Licameli
87aeef2bfc
Remove naked new and delete in the management of WaveClip objects
2016-08-12 20:53:55 -04:00
Paul Licameli
dcceaca13c
Envelope bug
2016-08-12 20:53:38 -04:00
Paul Licameli
cb48ca2b91
Use arrays of smart pointers to WaveClip
2016-08-12 20:53:38 -04:00
Paul Licameli
a400a7408c
Distinguish whether clip ptr arrays own; vector; const-correctness
2016-08-12 20:53:38 -04:00
Paul Licameli
4cbca5d75c
Use std::vector to hold WaveClips
2016-08-12 20:53:38 -04:00
Paul Licameli
afc22caf5a
WaveClip::GetCutLines() returns a reference
2016-08-12 20:53:37 -04:00
Paul Licameli
bd57f6392f
Simplify iterations over cutlines in WaveClip.cpp; stl idioms
2016-08-12 20:53:37 -04:00
Paul Licameli
77a3647922
Simplify iterations over WaveClips in WaveTrack.cpp; stl idioms
2016-08-12 20:53:37 -04:00
Paul Licameli
b548e641ae
Simplify iterations over WaveClips outside of WaveTrack/WaveClip; ...
...
... also add some const qualifiers
2016-08-12 20:53:37 -04:00
Paul Licameli
cb7872f980
use std::vector to hold TrackClip; move ctor and dtor out of line
2016-08-12 20:53:37 -04:00
Paul Licameli
c373f4d859
Merge branch 'master' into deletes
2016-08-12 20:53:04 -04:00
James Crook
2d2cf5911f
Pinned/Unpinned button now affects PlayHead.
...
Bug 1451 comment 6 asks for PlayHead to change too with the change in the button icon on up/down, making the action of the button clearer.
This change does not though change the icon on the button to red when recording. It stays green, though the PlayHead does change correctly.
2016-08-12 17:32:30 +01:00
James Crook
c2eda38ee1
Bug 1455 - Windows/Linux: Scrub Bar button background colour darker than Timeline/other toolbar buttons
...
Background, over the part that shows the number '1.0' is now transparent.
2016-08-12 13:49:02 +01:00
James Crook
53bb478600
Bug 1457 - Transport Menu "Scrub" and "Seek" do not correctly indicate when either Scrubbing mode is active
2016-08-11 22:30:51 +01:00
James Crook
35c033d3fa
Bug 1451 - On Mac the background of the Pinned/Unpinned button is not the same color as the Timeline
...
Per comments in the bug, fixed by making the pinned/unpinned button more clearly a button.
This involved adding a new type of grabber that does not have the ribs for dragging it and acts as a spacer.
Also fixing grabber so that it does not have to be at position (0,0)
Also making the ruler 1 pixel higher.
Also changing the pin button to be a toggle button that changes from up to down on a click.
Also fixing AButton so that an image can be bigger than the button.
2016-08-11 21:54:45 +01:00
James Crook
eebe4a961e
Bug 1419 - Confusing and unnecessary widget change when clicking in Scrub Bar
...
Behaviour now is still (in my view) confusing, but the widget does update when you click and release and haven't moved yet, which it didn't do before.
2016-08-11 17:59:41 +01:00
Gale Andrews
f7a85f4d52
Fix typo in label
2016-08-11 17:12:00 +01:00
Paul Licameli
9c0ac0aaa4
NEW SOURCE FILE: Remove naked news and deletes in directory import
...
New source file is only a header however.
2016-08-11 11:52:42 -04:00
Paul Licameli
eef2669abd
One less indirection accessing containers in Importer
2016-08-11 11:51:33 -04:00
Paul Licameli
8226441210
use vector of smart pointers to ExtImportItem objects
2016-08-11 11:51:33 -04:00
Paul Licameli
28f0b11376
Use arrays of smart pointers to import plugins
2016-08-11 11:51:33 -04:00
Paul Licameli
7d89e5ff68
Pass containers by ref to import plugin factories, use STL idiom
2016-08-11 11:51:33 -04:00
Paul Licameli
924df495ff
Make headers in import directory self-contained
2016-08-11 11:51:33 -04:00
Paul Licameli
256a595d0f
Use const
2016-08-11 11:51:33 -04:00
Paul Licameli
1d08c793ed
Merge branch 'master' into deletes
2016-08-11 11:51:10 -04:00
James Crook
a90f32e60d
Bug 1456 - Scrub Bar tooltip is incorrect on mouse down because there is no separate tooltip for that state
2016-08-10 22:21:21 +01:00
James Crook
5939fe66e8
Bug 1053 - [Scrub Phase I] Status Bar messages incomplete for scrub started with menu or shortcut.
2016-08-10 21:57:29 +01:00
James Crook
48ad701e57
Bug 1421 - When Scrubbing the Play button in the Transport Toolbar should not change its icon
2016-08-10 21:04:46 +01:00
Steve Daulton
75f1f30fcb
Add track scrolling shortcut to mouse preferences
2016-08-10 19:56:16 +01:00
James Crook
2a93e451b6
Bug 1458 - Scrubbing Toolbar buttons do not update to show the action they will perform
2016-08-10 19:36:09 +01:00
James Crook
e96edb8f26
Bug 1457 - Transport Menu "Scrub" and "Seek" do not correctly indicate when either Scrubbing mode is active
2016-08-10 19:17:40 +01:00
James Crook
8dd93ef2a8
Bug 1467 - New pref for pinned head should move to the Prefs>Tracks
...
Also updated the wording as per comment #2 in Bug 1467.
2016-08-10 18:38:37 +01:00
James Crook
8089bd484a
(Cosmetic) added 'final' to class definition.
...
Putting the word 'final' is a bit like adding a comment that nothing is derived from this effect.
2016-08-10 18:25:07 +01:00
Paul Licameli
062e50eca6
Remove various scalar naked news and deletes
2016-08-10 11:06:07 -04:00