1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-24 08:10:05 +02:00

448 Commits

Author SHA1 Message Date
Paul Licameli
0d7250578d Other methods of WaveTrack return void, will throw on failure instead 2017-03-31 18:26:52 -04:00
Paul Licameli
e1473dfe76 void return, not boolean success, from some Track virtual functions...
... The return codes were mostly ignored anyway, and exceptions will be thrown
instead.

It seems there was also confusion whether the return values of Track::Paste
and Track::SyncLockAdjust were to indicate success or indicate whether there
was any change.  No matter now.
2017-03-31 18:26:52 -04:00
Paul Licameli
6b84dc1c1d Factory methods will return non-NULL or throw 2017-03-31 18:14:29 -04:00
Paul Licameli
ad34145ded Clarify paste logic, throw to rollback on error, keep TimeTrack unique...
... though TimeTracks are not yet ever cut or copied; but next commit will
change that.
2017-03-31 18:02:22 -04:00
Paul Licameli
6c4cf46c06 Move mute and solo state into PlayableTrack 2017-03-29 13:45:08 -04:00
Paul Licameli
b2ab9b5087 Simplify MixerBoard.cpp using the PlayableTrack type 2017-03-29 13:42:51 -04:00
Paul Licameli
f1bec85675 use AudioTrack 2017-03-29 13:27:22 -04:00
Pokechu22
2d912f3c93 Replace assert calls with wxASSERT 2017-03-27 01:26:42 -04:00
windinthew
e2a7282690 Fix wording issues reported on Wiki
No ellipses in title bar of file open/import dialogs
Auto Recovery Discard dialogs say only recoverable projects are discarded
Capitalised button in Dependency dialogue per MS guidelines.
2017-03-27 05:36:10 +01:00
Steve Daulton
a07bf9c325 Rearrange 'Skip to' menu
Group "cursor to project start / end" with other "Cursor to" commands.
Move remaining two "Skip to" commands to View menu (subject to change).
Access keys to be decided.
2017-03-23 11:39:36 +00:00
James Crook
1dce83006f Record on same track is now the default.
Record new track is now accessed by SHIFT+R and is so named in the menu and tool tip.
2017-03-22 16:42:40 +00:00
Paul Licameli
1552ff188f When opening a file into a new project, delete the project on failure 2017-03-21 14:11:28 -04:00
Paul Licameli
79c3bef2ce Exception safety in: general effect performing functions 2017-03-21 14:11:24 -04:00
Paul Licameli
0bb6a3d971 Exception safety in: importing functions...
... Side effects on preferences may persist even after errors.
2017-03-21 14:11:23 -04:00
Paul Licameli
68c726918b If exception in cut/copy, leave clipboard clear (no partial results) 2017-03-21 14:11:19 -04:00
Paul Licameli
41f1ebfb5d Commit resampling of tracks to undo history one track at a time 2017-03-21 14:11:18 -04:00
Paul Licameli
82dd7545c9 Reviewed uses of release(); prefer Destroy_ptr to hold window objects 2017-03-21 14:11:18 -04:00
James Crook
5e3a4fa29d Name Record Beside menu option correctly. 2017-03-21 13:31:33 +00:00
David Bailes
879579475d Fix for bug 1611: after select none, temporary in-correctness
After select none, the timeline and selection times are temporarily not updated.

Fix: AudacityProject::SelectNone refreshes the TrackPanel, so call it after changing the SelectedRegion.
2017-03-20 15:06:59 +00:00
James Crook
8f71aa67df Allow same command more than once in the menus.
Pause appears in both Record and Play, and we want the P shortcut to work.
2017-03-19 19:32:35 +00:00
James Crook
148fc40b78 Restore menu items removed for DarkAudacity.
I'm not sure how useful they are, but Audacity may want them still.
Changed 'Store' to 'Save' to avoid confusion with 'Restore'.
2017-03-19 18:52:39 +00:00
James Crook
5c1f4d24b5 Menu rearrangement merged from DarkAudacity 2017-03-19 16:43:51 +00:00
Paul Licameli
692a033968 Remove naked new[] in: various 2017-03-17 17:52:47 -04:00
Paul Licameli
25619fb46e Don't create placeholder clips in Duplicate command ...
... when there is no clip at the right edge of the selection.
2017-03-17 17:52:39 -04:00
Paul Licameli
9eaa40659e Utility for track editing leaves fewer direct calls to GetLinked() 2017-03-17 17:52:28 -04:00
Paul Licameli
aa0d55ac83 Use enum class ProgressResult, don't interconvert with int or bool 2017-03-17 17:52:24 -04:00
Paul Licameli
6665370f61 Fix spelling in a function name 2017-03-17 17:52:21 -04:00
Paul Licameli
9af53f92cc un-confused editor indenting 2017-03-17 17:52:21 -04:00
Paul Licameli
81285ee0c1 More const and override 2017-03-17 17:52:20 -04:00
James Crook
2efd4ee9ca Bug 1599 - Amelioration. Don't require TrackExists to paste.
Following agreement between Steve and David B.
2017-03-03 10:14:32 +00:00
James Crook
fc42fd9b0d Bug 1597 - Tweak: make version check on welcome user-initiated.
The welcome screen now has an extra prelude for Alphas, and as result no longer needs to force a version check onto our website.  Users can still do that by clicking "check online".

I've also rearranged the version check code a little, so that there is better reuse.  E.g. we can change the URL in just one place in the code.
2017-02-28 19:05:06 +00:00
James Crook
c53e2dbb77 Bug 1597 - Enh: Greater clarity over status of versions needed
- For ALPHA builds we do a check version with the Welcome screen (if welcome screen is enabled).
- A 'Check Online' in the About box provides a new route to check version
- Check Version now passes CommitId and Build Date/Time to identify a version.

To actually close the bug we need the javascript on the server page to put up informative messages.
2017-02-25 23:00:39 +00:00
James Crook
f4bfe1fc02 Bug 1599 - Cannot paste clipboard text into label unless content already on Audacity clipboard
Thanks to Steve Daulton for the fix.
2017-02-24 18:07:47 +00:00
James Crook
63cb2a7b9a Bug 1575 Residual - Remove a wxLogDebug left in by mistake. 2017-01-16 21:54:04 +00:00
James Crook
0bc20269a7 Bug 1575 Residual - When label tracks exist, Nyquist effects run extremely slowly
The short-circuit evaluation of flags ONLY generated the NotMinimized flag, and all others were set to zero, when short-circuit evaluation happened.  This change remembers and preserves the other flags, so they don't get set to zero.
2017-01-16 17:08:21 +00:00
Steve Daulton
15aa84f10b Fix bug 1575
Includes fix by PRL:
https://github.com/Paul-Licameli/audacity/commit/cbca44e
2017-01-16 12:35:07 +00:00
Gale Andrews
27e1e16ffd Agreed reword of Region Save/Restore 2016-11-25 20:17:55 +00:00
David Bailes
71694d026a Fix for Move to Next/Previous Label commands
Problem was that when these commands were used when playback was stopped, the tracks did not automatically scroll to make sure that the label that had been moved to was visible.

Fix: call TrackPanel::ScrollIntoView().
2016-11-23 10:33:53 +00:00
Gale Andrews
8628dad100 Reinstate 'Move to next/previous label' bindings
Reverts 2c3d72f. Better, because this is a new "headline" feature.
2016-11-22 01:49:10 +00:00
James Crook
6d086dcc23 Fix TimerRecord overenthusiastic undo.
Thanks to Pual Licameli for finding the bug and its cause.
A cancelled TimerRecord would undo the previous action rather than just roll back.
2016-11-21 12:30:23 +00:00
David Bailes
2c3d72f0a2 Remove default keystrokes from Move to Next/Previous label
Reasons for removing the default keystrokes:
1. Added keystrokes may conflict with keystrokes already defined by user, and Audacity doesn't currently handle this situation in a user friendly manner.
2 There may be additional label commands in the near future, so even if default keystrokes were felt appropriate for these commands, it may be useful to delay the assignment until any other related commands have been decided.
2016-11-20 12:50:50 +00:00
David Bailes
87c0eb1563 Rename the two commands for the Saved cursor position
After discussion on Audacity-quality mailing list, the commands now refer to the stored cursor position, rather than the saved cursor position. (This position is not saved to disc).
2016-11-20 12:44:13 +00:00
Gale Andrews
7156d5b5c1 Consistency improvements
See http://wiki.audacityteam.org/wiki/Guidelines_on_capitalization_in_Audacity_dialogs_and_messages for why "At" should not be upper case.
2016-11-19 17:00:02 +00:00
Steve Daulton
1c9daeefb4 Change "Play/Stop and Set Cursor" shortcut to "X"
As agreed on QA list: https://sourceforge.net/p/audacity/mailman/message/35475977/
2016-11-19 15:48:35 +00:00
David Bailes
10b54fc94a Fix for Select Cursor to saved cursor position command
When used during playback, this was producing unexpected results.

Fix is to use setTimes(t0,t1), rather than calls to setT0(t0) and set(t1) which was producing unexpected results.
2016-11-11 13:55:55 +00:00
David Bailes
e50335850f Changes to the two commands involving the saved cursor position
Changes to "Save Cursor Position" and "(Select) Cursor to Saved Cursor Position"

Both the saved cursor position, and the current cursor position are the audio position if audio is active, else selection start.
The selected time range is the min, and max of these two values.
2016-11-09 13:19:48 +00:00
Paul Licameli
53a5c930a4 Bug1544: clipboard space usage in History updates after cut/copy...
This should be tested for Cut, Split Cut, Copy, and also for the same
commands in the Labeled Audio sub-menu of Edit.
2016-11-08 22:54:27 -05:00
David Bailes
3f8751d9a2 Minor fix for commit cc2447
Forgot the call to ModifyState. Also added call to Refresh, though I'm unsure whether that is still needed.
2016-11-08 10:27:05 +00:00
David Bailes
cc24472d09 Add two new commands for selecting a time range using the keyboard
The new commands are "Save Cursor Position" and "(Select) Cursor to Saved Cursor Position"
2016-11-08 08:58:48 +00:00
David Bailes
5542f88089 Changed names of the commands to move to next/previous label
Selection to next label => Move to Next Label
Selection to previous label => Move to Previous Label
2016-11-01 14:09:03 +00:00