1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-02 08:39:46 +02:00

141 Commits

Author SHA1 Message Date
Paul Licameli
0c9deb398c Fix mac build. No standard headers in Audacity.h. 2016-03-01 12:22:37 -05:00
Paul Licameli
990080ae7d Replace virtual with override wherever possible; eliminate needless virtual...
... for functions in final classes.

override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.

There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
e2f7e5f6f6 travis 2016-02-24 20:45:49 -05:00
Paul Licameli
cd9bd79d83 Use an enumeration for UndoManager::PushState 2016-02-24 19:10:35 -05:00
Paul Licameli
73ced7b93f Remove UndoManager.h from other headers 2016-02-24 19:10:34 -05:00
Paul Licameli
9bf098c7d9 Sweep unnecessary wxString copies: rest 2016-02-23 02:15:56 -05:00
Paul Licameli
df6a7c5464 More uses of safenew for classes we derive from wxWindow classes...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli
7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Paul Licameli
daa7617e88 auto_ptr (deprecated) -> unique_ptr (preferred in C++11) 2016-02-13 12:00:28 -05:00
Paul Licameli
d70ff3337d Bug501: Improve time-shift of clips between tracks...
... When you click in a stereo clip, move the correct partner clip with it.

When you click in the selection and it spans clips, move all clips containing
any part of the selection.  (As horizontal dragging does.)  Even if these are
not all within the same stereo track.

I implemented this rule:  If any clip moves up (or down) by n audio tracks
(not counting the label tracks), all clips must move the same number, and
all must move from mono to mono or left to left or right to right.  If that
is not possible, no move happens.
2016-01-24 23:08:10 -05:00
David Bailes
ba3b1b14ae possible fix for bug 1250
Go back to having both mono and stereo items in track menu.
2015-10-26 10:17:07 +00:00
Leland Lucius
2d88ad63e0 Fix for bug #1191 2015-09-08 11:24:59 -05:00
Paul Licameli
f24742acc0 Be sure to refresh scrub speed display when wheel moves but pointer does not 2015-09-04 20:52:26 -04:00
Paul Licameli
05de64e251 Remove unused fns; fix missing & misspelled headers in make & project files 2015-08-30 13:19:08 -04:00
Paul Licameli
01fe404a02 Move track permuting details out of TrackPanel.cpp 2015-08-29 13:46:35 -04:00
Paul Licameli
f49dbae9e2 Move minimize and close details out of TrackPanel.cpp 2015-08-29 13:46:26 -04:00
Paul Licameli
45e91f165a Move gain and pan details out of TrackPanel.cpp 2015-08-29 13:46:16 -04:00
Paul Licameli
6bfd3ee54a Move Mute and solo details out of TrackPanel.cpp 2015-08-29 13:45:51 -04:00
Paul Licameli
e7482c74bd Move cursor moving functions out of TrackPanel 2015-08-27 21:22:41 -04:00
Paul Licameli
5697f77a06 pull out a function for vertical ruler wheel events 2015-08-27 12:55:24 -04:00
Paul Licameli
6c6fc360ca Put the scroll-beyond-zero flag in just one place, ViewInfo 2015-08-26 23:17:20 -04:00
Paul Licameli
c45ea059e6 Reorder some things that happen in the track panel timer update. 2015-08-26 17:57:02 -04:00
Leland Lucius
f6cbc5e6db Merged a couple of patches from Debian, one of which should fix bug #1147 2015-08-25 23:08:12 -05:00
Leland Lucius
6a9dae20f5 Appearance on OSX is now back to normal or better
Some additional wx3 cleanup as well.
2015-08-23 20:25:01 -05:00
Paul Licameli
1b8f44d053 ViewInfo does not redundantly (or inconsistently!) store the screen width 2015-08-21 22:39:18 -04:00
Paul Licameli
a9ab31dedb Allow NULL arguments in TrackPanel::GetTracksUsableArea() 2015-08-21 12:02:48 -04:00
Paul Licameli
e7c7bb84a9 Fix off-by-one width in TrackPanel::GetTracksUsableArea() 2015-08-21 11:49:49 -04:00
Paul Licameli
112d2a903b Rename View Settings... to Spectrogram Settings... and enable it only for...
... spectrogram views, and don't show the Waveforms page.
2015-08-19 10:21:04 -04:00
Paul Licameli
409cbb2996 Bugs 994, 1030: Scrubbing behavior with pointer outside of the track panel...
... first: suspend scrubbing only when the application is deactivated -- not
necessarily when track panel loses focus; resume when reactivated.

second: click and drag to seek happens only when the pointer is in the track
panel, and either over a wave track, or over no track.
2015-08-18 11:06:53 -04:00
Paul Licameli
cf45a58fdc dB range is now in Waveforms preferences and view settings, and ...
... the preference is independent of those in Interface and Recording
preferences, which affect meters, sound activated recordings, time track,
and Plot Spectrum
2015-08-15 18:07:29 -04:00
Paul Licameli
5d2e877529 Scroll wheel with pointer in vertical ruler zooms in or out for wave track...
... regardless of the modifier keys; and does nothing in other tracks.
2015-08-14 20:34:06 -04:00
Paul Licameli
4cc064df8e Draw scrub speed like cursor or indicator: without a full refresh. 2015-08-13 19:49:09 -04:00
Paul Licameli
9ba6e03bd4 Reorganize code for drawing cursor and indicator, so it can generalize to...
... other things (like scrub speed)
2015-08-13 19:43:20 -04:00
Paul Licameli
5580aececc Untangle the control flow of mouse event handling in label tracks 2015-08-10 20:02:24 -04:00
Leland Lucius
300f0f05a0 Move TrackPanel keyboard handling out of AudacityProject...
...and into TrackPanel where it should be.
2015-08-09 18:26:29 -05:00
Paul Licameli
9a53625ceb Bug1134: Click and drag to move a track should make only one undo item 2015-08-08 18:55:31 -04:00
Paul Licameli
b0de2fa900 Show only the channel-related menu items appropriate to mono or stereo, and...
... Changed accelerators to avoid conflict:
for mono tracks, R&ight
for stereo tracks, Split Stereo to &Mono
2015-08-04 13:00:46 -04:00
Paul Licameli
eeaaadb530 Merge branch 'master'
* master:
  fewer #includes in TrackPanel.cpp
  Fix spacing on comment
  Add output gain control to Phaser effect
  Add output gain control to Wahwah effect
  Bug1115:  click below vertical ruler deselects track now, just as...
  Rename some variables
  Save overwrite choice in Export Multiple
2015-08-04 12:26:22 -04:00
Paul Licameli
db896e6511 Revert "Show only the appropriate channel-related track menu items for mono or stereo."
This reverts commit 7b737a99c7d0cb76c3b45137bce1d37a9f7d93f2.
2015-08-04 12:23:50 -04:00
Paul Licameli
971fd38615 Rename some variables 2015-08-03 13:50:49 -04:00
Paul Licameli
7b737a99c7 Show only the appropriate channel-related track menu items for mono or stereo. 2015-08-02 14:29:56 -04:00
Paul Licameli
d6b76e3589 Revert "Make a Channels sub-menu, and change accelerators to be more mnemonic..."
This reverts commit cc08bba27a8ae4c6d30387c13f35a8edd434e663.

Conflicts:
	src/TrackPanel.cpp
2015-08-02 13:27:22 -04:00
Paul Licameli
cc08bba27a Make a Channels sub-menu, and change accelerators to be more mnemonic...
... Also removes the conflict at top menu level over M accelerator.

Make one Channel sub-menu for mono and one for stereo, and swap correct one
in, whenever the parent menu opens.
2015-08-01 13:38:12 -04:00
Leland Lucius
7877615454 Move label context menu handling to label track
Application key now brings up the context menu while editing labels
as it should.  This wasn't possible with the old keyboard handling.
2015-07-30 10:38:03 -05:00
Paul Licameli
fdf0759301 Bug1075, and define and use new event type for TrackPanel timer ticks...
... Thus allowing TrackPanel.cpp to work without including Lyrics headers.
Also eliminates some of its direct notification of MixerBoard.
2015-07-28 11:56:00 -04:00
Paul Licameli
4f0a2ee804 Bugs 1059, 1077: don't edit cut lines during play; show correct cursor...
... Don't show the arrow when in fact the click at the bottom of the track
will resize.
2015-07-28 11:55:59 -04:00
Paul Licameli
912cdb6c53 (most of) Bug 1077: Resizing cursor correctly appears, except...
... we still see an incorrect arrow cursor where the cutline meets the bottom
of the track.
2015-07-28 11:55:57 -04:00
Paul Licameli
7bba4500c4 Move mdBr from TrackPanel to ViewInfo, no more lookup of prefs in Envelope.cpp 2015-07-28 11:53:01 -04:00
Paul Licameli
edba89d704 Pass tooltips by wxString, not const wxChar* 2015-07-28 11:49:56 -04:00