1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-15 17:11:20 +01:00
Commit Graph

716 Commits

Author SHA1 Message Date
Paul Licameli
1033095696 RAII for locking of WaveTracks 2016-04-12 00:55:59 -04:00
tip2tail
6686d0e314 Introduce further enhancement of the Timer Recording process:
* Disk space warning if the recording potentially will not fit in disk space available.
* ProgressDialog enhancements that allow the Stop/Cancel button to be confirmed and the elapsed time to be hidden.
* Messages enhanced to clearly show the actions being taken.
2016-04-09 14:23:28 +01:00
Paul Licameli
0ebc23e3a9 Another compilation fix in EXPERIMENTAL_SCOREALIGN, and one less delete 2016-04-08 21:50:15 -04:00
Paul Licameli
cea79d5b73 Bug1282: change of enabled state of Stereo To Mono should be persistent 2016-04-05 18:43:43 -04:00
Paul Licameli
8ae361d415 Fix some of the compilation breakage in EXPERIMENTAL_SCOREALIGN...
... But some of the header files and functions just don't exist any more.
2016-04-02 15:46:56 -04:00
James Crook
7429848573 Merge remote-tracking branch 'myoung/FurtherTRImprovements' 2016-04-01 10:26:56 +01:00
tip2tail
4956ce3e68 Changes as per James's advice, allow Timer Recording to be used when project is empty if user has disabled warnings in prefs. Also resolved a further message whitespace issue. 2016-03-31 22:26:26 +01:00
Paul Licameli
13595620cf Fix mac build 2016-03-30 23:24:39 -04:00
tip2tail
aa5ffe99a7 Timer Recording Enhancements to allow Automatic Save and Export after
recording.  Also allows for additional options to be carried out after a
successful timer recording such as Exit, Retsrat and Shutdown.
2016-03-30 20:42:59 +01:00
Steve Daulton
484f23dcc7 Fix for bug 814 2016-03-28 21:07:25 +01:00
Paul Licameli
a6ca36cdab TrackList holds smart pointers to tracks, Add() only takes rvalue refs to such 2016-03-26 15:41:31 -04:00
Paul Licameli
7d1ea7b82e Use a static unique_ptr for the global clipboard 2016-03-26 15:41:30 -04:00
Paul Licameli
824ff647f8 Import functions return containers of smart pointers to new tracks 2016-03-26 15:41:27 -04:00
Paul Licameli
bc5519a0e2 TrackList::Remove and TrackListIterator::RemoveCurrent always delete the track 2016-03-26 15:41:26 -04:00
Paul Licameli
81c2cc950f Rewrite the sorting of tracks 2016-03-26 15:41:24 -04:00
Paul Licameli
c4fc7e2bf0 MixAndRender returns unique_ptr results (in a std::pair) 2016-03-26 11:50:14 -04:00
Paul Licameli
3015a9c8d9 Track cut and copy functions return a unique_ptr argument...
... Because they are factory functions.
2016-03-26 11:50:13 -04:00
Paul Licameli
5ef4dd46a5 TrackFactory functions return std::unique_ptr, although some callers...
... release() them for now.
2016-03-26 11:50:12 -04:00
Paul Licameli
5162ab5c5b Use TrackFactory in more places...
... There should now be no direct allocation of Track subclasses with new,
except in those classes' own methods
2016-03-26 11:50:09 -04:00
Paul Licameli
7ed4c050cb Fix unused argument warning 2016-03-15 00:09:36 -04:00
Paul Licameli
4cf9e0e6d6 Bug1354: Importing MIDI via Import Audio... and list-of-files should undo...
... also fixes a possible memory leak in direct Import MIDI... along the
failure path.
2016-03-14 11:02:09 -04:00
Paul Licameli
48a5f55179 More const qualifiers, for copying of tracks, and replacing in lists of tracks
... (the tracks may be const, not the list, when replacing)
2016-02-27 17:30:30 -05:00
Paul Licameli
60bcd7aea2 Fix warnings for unused variables and functions 2016-02-26 14:56:26 -05:00
Paul Licameli
990080ae7d Replace virtual with override wherever possible; eliminate needless virtual...
... for functions in final classes.

override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.

There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
88eeebcb8b Undoing and redoing of Tags...
Use reference counting (in std::shared_ptr) to avoid replicating Tags with each
Undo state.
2016-02-24 19:25:39 -05:00
Paul Licameli
e12a060751 Define UndoState 2016-02-24 19:10:40 -05:00
Paul Licameli
73ced7b93f Remove UndoManager.h from other headers 2016-02-24 19:10:34 -05:00
Paul Licameli
0c182c3c0b Shrink the command functor objects by using more subclasses...
... Let virtual function dispatch do the work, don't write our own dispatch!
2016-02-24 15:17:06 -05:00
Paul Licameli
cf3daebff6 Reviewed allocations of wxMenuBar items. 2016-02-20 20:23:54 -05:00
Paul Licameli
e0c88b1e53 Remove needless indirection for more little structures, in CommandManager...
... Also use std::shared_ptr for functors to simplify resource management
2016-02-18 20:19:27 -05:00
Paul Licameli
dbaa811577 Stack-allocate where possible! ...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
df6a7c5464 More uses of safenew for classes we derive from wxWindow classes...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli
7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343 "delete"->"DELETE" in comments, easier to find remaining naked operator delete 2016-02-14 18:50:45 -05:00
Steve Daulton
76403ba5f9 Fix residual issue for bug 1313 2016-01-30 15:45:35 +00:00
Steve Daulton
d6b8080a5d Fix for bug 1313 2016-01-29 22:12:41 +00:00
Paul Licameli
074d0daf3d Revert "Bug1299: Shouldn't lose track focus after applying a chain."
This reverts commit a44ff801a6.
2016-01-27 14:55:49 -05:00
Paul Licameli
a44ff801a6 Bug1299: Shouldn't lose track focus after applying a chain. 2016-01-26 20:49:59 -05:00
Paul Licameli
2550a59c0e Bug1282: Hide "Stereo to Mono" from menu when disabled by plugin manager...
... so you can't crash by selecting it!
2016-01-26 19:38:04 -05:00
Paul Licameli
17c9369286 Bug1239: Correct time rulers after importing files (with File>Open) ...
... The fisheye stuff was to blame.
2016-01-26 18:09:29 -05:00
Paul Licameli
4d2f4bbd69 Buig1307: Misbehavior posting mono into stereo 2016-01-23 18:27:43 -05:00
Paul Licameli
39399d6d8c Bug30: Safer fix avoids crashes! 2016-01-23 11:35:37 -05:00
Paul Licameli
116ea61d11 Bug30: During playback, after CTRL+M, chars, ENTER -- restore track focus. 2016-01-21 10:18:41 -05:00
Steve Daulton
34f141e956 Align clips from Split New to sample times 2016-01-21 03:10:26 +00:00
Steve Daulton
1d6d08c47d Don't push effects that can't be undone onto the Undo Stack 2016-01-21 02:07:28 +00:00
James Crook
eece31e1d4 Manage... -> Add / Remove Plug-ins...
Wording change requested and discussed in http://bugzilla.audacityteam.org/show_bug.cgi?id=1018
2015-09-05 11:24:14 +01:00
Paul Licameli
1278b9644a Uniform naming of symbols in Experimental.h 2015-08-31 17:55:56 -04:00
Paul Licameli
01fe404a02 Move track permuting details out of TrackPanel.cpp 2015-08-29 13:46:35 -04:00
Paul Licameli
f49dbae9e2 Move minimize and close details out of TrackPanel.cpp 2015-08-29 13:46:26 -04:00