Paul Licameli
d68db39b5c
HelpSystem.cpp has fewer dependencies...
...
... There was no reason to store the help location preferences as per-project
state. Also move the dialog for quick fixes near its only use in
HelpMenus.cpp.
This takes 22 files out of the big strongly connected component, notably
the much used lower level utilities, ErrorDialog and AudacityException.
HelpSystem itself is still in a small cycle with LinkingHtmlWindow.
2019-05-18 20:29:25 -04:00
Paul Licameli
db8c4c5e5a
Global keyboard capture handling into new files, better comments...
...
... and break its compile dependency on CommandManager.h by letting it install
callbacks.
This also removes Objective-C mixed code from CommmandManager.
This also eliminates four inclusions of Project.h!
Capture handler state is also global, not per project, though the
CommandManager's callbacks still do depend on the active project.
2019-05-18 15:14:18 -04:00
Paul Licameli
8da6529329
Remove AudacityApp::GetLogger() & HelpActions::DoShowLog()
2019-05-17 16:29:04 -04:00
Paul Licameli
a047fa6e7a
Missing alias file tracking out of AudacityApp, into new files...
...
... which reduces the need for including AudacityApp.h
2019-05-17 16:28:50 -04:00
Paul Licameli
0ab29d21e9
Some naming consistency...
...
Prefer "MissingAliasFiles" not other permutations of the words
2019-05-17 06:47:53 -04:00
Paul Licameli
2d8c287384
Do not require AudacityApp.h when using global file history
2019-05-17 06:47:53 -04:00
David Bailes
ca13f08ff8
Grid accessibility: incorrect focus can be read
...
Problem: this affects NVDA and Narrator, but not Jaws. If a user moves to the Delete button and presses it to delete a label, a label is incorrectly read as the new focus - the focus remains on the Delete button.
GridAx::SetCurrentCell() can be called when the Grid is not the focus, and send a focus event.
Fix: In GridAx::SetCurrentCell() only send an focus event if the Grid is the focus.
2019-05-17 11:06:49 +01:00
David Bailes
6da84b0adc
Keyboard prefs accessibility: Narrator can misread the radio buttons.
...
Problem. If an item in the list is selected, then if a different view by radio button is selected, Narrator reads the selected item rather than the radio button.
KeyViewAx::SetCurrentLine(int line) can be called when the KeyView is not the focus, and send a focus event.
Fix: In KeyViewAx::SetCurrentLine(int line), only send focus event if the KeyView is the focus.
2019-05-17 08:33:33 +01:00
Paul Licameli
ddaadfb7e7
Remove NumericTextCtrl.h from other headers or comment why you can't
2019-05-16 19:01:00 -04:00
Paul Licameli
ced9be588b
Remove ImageRoll.h from other headers or comment why you can't
2019-05-16 18:30:22 -04:00
Paul Licameli
6c57948d8f
Remove unnecessary #include-s from .cpp files...
...
... Unnecessary because transitively included.
But each .cpp file still includes its own .h file near the top to ensure
that it compiles indenendently, even if it is reincluded transitively later.
2019-05-16 17:21:00 -04:00
Paul Licameli
548192fcf3
Remove redundant #include-s from .h files...
...
Redundant, because transitively implied. But don't do this for inclusions of
Audacity.h or Experimental.h.
2019-05-16 14:58:34 -04:00
Paul Licameli
56f51d8176
Revert "Remove redundant #include-s from .h files..."
...
This reverts commit b7fe62d170
.
2019-05-16 14:33:55 -04:00
Paul Licameli
b7fe62d170
Remove redundant #include-s from .h files...
...
Redundant, because transitively implied. But don't do this for inclusions of
Audacity.h or Experimental.h.
2019-05-16 14:15:05 -04:00
Paul Licameli
9bf29f5582
CommandManager keys by CommandId, not plain wxString
2019-05-16 12:30:29 -04:00
Paul Licameli
11c8377460
NormalizedKeyString redefined as TaggedIdentifier
2019-05-16 12:30:29 -04:00
Paul Licameli
f6adeed47b
Remove some unnecessary #include directives
2019-05-15 14:14:18 -04:00
Paul Licameli
2b32884596
Remove some unnecessary toolbar related declarations, fix comments
2019-04-23 17:02:04 -04:00
Steve Daulton
aad117051a
Fix bug 1534
...
On Linux, width and height of TipPanel must not be reset in SetPos().
2019-04-23 19:31:55 +01:00
David Bailes
78cb554883
2092: Linux: first typed char lost when using dialog for label name
...
Fix: Move the insertion point to the end of the text after the dialog is shown.
2019-04-13 12:38:41 +01:00
Paul Licameli
ba467b3632
some override
2019-04-04 12:35:17 -04:00
Paul Licameli
0c39c1292e
Remove wx/dc.h from ImageRoll.h ...
...
... I wish I could just forward-declare the enumeration wxRasterOperationMode,
but it's not defined as a sized enum
2019-04-04 11:00:43 -04:00
Paul Licameli
5f218a4ab4
Revert "Remove wx/dc.h from ImageRoll.h ..."
...
This reverts commit 8078aa8547
.
2019-04-04 10:52:31 -04:00
Paul Licameli
8078aa8547
Remove wx/dc.h from ImageRoll.h ...
...
... I wish I could just forward-declare the enumeration wxRasterOperationMode,
but it's not defined as a sized enum
2019-04-04 10:40:02 -04:00
David Bailes
c531fde6b8
ASlider.cpp: correction to event table
...
Fix error in ASlider's event table spotted by Paul. The error wasn't causing any known problems.
2019-04-04 15:19:07 +01:00
Paul Licameli
2e1fe80601
Remove or comment wxPanelWrapper.h in headers
2019-04-04 10:13:23 -04:00
David Bailes
95e2264d24
Bug 1248: Tab does not navigate out of ASlider if clicked
...
Problem:
If an ASlider in the main window is clicked, then you can't TAB away from the control.
Fix:
Keyboard shortcuts are handled using key down events. However, ASlider was handling char events for reasons unknown. I'm unsure why this was causing a problem, but changing ASlider to handle key down events fixes the bug.
2019-04-03 13:25:04 +01:00
David Bailes
ecdb6d0a07
Fix previous commit: 4e37d93
...
Reinstated .h file, with corrected path. Without this include, there were numerous intellisense errors in the .cpp file.
2019-04-03 12:54:52 +01:00
David Bailes
4e37d93cd9
ASlider.h removed unnecessary .h file with incorrect path
2019-04-03 12:23:45 +01:00
Paul Licameli
0f3723e221
comment BackedPanel.h, HtmlWindow.h, ASlider.h in .h files
2019-03-31 15:25:34 -04:00
Paul Licameli
2d8abe6b74
Remove FileHistory.h, KeyView.h from .h files
2019-03-31 15:21:02 -04:00
Paul Licameli
a10196eb91
Fix some comments
2019-03-31 15:14:26 -04:00
Paul Licameli
e2c5444c1d
Move class HtmlTextHelpDialog out of header
2019-03-31 14:58:33 -04:00
Paul Licameli
b83ed90cfb
Remove or comment Ruler.h, Overlay.h, OverlayPanel.h in other headers
2019-03-31 14:44:24 -04:00
Paul Licameli
ed29ab89f8
Many WindowAccessible subclasses moved out of header files
2019-03-31 13:27:18 -04:00
Paul Licameli
10568f8a46
Move class SliderAx into WindowAccessible.* ...
...
... so ScienFilter.cpp doesn't depend on Equalization.h
2019-03-31 13:27:18 -04:00
Paul Licameli
4714d72b3f
Can't remove remaining wx headers from other headers, comment that
2019-03-31 01:41:16 -04:00
Paul Licameli
ef98cfd74f
Remove wx/{docview,datetime,datectrl,cursor}.h from *.h
2019-03-30 13:32:44 -04:00
Paul Licameli
77f747daeb
Remove wx/{checklst,wfstream,version,variant,types}.h from *.h
2019-03-30 12:59:21 -04:00
Paul Licameli
34f318cd41
Remove wx/{imaglist,generic/dragimgg,gauge,dynarray}.h from *.h
2019-03-30 12:51:12 -04:00
Paul Licameli
2587a4adba
Remove wx/panel.h from headers
2019-03-30 12:26:59 -04:00
Paul Licameli
2e05d2d884
Remove wx/{radiobut,ownerdrw,menuitem,menu,listbox}.h from *.h
2019-03-30 12:15:53 -04:00
Paul Licameli
d28ae40399
Remove wx/dialog.h from headers
2019-03-30 12:01:39 -04:00
Paul Licameli
4d29686116
Remove wx/gdicmn.h from headers
2019-03-30 11:52:48 -04:00
Paul Licameli
c982cf6a41
Remove wx/intl.h, wx/brush.h, wx/bitmap.h from headers
2019-03-30 11:45:20 -04:00
Paul Licameli
870c08ac06
Remove wx/{log.h, image.h, listctrl.h, utils.h} from headers
2019-03-30 11:21:51 -04:00
Paul Licameli
08c16b6eb7
Remove wx/{html/htmlwin,fileconf,dragimag,debug,dcclient}.h from *.h
2019-03-30 10:53:22 -04:00
Paul Licameli
ec2f26e48c
Remove wx/pen.h, wx/thread.h from headers
2019-03-30 10:17:18 -04:00
Paul Licameli
3a7324984c
wx/hashmap.h no longer used anywhere
2019-03-30 10:06:52 -04:00
Paul Licameli
de60edc62f
Remove wx/{app,statbmp,spinctrl,scrolbar,dynlib,dcmemory}.h from *.h
2019-03-30 07:57:37 -04:00