From fab756562ef7b6a9243b5e3cd602019f01512aea Mon Sep 17 00:00:00 2001
From: Paul Licameli <paul.licameli@audacityteam.org>
Date: Thu, 1 Feb 2018 18:57:47 -0500
Subject: [PATCH] Use AddSlider arguments, not SetRange()

---
 src/effects/NoiseReduction.cpp |  4 ++--
 src/effects/NoiseRemoval.cpp   | 16 ++++++++--------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/effects/NoiseReduction.cpp b/src/effects/NoiseReduction.cpp
index f685950cd..923be8829 100644
--- a/src/effects/NoiseReduction.cpp
+++ b/src/effects/NoiseReduction.cpp
@@ -1437,9 +1437,9 @@ struct ControlInfo {
       text->SetValidator(vld2);
 
       wxSlider *const slider =
-         S.Id(id).AddSlider( {}, 0, sliderMax);
+         S.Id(id)
+            .AddSlider( {}, 0, sliderMax);
       slider->SetName(sliderName());
-      slider->SetRange(0, sliderMax);
       slider->SetSizeHints(150, -1);
    }
 
diff --git a/src/effects/NoiseRemoval.cpp b/src/effects/NoiseRemoval.cpp
index 328e33b0b..350a94b42 100644
--- a/src/effects/NoiseRemoval.cpp
+++ b/src/effects/NoiseRemoval.cpp
@@ -721,9 +721,9 @@ void NoiseRemovalDialog::PopulateOrExchange(ShuttleGui & S)
          mGainT = S.Id(ID_GAIN_TEXT).AddTextBox(_("Noise re&duction (dB):"), wxT(""), 0);
          S.SetStyle(wxSL_HORIZONTAL);
          mGainT->SetValidator(vld);
-         mGainS = S.Id(ID_GAIN_SLIDER).AddSlider(wxT(""), 0, GAIN_MAX);
+         mGainS = S.Id(ID_GAIN_SLIDER)
+            .AddSlider(wxT(""), 0, GAIN_MAX, GAIN_MIN);
          mGainS->SetName(_("Noise reduction"));
-         mGainS->SetRange(GAIN_MIN, GAIN_MAX);
          mGainS->SetSizeHints(150, -1);
 
          mSensitivityT = S.Id(ID_SENSITIVITY_TEXT).AddTextBox(_("&Sensitivity (dB):"),
@@ -731,9 +731,9 @@ void NoiseRemovalDialog::PopulateOrExchange(ShuttleGui & S)
                                                 0);
          S.SetStyle(wxSL_HORIZONTAL);
          mSensitivityT->SetValidator(vld);
-         mSensitivityS = S.Id(ID_SENSITIVITY_SLIDER).AddSlider(wxT(""), 0, SENSITIVITY_MAX);
+         mSensitivityS = S.Id(ID_SENSITIVITY_SLIDER)
+            .AddSlider(wxT(""), 0, SENSITIVITY_MAX, SENSITIVITY_MIN);
          mSensitivityS->SetName(_("Sensitivity"));
-         mSensitivityS->SetRange(SENSITIVITY_MIN, SENSITIVITY_MAX);
          mSensitivityS->SetSizeHints(150, -1);
 
          mFreqT = S.Id(ID_FREQ_TEXT).AddTextBox(_("Fr&equency smoothing (Hz):"),
@@ -741,9 +741,9 @@ void NoiseRemovalDialog::PopulateOrExchange(ShuttleGui & S)
                                                 0);
          S.SetStyle(wxSL_HORIZONTAL);
          mFreqT->SetValidator(vld);
-         mFreqS = S.Id(ID_FREQ_SLIDER).AddSlider(wxT(""), 0, FREQ_MAX);
+         mFreqS = S.Id(ID_FREQ_SLIDER)
+            .AddSlider(wxT(""), 0, FREQ_MAX, FREQ_MIN);
          mFreqS->SetName(_("Frequency smoothing"));
-         mFreqS->SetRange(FREQ_MIN, FREQ_MAX);
          mFreqS->SetSizeHints(150, -1);
 
          mTimeT = S.Id(ID_TIME_TEXT).AddTextBox(_("Attac&k/decay time (secs):"),
@@ -751,9 +751,9 @@ void NoiseRemovalDialog::PopulateOrExchange(ShuttleGui & S)
                                                 0);
          S.SetStyle(wxSL_HORIZONTAL);
          mTimeT->SetValidator(vld);
-         mTimeS = S.Id(ID_TIME_SLIDER).AddSlider(wxT(""), 0, TIME_MAX);
+         mTimeS = S.Id(ID_TIME_SLIDER)
+            .AddSlider(wxT(""), 0, TIME_MAX, TIME_MIN);
          mTimeS->SetName(_("Attack/decay time"));
-         mTimeS->SetRange(TIME_MIN, TIME_MAX);
          mTimeS->SetSizeHints(150, -1);
 
          S.AddPrompt(_("Noise:"));