Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-09-24 16:01:16 +02:00
Code Issues Releases Wiki Activity

Remember Start/Center setting on SelectionToolbar

Browse Source 
I mistakenly had it always set to ShowStart = true
Also tidied up a hastily written comment.
This commit is contained in:
James Crook 2017-05-09 13:24:55 +01:00
parent 52509d4bbd
commit f859bf62c7
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/toolbars/SelectionBar.cpp
View File

@ -196,8 +196,8 @@ void SelectionBar::Populate()
bool showSelectionStart = false; bool showSelectionStart = false;
bool showSelectionLength = false; bool showSelectionLength = false;
gPrefs->Read(wxT("/ShowSelectionStart"), &showSelectionStart); gPrefs->Read(wxT("/ShowSelectionStart"), &showSelectionStart, true);
gPrefs->Read(wxT("/ShowSelectionLength"), &showSelectionLength); gPrefs->Read(wxT("/ShowSelectionLength"), &showSelectionLength, false);
{ {
auto hSizer = std::make_unique<wxBoxSizer>(wxHORIZONTAL); auto hSizer = std::make_unique<wxBoxSizer>(wxHORIZONTAL);
@ -446,7 +446,7 @@ void SelectionBar::OnStartRadio(wxCommandEvent & WXUNUSED(event))
} }
void SelectionBar::OnCenterRadio(wxCommandEvent & WXUNUSED(event)) void SelectionBar::OnCenterRadio(wxCommandEvent & WXUNUSED(event))
{ {
gPrefs->Write(wxT("/ShowSelectionStart"), true); gPrefs->Write(wxT("/ShowSelectionStart"), false);
gPrefs->Flush(); gPrefs->Flush();
mLeftTime->SetName(wxString(_("Selection Center"))); mLeftTime->SetName(wxString(_("Selection Center")));
@ -541,10 +541,12 @@ void SelectionBar::ValuesToControls()
samples += (sampleCount)floor(mStart * mRate + 0.5); samples += (sampleCount)floor(mStart * mRate + 0.5);
auto t = samples.as_double() / mRate; auto t = samples.as_double() / mRate;
// An odd thing here is that we could allow the center to be at half a sample. // An odd thing here is that we could allow the center to be at half a sample.
// in which case length must be odd, or at a sample, in which case length // If center is at a half sample length must be odd.
// must be even. Same fo rany selection granularity. // If center is at a sample length must be even.
// For now, don't care. User gets benefit from having center, even if // Similarly for any selection granularity.
// it is slightly peculiar when used close up to the granularity. // For now, we don't care, and don't do anything to ensure that.
// The user gets the benefit from having the option of center, even if
// it is slightly peculiar in its interactions with selection granularity.
left = t/2.0; left = t/2.0;
} }