PopupMenuTable ctor requires an identifier

src/tracks/labeltrack/ui/LabelTrackControls.cpp

@@ -37,7 +37,9 @@ std::vector<UIHandlePtr> LabelTrackControls::HitTest
 
 class LabelTrackMenuTable : public PopupMenuTable
 {
-   LabelTrackMenuTable() : mpData(NULL) {}
+   LabelTrackMenuTable()
+      : PopupMenuTable{ "LabelTrack" }
+   {}
    DECLARE_POPUP_MENU(LabelTrackMenuTable);
 
 public:
@@ -53,7 +55,7 @@ public:
       mpData = nullptr;
    }
 
-   CommonTrackControls::InitMenuData *mpData;
+   CommonTrackControls::InitMenuData *mpData{};
 
    void OnSetFont(wxCommandEvent &);
 };

src/tracks/playabletrack/notetrack/ui/NoteTrackControls.cpp

@@ -78,7 +78,9 @@ std::vector<UIHandlePtr> NoteTrackControls::HitTest
 
 class NoteTrackMenuTable : public PopupMenuTable
 {
-   NoteTrackMenuTable() : mpData(NULL) {}
+   NoteTrackMenuTable()
+      : PopupMenuTable{ "NoteTrack" }
+   {}
    DECLARE_POPUP_MENU(NoteTrackMenuTable);
 
 public:
@@ -95,7 +97,7 @@ private:
       mpData = nullptr;
    }
 
-   NoteTrackControlsBase::InitMenuData *mpData;
+   NoteTrackControlsBase::InitMenuData *mpData{};
 
    void OnChangeOctave(wxCommandEvent &);
 };

src/tracks/playabletrack/notetrack/ui/NoteTrackVZoomHandle.cpp

@@ -167,7 +167,9 @@ enum {
 
 class NoteTrackVRulerMenuTable : public PopupMenuTable
 {
-   NoteTrackVRulerMenuTable(){};
+   NoteTrackVRulerMenuTable()
+      : PopupMenuTable{ "NoteTrackVRuler" }
+   {};
    virtual ~NoteTrackVRulerMenuTable() {}
    DECLARE_POPUP_MENU(NoteTrackVRulerMenuTable);
 

src/tracks/playabletrack/wavetrack/ui/SpectrumVZoomHandle.h

@@ -75,7 +75,9 @@ private:
 
 class SpectrumVRulerMenuTable : public WaveTrackVRulerMenuTable
 {
-   SpectrumVRulerMenuTable() : WaveTrackVRulerMenuTable() {}
+   SpectrumVRulerMenuTable()
+      : WaveTrackVRulerMenuTable{ "SpectrumVRuler" }
+   {}
    virtual ~SpectrumVRulerMenuTable() {}
    DECLARE_POPUP_MENU(SpectrumVRulerMenuTable);
 

src/tracks/playabletrack/wavetrack/ui/WaveTrackControls.cpp

@@ -153,7 +153,7 @@ enum {
 class WaveColorMenuTable : public PopupMenuTable
 {
    WaveColorMenuTable()
-      : PopupMenuTable( XO("&Wave Color") )
+      : PopupMenuTable( "WaveColor", XO("&Wave Color") )
    {}
    DECLARE_POPUP_MENU(WaveColorMenuTable);
 
@@ -252,7 +252,7 @@ void WaveColorMenuTable::OnWaveColorChange(wxCommandEvent & event)
 class FormatMenuTable : public PopupMenuTable
 {
    FormatMenuTable()
-      : PopupMenuTable{ XO("&Format") }
+      : PopupMenuTable{ "SampleFormat", XO("&Format") }
    {}
    DECLARE_POPUP_MENU(FormatMenuTable);
 
@@ -375,7 +375,7 @@ void FormatMenuTable::OnFormatChange(wxCommandEvent & event)
 class RateMenuTable : public PopupMenuTable
 {
    RateMenuTable()
-      : PopupMenuTable{ XO("Rat&e") }
+      : PopupMenuTable{ "SampleRate", XO("Rat&e") }
    {}
    DECLARE_POPUP_MENU(RateMenuTable);
 
@@ -577,10 +577,12 @@ class WaveTrackMenuTable : public PopupMenuTable
 {
 public:
    static WaveTrackMenuTable &Instance( Track * pTrack);
-   Track * mpTrack;
+   Track * mpTrack{};
 
 protected:
-   WaveTrackMenuTable() : mpData(NULL) {mpTrack=NULL;}
+   WaveTrackMenuTable()
+      : PopupMenuTable{ "WaveTrack" }
+   {}
 
    void InitUserData(void *pUserData) override;
    void InitMenu(wxMenu *pMenu) override;
@@ -592,7 +594,7 @@ protected:
 
    DECLARE_POPUP_MENU(WaveTrackMenuTable);
 
-   PlayableTrackControls::InitMenuData *mpData;
+   PlayableTrackControls::InitMenuData *mpData{};
 
    void OnMultiView(wxCommandEvent & event);
    void OnSetDisplay(wxCommandEvent & event);

src/tracks/playabletrack/wavetrack/ui/WaveTrackVZoomHandle.h

@@ -68,7 +68,9 @@ public:
    };
 
 protected:
-   WaveTrackVRulerMenuTable() {}
+   WaveTrackVRulerMenuTable( const Identifier &id )
+      : PopupMenuTable{ id }
+   {}
 
    void InitUserData(void *pUserData) override;
 

src/tracks/playabletrack/wavetrack/ui/WaveformVZoomHandle.h

@@ -75,7 +75,9 @@ private:
 
 class WaveformVRulerMenuTable : public WaveTrackVRulerMenuTable
 {
-   WaveformVRulerMenuTable() : WaveTrackVRulerMenuTable() {}
+   WaveformVRulerMenuTable()
+      : WaveTrackVRulerMenuTable{ "WaveFormVRuler" }
+   {}
    virtual ~WaveformVRulerMenuTable() {}
    DECLARE_POPUP_MENU(WaveformVRulerMenuTable);
 

src/tracks/timetrack/ui/TimeTrackControls.cpp

@@ -40,7 +40,9 @@ enum
 
 class TimeTrackMenuTable : public PopupMenuTable
 {
-   TimeTrackMenuTable() : mpData(NULL) {}
+   TimeTrackMenuTable()
+      : PopupMenuTable{ "TimeTrack" }
+   {}
    DECLARE_POPUP_MENU(TimeTrackMenuTable);
 
 public:
@@ -68,7 +70,7 @@ private:
       mpData = nullptr;
    }
 
-   CommonTrackControls::InitMenuData *mpData;
+   CommonTrackControls::InitMenuData *mpData{};
 
    void OnSetTimeTrackRange(wxCommandEvent & /*event*/);
    void OnTimeTrackLin(wxCommandEvent & /*event*/);

src/tracks/ui/CommonTrackControls.cpp

@@ -80,7 +80,9 @@ enum
 
 class TrackMenuTable : public PopupMenuTable
 {
-   TrackMenuTable() : mpData(NULL) {}
+   TrackMenuTable()
+      : PopupMenuTable{ "Track" }
+   {}
    DECLARE_POPUP_MENU(TrackMenuTable);
 
 public:
@@ -98,7 +100,7 @@ private:
       mpData = nullptr;
    }
 
-   CommonTrackControls::InitMenuData *mpData;
+   CommonTrackControls::InitMenuData *mpData{};
 };
 
 TrackMenuTable &TrackMenuTable::Instance()

src/widgets/PopupMenuTable.h

@@ -58,7 +58,7 @@ public:
    using Entry = PopupMenuTableEntry;
 
    // Supply a nonempty caption for sub-menu tables
-   PopupMenuTable( const TranslatableString &caption = {} )
+   PopupMenuTable( const Identifier &id, const TranslatableString &caption = {} )
       : mCaption{ caption }
    {}