1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-04 14:39:08 +02:00

Further fixes based on Peter's feedback.

This commit is contained in:
Leland Lucius 2015-04-25 11:23:00 -05:00
parent 63dd4470f1
commit f3f7dca595

View File

@ -136,8 +136,6 @@ bool EffectChangePitch::SetAutomationParameters(EffectAutomationParameters & par
m_dPercentChange = Percentage; m_dPercentChange = Percentage;
m_dSemitonesChange = (12.0 * log((100.0 + m_dPercentChange) / 100.0)) / log(2.0);
return true; return true;
} }
@ -307,13 +305,18 @@ bool EffectChangePitch::TransferDataToWindow()
return false; return false;
} }
// from/to pitch controls Calc_SemitonesChange_fromPercentChange();
m_pChoice_FromPitch->SetSelection(m_nFromPitch); Calc_ToPitch(); // Call *after* m_dSemitonesChange is updated.
m_pSpin_FromOctave->SetValue(m_nFromOctave); Calc_ToFrequency();
Update_Choice_ToPitch(); Calc_ToOctave(); // Call after Calc_ToFrequency().
Update_Spin_ToOctave();
// percent change controls Update_Choice_FromPitch();
Update_Choice_ToPitch();
Update_Spin_FromOctave();
Update_Spin_ToOctave();
Update_Text_SemitonesChange();
Update_Text_ToFrequency();
Update_Text_PercentChange();
Update_Slider_PercentChange(); Update_Slider_PercentChange();
m_bLoopDetect = false; m_bLoopDetect = false;
@ -743,7 +746,6 @@ void EffectChangePitch::Update_Text_ToFrequency()
m_pTextCtrl_ToFrequency->GetValidator()->TransferToWindow(); m_pTextCtrl_ToFrequency->GetValidator()->TransferToWindow();
} }
void EffectChangePitch::Update_Text_PercentChange() void EffectChangePitch::Update_Text_PercentChange()
{ {
m_pTextCtrl_PercentChange->GetValidator()->TransferToWindow(); m_pTextCtrl_PercentChange->GetValidator()->TransferToWindow();