Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-17 09:07:41 +02:00
Code Issues Releases Wiki Activity

Probable fix for bug 655, file-open failure - solution found by Leland. I'm committing the change and adding comments. A FIXME is now a TODO (i.e. not signalling broken, just a would-be-nice).

Browse Source
This commit is contained in:
james.k.crook@gmail.com 2013-09-29 11:52:02 +00:00
parent e8ee6393b8
commit f2c3327058
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/AudacityApp.cpp
View File

@ -744,7 +744,12 @@ void AudacityApp::OnMacOpenFile(wxCommandEvent & event)
while (ofqueue.GetCount()) { while (ofqueue.GetCount()) {
wxString name(ofqueue[0]); wxString name(ofqueue[0]);
ofqueue.RemoveAt(0); ofqueue.RemoveAt(0);
wxASSERT(MRUOpen(name)); // FIXME: Check the return result? Meantime, assert it so failure shows in debug build. // TODO: Handle failures better.
// Some failures are OK, e.g. file not found, just would-be-nices to do better,
// so FAIL_MSG is more a case of an enhancement request than an actual problem.
if( !MRUOpen(name)){
wxFAIL_MSG(wxT("MRUOpen failed") );
}
} }
} }
#endif //__WXMAC__ #endif //__WXMAC__
@ -783,6 +788,10 @@ BEGIN_EVENT_TABLE(AudacityApp, wxApp)
END_EVENT_TABLE() END_EVENT_TABLE()
// backend for OnMRUFile // backend for OnMRUFile
// TODO: Would be nice to make this handle not opening a file with more panache.
// - Actually remove unfound files from the MRU list.
// - Inform the user if DefaultOpenPath not set.
// - Switch focus to correct instance of project window, if already open.
bool AudacityApp::MRUOpen(wxString fullPathStr) { bool AudacityApp::MRUOpen(wxString fullPathStr) {
// Most of the checks below are copied from AudacityProject::OpenFiles. // Most of the checks below are copied from AudacityProject::OpenFiles.
// - some rationalisation might be possible. // - some rationalisation might be possible.