Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-08-09 00:21:16 +02:00
Code Issues Releases Wiki Activity

Bug1603, speculative fix: AUNBandEQ crashes Audacity...

Browse Source 
... I can't reproduce the symptoms on my Mac, but the stack trace supplied by
Gale shows an infinite recursion overflowing the stack.

I see that at commit d1f66d768ffd3823757d2746388074eca95ec138 "Updates for wx3"
by Leland, he saw the need to set a guard against infinite recursion in another
window resizing callback.  He tested that guard, but did not set it, in two
other places.  I speculate that the cycle can be entered from those other
places, bypassing where the guard was set.  So I set the guard in more places.
This commit is contained in:
Paul Licameli 2017-07-22 22:50:16 -04:00
parent f4c3f19dd1
commit f1aa9161f0
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/effects/audiounits/AUControl.mm
View File

@ -199,7 +199,7 @@ void AUControl::OnSize(wxSizeEvent & evt)
{ {
return; return;
} }
mSettingSize = true; auto vr = valueRestorer( mSettingSize, true );
wxSize sz = GetSize(); wxSize sz = GetSize();
@ -250,8 +250,6 @@ void AUControl::OnSize(wxSizeEvent & evt)
} }
#endif #endif
mSettingSize = false;
return; return;
} }
@ -418,6 +416,7 @@ void AUControl::CocoaViewResized()
{ {
return; return;
} }
auto vr = valueRestorer( mSettingSize, true );
NSSize viewSize = [mView frame].size; NSSize viewSize = [mView frame].size;
NSSize frameSize = [mAUView frame].size; NSSize frameSize = [mAUView frame].size;
@ -624,6 +623,7 @@ void AUControl::CarbonViewResized()
{ {
return; return;
} }
auto vr = valueRestorer( mSettingSize, true );
// resize and move window // resize and move window
HIRect rect; HIRect rect;