1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-08 14:13:57 +01:00

Bug1257: Crash when enabling VST effect Amplio2...

... Suspected a threading bug in the library itself, which Audacity can
compensate with a short delay:  see code comments.

The other part of the complaint in 1257 -- that the play button would crash --
was a separate problem, fixed previously for bug 1242.
This commit is contained in:
Paul Licameli
2016-04-05 15:09:07 -04:00
parent cfcb876bc1
commit f0cbda835e

View File

@@ -239,6 +239,11 @@ bool LadspaEffectsModule::RegisterPlugin(PluginManagerInterface & pm, const wxSt
} }
if (lib.IsLoaded()) { if (lib.IsLoaded()) {
// PRL: I suspect Bug1257 -- Crash when enabling Amplio2 -- is the fault of a timing-
// dependent multi-threading bug in the Amplio2 library itself, in case the unload of the .dll
// comes too soon after the load. I saw the bug in Release builds but not Debug.
// A sleep of even 1 ms was enough to fix the problem for me, but let's be even more generous.
::wxMilliSleep(10);
lib.Unload(); lib.Unload();
} }