1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-07 16:07:44 +02:00

Make Effect::PopulateUI final (no special case for Equalization)

This commit is contained in:
Paul Licameli 2017-10-26 07:21:00 -04:00
parent 358aac3181
commit eff5b2ef92
3 changed files with 4 additions and 15 deletions

View File

@ -158,7 +158,7 @@ class AUDACITY_DLL_API Effect /* not final */ : public wxEvtHandler,
// EffectUIClientInterface implementation // EffectUIClientInterface implementation
void SetHostUI(EffectUIHostInterface *host) override; void SetHostUI(EffectUIHostInterface *host) override;
bool PopulateUI(wxWindow *parent) override; bool PopulateUI(wxWindow *parent) final;
bool IsGraphicalUI() override; bool IsGraphicalUI() override;
bool ValidateUI() override; bool ValidateUI() override;
bool HideUI() override; bool HideUI() override;

View File

@ -723,19 +723,6 @@ bool EffectEqualization::Process()
return bGoodResult; return bGoodResult;
} }
bool EffectEqualization::PopulateUI(wxWindow *parent)
{
mUIParent = parent;
mUIParent->PushEventHandler(this);
LoadUserPreset(GetCurrentSettingsGroup());
ShuttleGui S(mUIParent, eIsCreating);
PopulateOrExchange(S);
return true;
}
bool EffectEqualization::CloseUI() bool EffectEqualization::CloseUI()
{ {
mCurve = NULL; mCurve = NULL;
@ -746,6 +733,9 @@ bool EffectEqualization::CloseUI()
void EffectEqualization::PopulateOrExchange(ShuttleGui & S) void EffectEqualization::PopulateOrExchange(ShuttleGui & S)
{ {
if ( S.GetMode() == eIsCreating )
LoadUserPreset(GetCurrentSettingsGroup());
//LoadCurves(); //LoadCurves();
auto trackList = inputTracks(); auto trackList = inputTracks();

View File

@ -131,7 +131,6 @@ public:
bool Init() override; bool Init() override;
bool Process() override; bool Process() override;
bool PopulateUI(wxWindow *parent) override;
bool CloseUI() override; bool CloseUI() override;
void PopulateOrExchange(ShuttleGui & S) override; void PopulateOrExchange(ShuttleGui & S) override;
bool TransferDataToWindow() override; bool TransferDataToWindow() override;