diff --git a/src/export/ExportMP3.cpp b/src/export/ExportMP3.cpp index 436eb389f..9133dd022 100644 --- a/src/export/ExportMP3.cpp +++ b/src/export/ExportMP3.cpp @@ -810,7 +810,7 @@ public: }; MP3Exporter(); - virtual ~MP3Exporter(); + ~MP3Exporter(); #ifndef DISABLE_DYNAMIC_LOADING_LAME bool FindLibrary(wxWindow *parent); @@ -1625,7 +1625,7 @@ private: int FindValue(CHOICES *choices, int cnt, int needle, int def); wxString FindName(CHOICES *choices, int cnt, int needle); int AskResample(int bitrate, int rate, int lowrate, int highrate); - int AddTags(AudacityProject *project, ArrayOf &buffer, bool *endOfFile, const Tags *tags); + id3_length_t AddTags(AudacityProject *project, ArrayOf &buffer, bool *endOfFile, const Tags *tags); #ifdef USE_LIBID3TAG void AddFrame(struct id3_tag *tp, const wxString & n, const wxString & v, const char *name); #endif @@ -1806,9 +1806,8 @@ ProgressResult ExportMP3::Export(AudacityProject *project, } ArrayOf id3buffer; - int id3len; bool endOfFile; - id3len = AddTags(project, id3buffer, &endOfFile, metadata); + id3_length_t id3len = AddTags(project, id3buffer, &endOfFile, metadata); if (id3len && !endOfFile) { if (id3len > (int)outFile.Write(id3buffer.get(), id3len)) { // TODO: more precise message @@ -1819,7 +1818,7 @@ ProgressResult ExportMP3::Export(AudacityProject *project, wxFileOffset pos = outFile.Tell(); auto updateResult = ProgressResult::Success; - long bytes; + int bytes = 0; size_t bufferSize = std::max(0, exporter.GetOutBufferSize()); if (bufferSize <= 0) { @@ -2058,7 +2057,7 @@ using id3_tag_holder = std::unique_ptr; #endif // returns buffer len; caller frees -int ExportMP3::AddTags(AudacityProject *WXUNUSED(project), ArrayOf &buffer, bool *endOfFile, const Tags *tags) +id3_length_t ExportMP3::AddTags(AudacityProject *WXUNUSED(project), ArrayOf &buffer, bool *endOfFile, const Tags *tags) { #ifdef USE_LIBID3TAG id3_tag_holder tp { id3_tag_new() };