1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-19 17:40:15 +02:00

Fix bug 2069

Macros: Change Pitch in a Macro does not remember speed parameter setting
Also, Change Pitch did not remember settings after restart.
This commit is contained in:
Steve Daulton 2019-02-17 18:44:22 +00:00
parent 4ba373f2d9
commit e609a9dcef

View File

@ -215,6 +215,10 @@ bool EffectChangePitch::Process()
else else
#endif #endif
{ {
// Macros save m_dPercentChange and not m_dSemitonesChange, so we must
// ensure that m_dSemitonesChange is set.
Calc_SemitonesChange_fromPercentChange();
mSoundTouch = std::make_unique<soundtouch::SoundTouch>(); mSoundTouch = std::make_unique<soundtouch::SoundTouch>();
IdentityTimeWarper warper; IdentityTimeWarper warper;
mSoundTouch->setPitchSemiTones((float)(m_dSemitonesChange)); mSoundTouch->setPitchSemiTones((float)(m_dSemitonesChange));
@ -349,7 +353,6 @@ void EffectChangePitch::PopulateOrExchange(ShuttleGui & S)
} }
S.EndVerticalLay(); S.EndVerticalLay();
return; return;
} }
@ -468,7 +471,7 @@ void EffectChangePitch::DeduceFrequencies()
m_nToOctave = PitchOctave(dToMIDInote); m_nToOctave = PitchOctave(dToMIDInote);
m_FromFrequency = m_dStartFrequency; m_FromFrequency = m_dStartFrequency;
Calc_PercentChange(); // Calc_PercentChange(); // This will reset m_dPercentChange
Calc_ToFrequency(); Calc_ToFrequency();
} }