Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-14 16:46:28 +01:00
Code Issues Releases Wiki Activity

Get preview playback right for linear effects and special case

Browse Source 
for generate effects derived from Nyquist Prompt.
This commit is contained in:
Steve Daulton
2015-05-22 15:47:20 +01:00
parent b3092a53a8
commit e41425634a
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/effects/Effect.cpp
View File

@@ -2396,15 +2396,19 @@ void Effect::Preview(bool dryOnly)
gPrefs->Read(wxT("/AudioIO/EffectsPreviewLen"), &previewLen); gPrefs->Read(wxT("/AudioIO/EffectsPreviewLen"), &previewLen);
double rate = mProjectRate; double rate = mProjectRate;
double warpedPreviewLength = CalcPreviewInputLength(previewLen);
double t0 = mT0; double t0 = mT0;
double t1 = t0 + CalcPreviewInputLength(previewLen); double t1 = t0 + warpedPreviewLength;
// Generators can run without a selection. // Generators can run without a selection.
if (GetType() == EffectTypeGenerate) { if (GetType() == EffectTypeGenerate) {
// If a generator varies over time, it must use the selected duration. // If a generator varies over time, it must use the selected duration.
// otherwise set it as a linear effect and process no more than the preview length. // otherwise set it as a linear effect and process no more than the preview length.
// TODO: When previewing non-linear generate effect, calculate only the first 'preview length'. // TODO: When previewing non-linear generate effect, calculate only the first 'preview length'.
double dur = (mIsLinearEffect)? wxMin(mSetDuration, CalcPreviewInputLength(previewLen)) : mSetDuration; // For generate effects derived from the Nyquist Prompt, the duration is unknow, so
// ensure that we have at least preview length to copy.
double dur = (mIsLinearEffect)? wxMin(mSetDuration, warpedPreviewLength) :
wxMax(mSetDuration, warpedPreviewLength);
t1 = t0 + dur; t1 = t0 + dur;
this->SetDuration(dur); this->SetDuration(dur);
} }
@@ -2446,8 +2450,7 @@ void Effect::Preview(bool dryOnly)
mTracks->Add(mixRight); mTracks->Add(mixRight);
} }
// TODO: Don't really think this is necessary, but doesn't hurt // Reset t0 / t1 is required when source tracks have different start times.
// Reset times
t0 = mixLeft->GetStartTime(); t0 = mixLeft->GetStartTime();
t1 = mixLeft->GetEndTime(); t1 = mixLeft->GetEndTime();
} }
@@ -2472,8 +2475,15 @@ void Effect::Preview(bool dryOnly)
double t0save = mT0; double t0save = mT0;
double t1save = mT1; double t1save = mT1;
if (mIsLinearEffect) {
mT0 = t0;
mT1 = t1;
}
else {
mT0 = 0; mT0 = 0;
mT1 = t1 - t0; mT1 = t1 - t0;
}
// Apply effect // Apply effect