1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-22 06:22:58 +02:00

More consistent naming conventions for choice control items...

... This commit leaves at least a comment for all choice controls of all
built-in effects and commands.

Use CamelCase with no spaces for the internal identifiers, given in
wxT("...")

Use more idiomatic English with spaces in the user-visible names, given in
XO("..."); these strings go to the message catalog for internationalization

Do not use underscores

In case these strings are the same, give it just once in XO("..."), but if in
a future version it is decided to change the name in XO("..."), then the
original should be kept also in a distinct wxT("...") string, so that
saved configuration or plugin settings or macro files don't become gratuitously
incompatible just because of that user-visible name change.

Left TruncateSilence alone for now -- I think that choice demands a rewrite
as a slider instead.
This commit is contained in:
Paul Licameli
2018-03-27 14:17:23 -04:00
parent 6f52df545e
commit e1b60916b7
12 changed files with 63 additions and 46 deletions

View File

@@ -46,12 +46,12 @@ explicitly code all three.
const int nRelativeTos =6;
static const IdentInterfaceSymbol kRelativeTo[nRelativeTos] =
{
{ XO("Project Start") },
{ wxT("ProjectStart"), XO("Project Start") },
{ XO("Project") },
{ XO("Project End") },
{ XO("Selection Start") },
{ wxT("ProjectEnd"), XO("Project End") },
{ wxT("SelectionStart"), XO("Selection Start") },
{ XO("Selection") },
{ XO("Selection End") }
{ wxT("SelectionEnd"), XO("Selection End") }
};
bool SelectTimeCommand::DefineParams( ShuttleParams & S ){
@@ -169,6 +169,8 @@ bool SelectFrequenciesCommand::Apply(const CommandContext & context){
const int nModes =3;
static const IdentInterfaceSymbol kModes[nModes] =
{
// These are acceptable dual purpose internal/visible names
/* i18n-hint verb, imperative */
{ XO("Set") },
{ XO("Add") },