Fix warnings for out-of-order initializers, with in-class member initializers

src/prefs/PrefsDialog.cpp

@@ -204,8 +204,6 @@ PrefsDialog::PrefsDialog
             wxDefaultSize,
             wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER)
 , mFactories(factories)
-, mCategories(NULL)
-, mUniquePage(NULL)
 , mTitlePrefix(titlePrefix)
 {
    wxASSERT(factories.size() > 0);

src/prefs/PrefsDialog.h

@@ -76,8 +76,8 @@ class PrefsDialog /* not final */ : public wxDialog
 
 private:
    void RecordExpansionState();
-   wxTreebook *mCategories;
-   PrefsPanel *mUniquePage;
+   wxTreebook *mCategories{};
+   PrefsPanel *mUniquePage{};
    Factories &mFactories;
    const wxString mTitlePrefix;
 

src/prefs/SpectrogramSettings.cpp

@@ -57,10 +57,6 @@ SpectrogramSettings::Globals
 }
 
 SpectrogramSettings::SpectrogramSettings()
-   : hFFT(0)
-   , window(0)
-   , dWindow(0)
-   , tWindow(0)
 {
    LoadPrefs();
 }
@@ -93,10 +89,10 @@ SpectrogramSettings::SpectrogramSettings(const SpectrogramSettings &other)
 #endif
 
    // Do not copy these!
-   , hFFT(0)
-   , window(0)
-   , tWindow(0)
-   , dWindow(0)
+   , hFFT{}
+   , window{}
+   , tWindow{}
+   , dWindow{}
 {
 }
 

src/prefs/SpectrogramSettings.h

@@ -139,12 +139,12 @@ public:
 
 #ifdef EXPERIMENTAL_USE_REALFFTF
    // Variables used for computing the spectrum
-   mutable FFTParam      *hFFT;
-   mutable float         *window;
+   mutable FFTParam      *hFFT{};
+   mutable float         *window{};
 
    // Two other windows for computing reassigned spectrogram
-   mutable float         *tWindow; // Window times time parameter
-   mutable float         *dWindow; // Derivative of window
+   mutable float         *tWindow{}; // Window times time parameter
+   mutable float         *dWindow{}; // Derivative of window
 
 #endif
 };