Merge branch 'master' into scrubbing

src/Project.cpp

@@ -1879,6 +1879,9 @@ bool AudacityProject::HandleKeyDown(wxKeyEvent & event)
    if (wxGetTopLevelParent(wxWindow::FindFocus()) != this)
       return false;
 
+   if (event.GetKeyCode() == WXK_ESCAPE)
+      mTrackPanel->HandleEscapeKey(true);
+
    if (event.GetKeyCode() == WXK_ALT)
       mTrackPanel->HandleAltKey(true);
 
@@ -1925,6 +1928,9 @@ bool AudacityProject::HandleKeyUp(wxKeyEvent & event)
    if (wxGetTopLevelParent(wxWindow::FindFocus()) != this)
       return false;
 
+   if (event.GetKeyCode() == WXK_ESCAPE)
+      mTrackPanel->HandleEscapeKey(false);
+
    if (event.GetKeyCode() == WXK_ALT)
       mTrackPanel->HandleAltKey(false);
 
@@ -3287,10 +3293,28 @@ void AudacityProject::UnlockAllBlocks()
    }
 }
 
+class ProjectDisabler
+{
+public:
+   ProjectDisabler(wxWindow *w)
+   :  mWindow(w)
+   {
+      mWindow->GetEventHandler()->SetEvtHandlerEnabled(false);
+   }
+   ~ProjectDisabler()
+   {
+      mWindow->GetEventHandler()->SetEvtHandlerEnabled(true);
+   }
+private:
+   wxWindow *mWindow;
+};
+
 bool AudacityProject::Save(bool overwrite /* = true */ ,
                            bool fromSaveAs /* = false */,
                            bool bWantSaveCompressed /*= false*/)
 {
+   ProjectDisabler disabler(this);
+
    if (bWantSaveCompressed)
       wxASSERT(fromSaveAs);
    else

src/TrackPanel.cpp

@@ -1565,8 +1565,11 @@ void TrackPanel::MakeParentResize()
    mListener->TP_HandleResize();
 }
 
-void TrackPanel::HandleEscapeKey()
+void TrackPanel::HandleEscapeKey(bool down)
 {
+   if (!down)
+      return;
+
    switch (mMouseCapture)
    {
    case IsSelecting:
@@ -6335,60 +6338,6 @@ void TrackPanel::OnKeyDown(wxKeyEvent & event)
 {
    Track *t = GetFocusedTrack();
 
-   if (event.GetKeyCode() == WXK_ESCAPE) {
-      HandleEscapeKey();
-      return;
-   }
-
-#ifdef EXPERIMENTAL_SPECTRAL_EDITING
-#ifdef SPECTRAL_EDITING_ESC_KEY
-   // Test for pinning and unpinning of the center frequency
-   bool logF;
-   if (mAdjustSelectionEdges &&
-       event.GetKeyCode() == WXK_ESCAPE) {
-      if (mFreqSelMode == FREQ_SEL_SNAPPING_CENTER) {
-         // Toggle center snapping off
-         // (left click can also turn it off)
-         mFreqSelMode = FREQ_SEL_INVALID;
-      }
-      else if (isSpectrogramTrack(t, &logF)) {
-         WaveTrack *wt = static_cast<WaveTrack*>(t);
-         if (mFreqSelMode == FREQ_SEL_INVALID) {
-            // Toggle center snapping on (the only way to do this)
-            mFreqSelMode = FREQ_SEL_SNAPPING_CENTER;
-            StartSnappingFreqSelection(wt);
-         }
-         else {
-            // Handle ESC during frequency drag
-            wxMouseState state(::wxGetMouseState());
-            wxCoord yy = state.GetY();
-            ScreenToClient(NULL, &yy);
-            wxRect r;
-            if (wt == FindTrack(state.GetX(), yy, false, false, &r)) {
-               eFreqSelMode saveMode = mFreqSelMode;
-               mFreqSelMode = FREQ_SEL_PINNED_CENTER;
-
-               StartSnappingFreqSelection(wt);
-               MoveSnappingFreqSelection(yy, r.y, r.height, wt);
-               ExtendFreqSelection(yy, r.y, r.height);
-               UpdateSelectionDisplay();
-
-               mFreqSelMode = saveMode;
-               double hint = -1.0;
-               if (mFreqSelMode == FREQ_SEL_FREE) {
-                  hint = PositionToFrequency
-                     (true, yy, r.y, r.height, wt->GetRate(), logF);
-               }
-               ResetFreqSelectionPin(hint, logF);
-               // MakeParentModifyState(false);
-            }
-         }
-         // And don't skip event, yet
-      }
-   }
-#endif
-#endif
-
    // Only deal with LabelTracks
    if (!t || t->GetKind() != Track::Label) {
       event.Skip();

src/TrackPanel.h

@@ -182,7 +182,7 @@ class AUDACITY_DLL_API TrackPanel:public wxPanel {
    //virtual void SetSelectionFormat(int iformat)
    //virtual void SetSnapTo(int snapto)
 
-   void HandleEscapeKey();
+   virtual void HandleEscapeKey(bool down);
    virtual void HandleAltKey(bool down);
    virtual void HandleShiftKey(bool down);
    virtual void HandleControlKey(bool down);