From d06625ba60e00b2b4ee0c65c2415ecf7c637cea5 Mon Sep 17 00:00:00 2001 From: Paul Licameli Date: Fri, 21 Feb 2020 12:42:24 -0500 Subject: [PATCH] Revert "Fix unbalanced event handler push/pop" This reverts commit 8ac5699fcd625c102eacc3058ab748d3c5860006. --- src/tracks/ui/ScrubUI.cpp | 1 + src/tracks/ui/Scrubbing.cpp | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/tracks/ui/ScrubUI.cpp b/src/tracks/ui/ScrubUI.cpp index 56c0b0381..e1ce685c5 100644 --- a/src/tracks/ui/ScrubUI.cpp +++ b/src/tracks/ui/ScrubUI.cpp @@ -271,6 +271,7 @@ static const AudacityProject::AttachedObjects::RegisteredFactory sForwarderKey{ []( AudacityProject &parent ){ auto result = std::make_shared< ScrubForwarder >( parent ); auto &window = ProjectWindow::Get( parent ); + window.PushEventHandler( result.get() ); return result; } }; diff --git a/src/tracks/ui/Scrubbing.cpp b/src/tracks/ui/Scrubbing.cpp index 0797f160b..21697251a 100644 --- a/src/tracks/ui/Scrubbing.cpp +++ b/src/tracks/ui/Scrubbing.cpp @@ -241,6 +241,9 @@ Scrubber::~Scrubber() if (mpThread) mpThread->Delete(); #endif + + if ( mWindow ) + mWindow->PopEventHandler(); } static const auto HasWaveDataPred =