Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-08 14:13:57 +01:00
Code Issues Releases Wiki Activity

Resolves reported bugs and (most) recommendations

Browse Source 
All:

Export/Import now disabled if the Effect (family) doesn't support it
Options disabled if the Effect (family) doesn't support it
Standarized on "Latency compensation" instead of "Buffer delay compensation"
Correct loading/saving of factory default settings
Fixed "Mannage" to be "Manage"
Removed conditional code since we're keeping the transport buttons
Play bases state on actual playback status
Play no longer monkeys with selection
Play will now start from where it left off IF:
   The user stops the playback via the Effect Stop button
   If the user wants to restart from the beginning of the selection
   then the user can click Rewind while stopped.
Rewind will not go past start of selection (sorry Steve ;-))
   If Rewind is clicked while not playing, playback will next
   start at beginning of selection.
Fast Forward will stop at end of selection
   However, if FFwd is clicked while not playing, it will
   put playback at the end of selection and the next time
   the user clicks the Effect play button, playback will
   continue from the end of selection to the end of track.
Deleting a preset now prompts user to confirm
Button faces should now look a little better
Bypass (should we rename that???) button now grays when disabled

Audio Units:

Corrected all user visible "AudioUnit" strings to be "Audio Unit"
Removed unneeded "Buffer Size" in settings dialog
Only uses latency if user said it was okay

Ladspa:

Added settings dialog to allow control of latency usage
Removed unused "user selectable" buffer size
Only use latency if user wants it
Refresh controls when presets are loaded

VST:

Removed unused "Rescan at startup" setting
Propogate parameter loads to slave effects
This commit is contained in:
lllucius@gmail.com
2014-12-04 06:10:27 +00:00
parent dd766fd153
commit cddff18025
10 changed files with 430 additions and 319 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
src/effects/audiounits/AudioUnitEffect.cpp
View File

@@ -92,7 +92,7 @@ wxString AudioUnitEffectsModule::GetPath()
wxString AudioUnitEffectsModule::GetName()
{
return _("AudioUnit Effects Module");
return _("Audio Unit Effects Module");
}
wxString AudioUnitEffectsModule::GetVendor()
@@ -108,7 +108,7 @@ wxString AudioUnitEffectsModule::GetVersion()
wxString AudioUnitEffectsModule::GetDescription()
{
return _("Provides AudioUnit Effects support to Audacity");
return _("Provides Audio Unit Effects support to Audacity");
}
// ============================================================================
@@ -291,10 +291,8 @@ public:
private:
EffectHostInterface *mHost;
int mBufferSize;
bool mUseBufferDelay;
bool mUseLatency;
bool mUseGUI;
bool mRescan;
DECLARE_EVENT_TABLE()
};
@@ -304,11 +302,11 @@ BEGIN_EVENT_TABLE(AudioUnitEffectSettingsDialog, wxDialog)
END_EVENT_TABLE()
AudioUnitEffectSettingsDialog::AudioUnitEffectSettingsDialog(wxWindow * parent, EffectHostInterface *host)
: wxDialog(parent, wxID_ANY, wxString(_("AudioUnit Effect Settings")))
: wxDialog(parent, wxID_ANY, wxString(_("Audio Unit Effect Settings")))
{
mHost = host;
mHost->GetSharedConfig(wxT("Settings"), wxT("UseBufferDelay"), mUseBufferDelay, true);
mHost->GetSharedConfig(wxT("Settings"), wxT("UseLatency"), mUseLatency, true);
mHost->GetSharedConfig(wxT("Settings"), wxT("UseGUI"), mUseGUI, true);
ShuttleGui S(this, eIsCreating);
@@ -326,19 +324,19 @@ void AudioUnitEffectSettingsDialog::PopulateOrExchange(ShuttleGui & S)
{
S.StartVerticalLay(false);
{
S.StartStatic(_("Buffer Delay Compensation"));
S.StartStatic(_("Latency Compensation"));
{
S.AddVariableText(wxString() +
_("As part of their processing, some AudioUnit effects must delay returning ") +
_("As part of their processing, some Audio Unit effects must delay returning ") +
_("audio to Audacity. When not compensating for this delay, you will ") +
_("notice that small silences have been inserted into the audio. ") +
_("Enabling this setting will provide that compensation, but it may ") +
_("not work for all AudioUnit effects."))->Wrap(650);
_("not work for all Audio Unit effects."))->Wrap(650);
S.StartHorizontalLay(wxALIGN_LEFT);
{
S.TieCheckBox(_("Enable &compensation"),
mUseBufferDelay);
mUseLatency);
}
S.EndHorizontalLay();
}
@@ -347,7 +345,7 @@ void AudioUnitEffectSettingsDialog::PopulateOrExchange(ShuttleGui & S)
S.StartStatic(_("Graphical Mode"));
{
S.AddVariableText(wxString() +
_("Most AudioUnit effects have a graphical interface for setting parameter values.") +
_("Most Audio Unit effects have a graphical interface for setting parameter values.") +
_(" A basic text-only method is also available. ") +
_(" Reopen the effect for this to take effect."))->Wrap(650);
S.TieCheckBox(_("Enable &graphical interface"),
@@ -376,7 +374,7 @@ void AudioUnitEffectSettingsDialog::OnOk(wxCommandEvent & WXUNUSED(evt))
ShuttleGui S(this, eIsGettingFromDialog);
PopulateOrExchange(S);
mHost->SetSharedConfig(wxT("Settings"), wxT("UseBufferDelay"), mUseBufferDelay);
mHost->SetSharedConfig(wxT("Settings"), wxT("UseLatency"), mUseLatency);
mHost->SetSharedConfig(wxT("Settings"), wxT("UseGUI"), mUseGUI);
EndModal(wxID_OK);
@@ -415,7 +413,7 @@ BEGIN_EVENT_TABLE(AudioUnitEffectExportDialog, wxDialog)
END_EVENT_TABLE()
AudioUnitEffectExportDialog::AudioUnitEffectExportDialog(wxWindow * parent, AudioUnitEffect *effect)
: wxDialog(parent, wxID_ANY, wxString(_("Export AudioUnit Presets")))
: wxDialog(parent, wxID_ANY, wxString(_("Export Audio Unit Presets")))
{
mEffect = effect;
@@ -582,7 +580,7 @@ BEGIN_EVENT_TABLE(AudioUnitEffectImportDialog, wxDialog)
END_EVENT_TABLE()
AudioUnitEffectImportDialog::AudioUnitEffectImportDialog(wxWindow * parent, AudioUnitEffect *effect)
: wxDialog(parent, wxID_ANY, wxString(_("Import AudioUnit Presets")))
: wxDialog(parent, wxID_ANY, wxString(_("Import Audio Unit Presets")))
{
mEffect = effect;
@@ -1131,19 +1129,18 @@ bool AudioUnitEffect::SetHost(EffectHostInterface *host)
// mHost will be null during registration
if (mHost)
{
mHost->GetSharedConfig(wxT("Settings"), wxT("BufferSize"), mBufferSize, 8192);
mHost->GetSharedConfig(wxT("Settings"), wxT("UseBufferDelay"), mUseBufferDelay, true);
mHost->GetSharedConfig(wxT("Settings"), wxT("UseLatency"), mUseLatency, true);
mHost->GetSharedConfig(wxT("Settings"), wxT("UseGUI"), mUseGUI, true);
bool haveDefaults;
mHost->GetPrivateConfig(wxT("Default"), wxT("Initialized"), haveDefaults, false);
mHost->GetPrivateConfig(mHost->GetFactoryDefaultsGroup(), wxT("Initialized"), haveDefaults, false);
if (!haveDefaults)
{
SaveParameters(wxT("Default"));
mHost->SetPrivateConfig(wxT("Default"), wxT("Initialized"), true);
SaveParameters(mHost->GetFactoryDefaultsGroup());
mHost->SetPrivateConfig(mHost->GetFactoryDefaultsGroup(), wxT("Initialized"), true);
}
LoadParameters(wxT("Current"));
LoadParameters(mHost->GetCurrentSettingsGroup());
}
if (!mMaster)
@@ -1264,7 +1261,7 @@ sampleCount AudioUnitEffect::GetBlockSize(sampleCount maxBlockSize)
sampleCount AudioUnitEffect::GetLatency()
{
if (!mLatencyDone)
if (mUseLatency && !mLatencyDone)
{
mLatencyDone = true;
return mLatency * mSampleRate;
@@ -2026,6 +2023,11 @@ wxArrayString AudioUnitEffect::GetFactoryPresets()
return presets;
}
bool AudioUnitEffect::CanExport()
{
return true;
}
void AudioUnitEffect::ExportPresets()
{
AudioUnitEffectExportDialog dlg(mDialog, this);
@@ -2038,6 +2040,11 @@ void AudioUnitEffect::ImportPresets()
dlg.ShowModal();
}
bool AudioUnitEffect::HasOptions()
{
return true;
}
void AudioUnitEffect::ShowOptions()
{
AudioUnitEffectSettingsDialog dlg(mParent, mHost);

5
src/effects/audiounits/AudioUnitEffect.h
View File

@@ -117,8 +117,11 @@ public:
virtual wxArrayString GetFactoryPresets();
virtual bool CanExport();
virtual void ExportPresets();
virtual void ImportPresets();
virtual bool HasOptions();
virtual void ShowOptions();
// AudioUnitEffect implementation
@@ -186,7 +189,7 @@ private:
double mSampleRate;
int mBufferSize;
bool mUseBufferDelay;
bool mUseLatency;
AudioTimeStamp mTimeStamp;
bool mReady;