Correct TrackList::Swap -- mind the back-pointers in the tracks.

src/Track.cpp

@@ -754,6 +754,22 @@ void TrackList::Swap(TrackList &that)
    std::swap(mDestructorDeletesTracks, that.mDestructorDeletesTracks);
    std::swap(head, that.head);
    std::swap(tail, that.tail);
+
+   {
+      TrackListIterator iter(this);
+      for (Track *t = iter.First(); t; t = iter.Next()) {
+         t->SetOwner(NULL, NULL);
+         t->SetOwner(this, iter.cur);
+      }
+   }
+
+   {
+      TrackListIterator iter(&that);
+      for (Track *t = iter.First(); t; t = iter.Next()) {
+         t->SetOwner(NULL, NULL);
+         t->SetOwner(&that, iter.cur);
+      }
+   }
 }
 
 TrackList::~TrackList()

src/Track.h

@@ -252,6 +252,8 @@ class AUDACITY_DLL_API TrackListIterator /* not final */
    Track *RemoveCurrent(bool deletetrack = false); // returns next
 
  protected:
+   friend TrackList;
+
    TrackList *l;
    TrackListNode *cur;
 };