Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-08 14:13:57 +01:00
Code Issues Releases Wiki Activity

further constraints regarding bug 309, from off-list discussion with Steve

Browse Source
This commit is contained in:
v.audacity
2013-05-30 23:30:09 +00:00
parent 39f03edd8d
commit c39f9a4b53
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/effects/ChangePitch.cpp
View File

@@ -462,6 +462,7 @@ bool ChangePitchDialog::TransferDataFromWindow()
// calculations
//vvvvv Probaly unnecessary with fix to FreqToMIDInoteNumber(), but leave it in until we decide how to handle very low freq values.
void ChangePitchDialog::Calc_FromPitchIndex()
{
m_FromPitchIndex = (int)(m_ToPitchIndex - m_SemitonesChange) % 12;
@@ -600,16 +601,17 @@ void ChangePitchDialog::OnText_FromFrequency(wxCommandEvent & WXUNUSED(event))
this->Calc_ToFrequency();
this->Calc_ToPitchIndex();
//vvvvv Probaly unnecessary with fix to FreqToMIDInoteNumber(), but leave it in until we decide how to handle very low freq values.
// This is Steve's incremental fix for cross-updating issues related to bug 309.
// It's weird that in prior code (3 lines above this), we set m_FromPitchIndex,
// then call 2 Calc methods for the other members, and then this call to
// recalculate m_FromPitchIndex. Something's wrong there, but I want to figure
// out the overall best scheme, and this is an incremental fix.
this->Calc_FromPitchIndex();
// this->Calc_FromPitchIndex();
m_bLoopDetect = true;
this->Update_Choice_ToPitch();
this->Update_Choice_FromPitch();
this->Update_Choice_ToPitch();
this->Update_Text_ToFrequency();
m_bLoopDetect = false;