1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-13 08:06:32 +01:00

FindTrackRect omits all margins; better screen reader focus rects...

... Formerly it was outside of the yellow focus at the right side.  Now it
follows the yellow consistently on four sides.

The constant dx in TrackPanelAx::GetLocation might be adjusted.

No change of behavior is intended at other uses of FindTrackRect
This commit is contained in:
Paul Licameli
2017-06-04 10:55:46 -04:00
parent 134c1ff47a
commit c38efc1fcd
4 changed files with 33 additions and 17 deletions

View File

@@ -557,8 +557,10 @@ bool ScreenshotCommand::Apply(CommandExecutionContext context)
{
auto FindRectangle = []( TrackPanel &panel, Track &t )
{
// This rectangle omits the focus ring about the track
wxRect rect = panel.FindTrackRect( &t, true );
// This rectangle omits the focus ring about the track, and
// also within that, a narrow black border with a "shadow" below and
// to the right
wxRect rect = panel.FindTrackRect( &t, false );
// Enlarge horizontally.
// PRL: perhaps it's one pixel too much each side, including some gray
@@ -573,7 +575,8 @@ bool ScreenshotCommand::Apply(CommandExecutionContext context)
// rectangle allotted to the track, according to Track::GetY() and
// Track::GetHeight(), but also over the margin of the next track.)
int dy = kTopInset - 1;
rect.height += kBottomMargin;
int dy = kTopMargin - 1;
rect.Inflate( 0, dy );
// Reposition it relative to parent of panel