Calls to Disconnect or Unbind in destructors are not needed, if...

... it's either the source of the connection that is being destroyed, or other
object (such as an ancestor window) transitively owning it and so causing it to
be destroyed too;

or, the sink is being destroyed, and that sink is a wxEvtHandler (which is
always so for Disconnect, though not for Unbind in case Bind was passed a
member function of a non-wxEvtHandler).

wxWidgets takes care of erasing the connection in such cases.

This removes most calls to Disconnect and Unbind.  Many destructors shrank to
nothing.

Notably, in case of popup menu handling, the call to Disconnect is not removable
because the object being destroyed is neither the source nor the sink.

src/LyricsWindow.cpp

@@ -133,14 +133,6 @@ LyricsWindow::LyricsWindow(AudacityProject *parent):
    Center();
 }
 
-LyricsWindow::~LyricsWindow()
-{
-   mProject->Disconnect(EVT_TRACK_PANEL_TIMER,
-      wxCommandEventHandler(LyricsWindow::OnTimer),
-      NULL,
-      this);
-}
-
 void LyricsWindow::OnCloseWindow(wxCloseEvent & WXUNUSED(event))
 {
   this->Hide();