Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-21 22:12:58 +02:00
Code Issues Releases Wiki Activity

Limit access to global array of open projects & simplify iterations

Browse Source
This commit is contained in:
Paul Licameli
2019-05-29 14:19:01 -04:00
parent 0ae542cf08
commit b25d3ad344
15 changed files with 203 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/ondemand/ODManager.cpp
View File

@@ -421,7 +421,7 @@ void ODManager::Start()
{
mNeedsDraw=0;
wxCommandEvent event( EVT_ODTASK_UPDATE );
ODLocker locker{ &AudacityProject::AllProjectDeleteMutex() };
ODLocker locker{ &AllProjects::Mutex() };
AudacityProject* proj = GetActiveProject();
if(proj)
GetProjectFrame( *proj )

18
src/ondemand/ODTask.cpp
View File

@@ -129,13 +129,13 @@ void ODTask::DoSome(float amountWork)
ODManager::Instance()->AddTask(this);
//we did a bit of progress - we should allow a resave.
ODLocker locker{ &AudacityProject::AllProjectDeleteMutex() };
for(unsigned i=0; i<gAudacityProjects.size(); i++)
ODLocker locker{ &AllProjects::Mutex() };
for ( auto pProject : AllProjects{} )
{
if(IsTaskAssociatedWithProject(gAudacityProjects[i].get()))
if(IsTaskAssociatedWithProject(pProject.get()))
{
//mark the changes so that the project can be resaved.
UndoManager::Get( *gAudacityProjects[i] ).SetODChangesFlag();
UndoManager::Get( *pProject ).SetODChangesFlag();
break;
}
}
@@ -153,16 +153,16 @@ void ODTask::DoSome(float amountWork)
wxCommandEvent event( EVT_ODTASK_COMPLETE );
ODLocker locker{ &AudacityProject::AllProjectDeleteMutex() };
for(unsigned i=0; i<gAudacityProjects.size(); i++)
ODLocker locker{ &AllProjects::Mutex() };
for ( auto pProject : AllProjects{} )
{
if(IsTaskAssociatedWithProject(gAudacityProjects[i].get()))
if(IsTaskAssociatedWithProject(pProject.get()))
{
//this assumes tasks are only associated with one project.
GetProjectFrame( *gAudacityProjects[i] )
GetProjectFrame( *pProject )
.GetEventHandler()->AddPendingEvent(event);
//mark the changes so that the project can be resaved.
UndoManager::Get( *gAudacityProjects[i] ).SetODChangesFlag();
UndoManager::Get( *pProject ).SetODChangesFlag();
break;
}
}