1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-13 14:13:32 +02:00

Implement member functions of classes in corresponding .cpp files...

... in four cases; not in some other .cpp file.

This is another move that causes the generated graph to reflect dependencies
correctly.

This fixes other large, hidden cycles that involved PrefsDialog.cpp: there was
link dependency on that when PrefsPanel.h was used for the base class.  No
longer.

Also cycles involving TrackPanel.cpp, which contained the default
implementations for TrackPanelCell and related abstract base classes.
This commit is contained in:
Paul Licameli
2020-05-27 11:07:49 -04:00
parent 0c97138840
commit ae9aca8177
16 changed files with 323 additions and 278 deletions

View File

@@ -886,22 +886,3 @@ void ImportStreamDialog::OnCancel(wxCommandEvent & WXUNUSED(event))
{
EndModal( wxID_CANCEL );
}
ImportFileHandle::ImportFileHandle(const FilePath & filename)
: mFilename(filename)
{
}
ImportFileHandle::~ImportFileHandle()
{
}
void ImportFileHandle::CreateProgress()
{
wxFileName ff( mFilename );
auto title = XO("Importing %s").Format( GetFileDescription() );
mProgress = std::make_unique< ProgressDialog >(
title, Verbatim( ff.GetFullName() ) );
}

View File

@@ -0,0 +1,33 @@
/**********************************************************************
Audacity: A Digital Audio Editor
ImportPlugin.cpp
Paul Licameli split from Import.cpp
**********************************************************************/
#include "ImportPlugin.h"
#include <wx/filename.h>
#include "../widgets/ProgressDialog.h"
ImportFileHandle::ImportFileHandle(const FilePath & filename)
: mFilename(filename)
{
}
ImportFileHandle::~ImportFileHandle()
{
}
void ImportFileHandle::CreateProgress()
{
wxFileName ff( mFilename );
auto title = XO("Importing %s").Format( GetFileDescription() );
mProgress = std::make_unique< ProgressDialog >(
title, Verbatim( ff.GetFullName() ) );
}

View File

@@ -182,7 +182,4 @@ private:
const FileExtensions mExtensions;
};
// Unnecessary #include to indicate otherwise hidden link dependencies
#include "Import.h"
#endif