Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-18 00:50:05 +02:00
Code Issues Releases Wiki Activity

Bug 2726 - Enh: Some preference changes are not written until Audacity exits

Browse Source 
Also fixed a bug with GetPreferences, where uninitialised pointers
could be used that were only meant for use when editing values
(in which path they would be initialised).
This commit is contained in:
James Crook 2021-03-31 16:14:47 +01:00
parent da9283ac6c
commit ae5e768023
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/prefs/DirectoriesPrefs.cpp
View File

@ -207,7 +207,8 @@ void DirectoriesPrefs::PopulateOrExchange(ShuttleGui &S)
{PreferenceKey(Operation::Save, PathType::User), {PreferenceKey(Operation::Save, PathType::User),
wxT("")}, wxT("")},
30); 30);
mSaveText->SetValidator(FilesystemValidator(XO("Projects cannot be saved to FAT drives."))); if( mSaveText )
mSaveText->SetValidator(FilesystemValidator(XO("Projects cannot be saved to FAT drives.")));
S.Id(SaveButtonID).AddButton(XXO("B&rowse...")); S.Id(SaveButtonID).AddButton(XXO("B&rowse..."));
S.Id(ImportTextID); S.Id(ImportTextID);
@ -239,12 +240,14 @@ void DirectoriesPrefs::PopulateOrExchange(ShuttleGui &S)
{PreferenceKey(Operation::Temp, PathType::_None), {PreferenceKey(Operation::Temp, PathType::_None),
wxT("")}, wxT("")},
30); 30);
mTempText->SetValidator(FilesystemValidator(XO("Temporary files directory cannot be on a FAT drive."))); if( mTempText )
mTempText->SetValidator(FilesystemValidator(XO("Temporary files directory cannot be on a FAT drive.")));
S.Id(TempButtonID).AddButton(XXO("Brow&se...")); S.Id(TempButtonID).AddButton(XXO("Brow&se..."));
S.AddPrompt(XXO("&Free Space:")); S.AddPrompt(XXO("&Free Space:"));
mFreeSpace = S.Style(wxTE_READONLY).AddTextBox({}, wxT(""), 30); mFreeSpace = S.Style(wxTE_READONLY).AddTextBox({}, wxT(""), 30);
mFreeSpace->SetName(XO("Free Space").Translation()); if( mFreeSpace )
mFreeSpace->SetName(XO("Free Space").Translation());
} }
S.EndMultiColumn(); S.EndMultiColumn();
} }

1
src/widgets/FileHistory.cpp
View File

@ -153,6 +153,7 @@ void FileHistory::NotifyMenus()
for (auto pMenu : mMenus) for (auto pMenu : mMenus)
if (pMenu) if (pMenu)
NotifyMenu(pMenu); NotifyMenu(pMenu);
Save(*gPrefs, wxT("RecentFiles"));
} }
void FileHistory::NotifyMenu(wxMenu *menu) void FileHistory::NotifyMenu(wxMenu *menu)