From ad857551016947306e9d65e648bef0b1b8935727 Mon Sep 17 00:00:00 2001 From: James Crook Date: Fri, 27 Nov 2020 15:18:05 +0000 Subject: [PATCH] Bug 2600 - Compact project followed by undo restores the last saved state Uncompacted projects use up 50% or so more space than they could. The 'compact' feature as currently implemented is confusing, and does not merit inclusion given the lowish saving. So featured disabled/removed. --- src/menus/FileMenus.cpp | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/menus/FileMenus.cpp b/src/menus/FileMenus.cpp index 2cd8e7fed..53928aa1e 100644 --- a/src/menus/FileMenus.cpp +++ b/src/menus/FileMenus.cpp @@ -622,10 +622,15 @@ BaseItemSharedPtr FileMenu() AudioIONotBusyFlag() ), Command( wxT("SaveCopy"), XXO("&Backup Project..."), FN(OnSaveCopy), AudioIONotBusyFlag() ) - ), + )//, - Command( wxT("Compact"), XXO("Co&mpact Project"), FN(OnCompact), - AudioIONotBusyFlag(), wxT("Shift+A") ) + // Bug 2600: Compact has interactions with undo/history that are bound + // to confuse some users. We don't see a way to recover useful amounts + // of space and not confuse users using undo. + // As additional space used by aup3 is 50% or so, perfectly valid + // approach to this P1 bug is to not provide the 'Compact' menu item. + //Command( wxT("Compact"), XXO("Co&mpact Project"), FN(OnCompact), + // AudioIONotBusyFlag(), wxT("Shift+A") ) ), Section( "Import-Export",