Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-27 07:43:50 +01:00
Code Issues Releases Wiki Activity

Rearchitect the class hierarchy a little because of a problem Rob Sykes noted to me off-list, where it was using the key and default prefs methods from the base class rather than the descendant, even when those methods were overridden in the descendant.

Browse Source 
Also re-ordered and clarified several comments.
This commit is contained in:
v.audacity
2013-01-11 00:13:48 +00:00
parent 884f3ef01d
commit a08d0503be
3 changed files with 83 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/prefs/QualityPrefs.cpp
View File

@@ -110,12 +110,10 @@ void QualityPrefs::GetNamesAndLabels()
// We used to set and get best/fast method via Resample.cpp.
// Need to ensure that preferences strings in Resample.cpp match.
// Note that these methods used to be public and static, but are now protected and pure virtual.
// int converterHQ = Resample::GetBestMethod();
// int converter = Resample::GetFastMethod();
//
//vvvvv Note that we're now using libsoxr for constant-rate resampling
// and either libresample or libsamplerate for variable-rate,
// and currently *not* allowing method choice for variable-rate,
//vvv Note that we're now using libsoxr for constant-rate resampling
// and either libresample, libsamplerate, or libsoxr for variable-rate,
// and currently not allowing prefs method choice for variable-rate,
// per discussion on -devel.
int numConverters = ConstRateResample::GetNumMethods();
for (int i = 0; i < numConverters; i++) {