All preferences in scrollers

We now do not need to worry about the preference dialogs getting too big for small screens.

src/prefs/BatchPrefs.cpp

@@ -53,8 +53,10 @@ void BatchPrefs::Populate( )
 /// Defines the dialog and does data exchange with it.
 void BatchPrefs::PopulateOrExchange( ShuttleGui & S )
 {
-   S.StartHorizontalLay( wxEXPAND, 0 );
    S.SetBorder( 2 );
+   S.StartScroller();
+   S.StartHorizontalLay( wxEXPAND, 0 );
+
    S.StartStatic( _("Behaviors"),1 );
    {
 #ifdef __WXDEBUG__
@@ -64,7 +66,7 @@ void BatchPrefs::PopulateOrExchange( ShuttleGui & S )
    }
    S.EndStatic();
    S.EndHorizontalLay();
-
+   S.EndScroller();
    return;
 }
 

src/prefs/DevicePrefs.cpp

@@ -111,6 +111,7 @@ void DevicePrefs::PopulateOrExchange(ShuttleGui & S)
    wxArrayString empty;
 
    S.SetBorder(2);
+   S.StartScroller();
 
    S.StartStatic(_("Interface"));
    {
@@ -189,6 +190,7 @@ void DevicePrefs::PopulateOrExchange(ShuttleGui & S)
       S.EndThreeColumn();
    }
    S.EndStatic();
+   S.EndScroller();
 
 }
 

src/prefs/DirectoriesPrefs.cpp

@@ -79,6 +79,7 @@ void DirectoriesPrefs::Populate()
 void DirectoriesPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
+   S.StartScroller();
 
    S.StartStatic(_("Temporary files directory"));
    {
@@ -122,6 +123,8 @@ void DirectoriesPrefs::PopulateOrExchange(ShuttleGui & S)
    }
    S.EndStatic();
 #endif // DEPRECATED_AUDIO_CACHE
+   S.EndScroller();
+
 }
 
 void DirectoriesPrefs::OnChooseTempDir(wxCommandEvent & e)

src/prefs/EffectsPrefs.cpp

@@ -56,8 +56,8 @@ void EffectsPrefs::Populate()
 void EffectsPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
-
    S.StartScroller();
+
    S.StartStatic(_("Enable Effects"));
    {
 
@@ -159,8 +159,8 @@ void EffectsPrefs::PopulateOrExchange(ShuttleGui & S)
                     true);
    }
    S.EndStatic();
-   S.EndScroller();
 #endif
+   S.EndScroller();
 }
 
 bool EffectsPrefs::Commit()

src/prefs/ExtImportPrefs.cpp

@@ -85,6 +85,7 @@ void ExtImportPrefs::Populate()
 void ExtImportPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
+   S.StartScroller();
 
    S.TieCheckBox(_("A&ttempt to use filter in OpenFile dialog first"),
          wxT("/ExtendedImport/OverrideExtendedImportByOpenFileDialogChoice"),
@@ -182,6 +183,8 @@ void ExtImportPrefs::PopulateOrExchange(ShuttleGui & S)
       S.EndHorizontalLay();
    }
    S.EndStatic();
+   S.EndScroller();
+
    Layout();
    Fit();
    SetMinSize(GetSize());

src/prefs/GUIPrefs.cpp

@@ -123,8 +123,8 @@ void GUIPrefs::Populate()
 void GUIPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
-
    S.StartScroller();
+
    S.StartStatic(_("Display"));
    {
       S.StartMultiColumn(2);

src/prefs/ImportExportPrefs.cpp

@@ -50,6 +50,7 @@ void ImportExportPrefs::Populate()
 void ImportExportPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
+   S.StartScroller();
 
    S.StartStatic(_("When importing audio files"));
    {
@@ -101,6 +102,7 @@ void ImportExportPrefs::PopulateOrExchange(ShuttleGui & S)
    }
    S.EndStatic();
 #endif
+   S.EndScroller();
 }
 
 bool ImportExportPrefs::Commit()

src/prefs/LibraryPrefs.cpp

@@ -81,6 +81,8 @@ void LibraryPrefs::Populate()
 void LibraryPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
+   S.StartScroller();
+
    S.StartStatic(_("MP3 Export Library"));
    {
       S.StartTwoColumn();
@@ -161,6 +163,8 @@ void LibraryPrefs::PopulateOrExchange(ShuttleGui & S)
 #endif
    }
    S.EndStatic();
+   S.EndScroller();
+
 }
 
 /// Sets the a text area on the dialog to have the name

src/prefs/MidiIOPrefs.cpp

@@ -115,6 +115,7 @@ void MidiIOPrefs::PopulateOrExchange( ShuttleGui & S ) {
    wxArrayString empty;
 
    S.SetBorder(2);
+   S.StartScroller();
 
    S.StartStatic(_("Interface"));
    {
@@ -173,6 +174,8 @@ void MidiIOPrefs::PopulateOrExchange( ShuttleGui & S ) {
    }
    S.EndStatic();
 #endif
+   S.EndScroller();
+
 }
 
 void MidiIOPrefs::OnHost(wxCommandEvent & WXUNUSED(e))

src/prefs/ModulePrefs.cpp

@@ -101,7 +101,9 @@ void ModulePrefs::PopulateOrExchange(ShuttleGui & S)
    StatusChoices.Add( _("Ask" ) );
    StatusChoices.Add( _("Failed" ) );
    StatusChoices.Add( _("New" ) );
+
    S.SetBorder(2);
+   S.StartScroller();
 
    S.StartStatic( {} );
    {
@@ -110,7 +112,6 @@ void ModulePrefs::PopulateOrExchange(ShuttleGui & S)
       S.AddFixedText(wxString(wxT("  ")) + _("'Failed' means Audacity thinks the module is broken and won't run it.") );
       S.AddFixedText(wxString(wxT("  ")) + _("'New' means no choice has been made yet.") );
       S.AddFixedText(_("Changes to these settings only take effect when Audacity starts up."));
-      S.StartScroller();
       {
         S.StartMultiColumn( 2 );
         int i;
@@ -122,9 +123,9 @@ void ModulePrefs::PopulateOrExchange(ShuttleGui & S)
       {
         S.AddFixedText( _("No modules were found") );
       }
-      S.EndScroller();
    }
    S.EndStatic();
+   S.EndScroller();
 }
 
 bool ModulePrefs::Commit()

src/prefs/PlaybackPrefs.cpp

@@ -53,6 +53,7 @@ void PlaybackPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    wxTextCtrl *w;
 
+   S.StartScroller();
    S.SetBorder(2);
 
    S.StartStatic(_("Effects Preview"));
@@ -114,6 +115,8 @@ void PlaybackPrefs::PopulateOrExchange(ShuttleGui & S)
       S.EndThreeColumn();
    }
    S.EndStatic();
+   S.EndScroller();
+
 }
 
 bool PlaybackPrefs::Commit()

src/prefs/ProjectsPrefs.cpp

@@ -56,6 +56,7 @@ void ProjectsPrefs::Populate()
 void ProjectsPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
+   S.StartScroller();
 
    S.StartStatic(_("When saving a project that depends on other audio files"));
    {
@@ -71,6 +72,8 @@ void ProjectsPrefs::PopulateOrExchange(ShuttleGui & S)
       S.EndRadioButtonGroup();
    }
    S.EndStatic();
+   S.EndScroller();
+
 }
 
 bool ProjectsPrefs::Commit()

src/prefs/QualityPrefs.cpp

@@ -118,6 +118,7 @@ void QualityPrefs::GetNamesAndLabels()
 void QualityPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
+   S.StartScroller();
 
    S.StartStatic(_("Sampling"));
    {
@@ -204,6 +205,8 @@ void QualityPrefs::PopulateOrExchange(ShuttleGui & S)
       S.EndMultiColumn();
    }
    S.EndStatic();
+   S.EndScroller();
+
 }
 
 /// Enables or disables the Edit box depending on

src/prefs/RecordingPrefs.cpp

@@ -71,6 +71,7 @@ void RecordingPrefs::Populate()
 void RecordingPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
+   S.StartScroller();
 
    S.StartStatic(_("Playthrough"));
    {
@@ -220,6 +221,8 @@ void RecordingPrefs::PopulateOrExchange(ShuttleGui & S)
       }
       S.EndStatic();
    #endif
+   S.EndScroller();
+
 }
 
 bool RecordingPrefs::Commit()

src/prefs/SpectrumPrefs.cpp

@@ -158,13 +158,12 @@ void SpectrumPrefs::PopulatePaddingChoices(size_t windowSize)
 void SpectrumPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    mPopulating = true;
-
    S.SetBorder(2);
+   S.StartScroller(); {
 
    // S.StartStatic(_("Track Settings"));
    // {
 
-   S.StartScroller(); {
 
    mDefaultsCheckbox = 0;
    if (mWt) {

src/prefs/ThemePrefs.cpp

@@ -88,6 +88,7 @@ void ThemePrefs::Populate()
 void ThemePrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
+   S.StartScroller();
 
    S.StartStatic(_("Info"));
    {
@@ -146,6 +147,8 @@ void ThemePrefs::PopulateOrExchange(ShuttleGui & S)
       S.EndHorizontalLay();
    }
    S.EndStatic();
+   S.EndScroller();
+
 }
 
 /// Load Theme from multiple png files.

src/prefs/TracksBehaviorsPrefs.cpp

@@ -59,8 +59,8 @@ void TracksBehaviorsPrefs::Populate()
 void TracksBehaviorsPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
-
    S.StartScroller();
+
    S.StartStatic(_("Behaviors"));
    {
       S.TieCheckBox(_("A&uto-select, if selection required"),

src/prefs/TracksPrefs.cpp

@@ -119,8 +119,8 @@ void TracksPrefs::Populate()
 void TracksPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
-
    S.StartScroller();
+
    S.StartStatic(_("Display"));
    {
       S.TieCheckBox(_("&Pinned Recording/Playback head"),

src/prefs/WarningsPrefs.cpp

@@ -52,6 +52,7 @@ void WarningsPrefs::Populate()
 void WarningsPrefs::PopulateOrExchange(ShuttleGui & S)
 {
    S.SetBorder(2);
+   S.StartScroller();
 
    S.StartStatic(_("Show Warnings/Prompts for"));
    {
@@ -78,6 +79,8 @@ void WarningsPrefs::PopulateOrExchange(ShuttleGui & S)
                     true);
    }
    S.EndStatic();
+   S.EndScroller();
+
 }
 
 bool WarningsPrefs::Commit()

src/prefs/WaveformPrefs.cpp

@@ -76,6 +76,7 @@ void WaveformPrefs::PopulateOrExchange(ShuttleGui & S)
    mPopulating = true;
 
    S.SetBorder(2);
+   S.StartScroller();
 
    // S.StartStatic(_("Track Settings"));
    {
@@ -113,6 +114,8 @@ void WaveformPrefs::PopulateOrExchange(ShuttleGui & S)
    S.EndStatic();
    */
 
+   S.EndScroller();
+
    EnableDisableRange();
 
    mPopulating = false;